From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 623B512EBCE for ; Wed, 27 Mar 2024 16:17:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711556263; cv=none; b=Au7pYrOPcup6mjVayLtJMqU7bxidtPcUgHcPzKYRyI3A5FUoHNtPyga/5zQkyzQTvXdf/zG9kltajMEkb4+f1VRGx9Iya/uJ0Tmgyef0EQGIxEexiVZOTyV8bw1yhryUgmnniapB1vjOb84ATDGu2T5ZJnpi41mJdTFWjXjOJsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711556263; c=relaxed/simple; bh=Z1zM4v+LZMPNdR9n/IIXoKoDeuKUfs1IrT0aNWB0JSk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nl8Fm/qlTQ7qJaQFyVPf/1dHbG7nJNGkIuqbU0zRgPeA3PED/tWhI1hZsInLD/VpY28k7ulvqyzNTgm9txEb6Y7p9oCYBXwadjRlLlEMr8zO6M04MDQELFCJLwg6czHSVhmp0YYvTr7zOMqbKx4qvnhdYNM0pX8UJL1SfFt6+7M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Hc0el+eH; arc=none smtp.client-ip=209.85.166.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Hc0el+eH" Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-7d0772bb5ffso22245439f.0 for ; Wed, 27 Mar 2024 09:17:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1711556259; x=1712161059; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ftt6/au+tz9Vn0of2QleLPcLOfmPc15pHJvkugHM6CM=; b=Hc0el+eHX53G28dx8CTQVSQ1OSwncbzOd2t1GmSaZI+i67cKWJyJe8oPMDVpdKjYtC ee7hxMWD91Uef02fCIRNdqJ30jfhj6Q10FK0e/hgoX/L28iJTFsE64QCbfB9cq0oMEND 6jEQULnb8lU9hngdOjvK+xDnlk3onliJNFxbg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711556259; x=1712161059; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ftt6/au+tz9Vn0of2QleLPcLOfmPc15pHJvkugHM6CM=; b=PJsR9NJ0plzU9f0AvgC9k1uEw+Kl4XRKHXKGmz11yZ4MlSvwFO17ys1VGvZK5t8zf7 tVRPRXSxUADZOOj7zmz/OvbfkiReYl0gYb0IG7q3H+0aHSvYy278OX2568FQSUy++cYC uSdkM6HJZIH3u9wX9NF7arzWzA+wDcoshcXVXWvYMY8Uo1Zm9oNavXvvrJf1W6N8AawH pQNCSwJArz0mQZ7nEamhSRE2A4e0U3ro71SkwlvB1GpLsn865TtWsZL7x2XBS6lwTjlh JoWjG8+3CUKHbcrZEOi49Iz0vroc6QI/sF3bGUdW5uICf1tvnBORjTy3D9T9lKwKLRdA jGQA== X-Forwarded-Encrypted: i=1; AJvYcCWZAAlh3NqR9xuTE2CYbKRjo5H44jwLP/jOz27DlAc5jlxwd62ddNkTZ/D9g1NsERl3V94BO8rxb67gKa7RtnbULyYSNszSqphI2AQn X-Gm-Message-State: AOJu0YxoM1jwhQ3mfAV+UTYaO1KbpTx8B+W0edRzt7bk5V5hlZxTqs9e BGBvHiwjr/T+3q6XPowNFP8wtflBbiwmwt/mMtQjucrGLYpFI/YOvedTOIHGbjY= X-Google-Smtp-Source: AGHT+IHJnqZpMatl+qZQ1LDl54iQMZBuwpc4R+dinAMPjeUN8lwQYhJ9H0Tu6qAEhM9wr/eSuSlGag== X-Received: by 2002:a5e:9402:0:b0:7d0:3d2c:5987 with SMTP id q2-20020a5e9402000000b007d03d2c5987mr667271ioj.0.1711556259240; Wed, 27 Mar 2024 09:17:39 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id a4-20020a631a04000000b005e43cce33f8sm9428118pga.88.2024.03.27.09.17.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Mar 2024 09:17:38 -0700 (PDT) Message-ID: <069b0fc7-0f8c-42f6-9ba4-275fbd830912@linuxfoundation.org> Date: Wed, 27 Mar 2024 10:17:37 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] selftests: x86: test_vsyscall: conform test to TAP format output To: Muhammad Usama Anjum , Shuah Khan Cc: kernel@collabora.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20240314103216.286603-1-usama.anjum@collabora.com> <0dacf491-29ec-4c24-927e-978056177648@collabora.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <0dacf491-29ec-4c24-927e-978056177648@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/27/24 06:16, Muhammad Usama Anjum wrote: > On 3/27/24 1:00 AM, Shuah Khan wrote: >> On 3/14/24 04:32, Muhammad Usama Anjum wrote: >>> Conform the layout, informational and status messages to TAP. No >>> functional change is intended other than the layout of output messages. >>> Without using TAP messages, the passed/failed/skip test names cannot be >>> found. >>> >>> Signed-off-by: Muhammad Usama Anjum >>> --- >> >> >> I am seeing lot more changes than conform and formatting changes. > Counting total number of tests based on architecture was really difficult > until the code needed to be moved around. I'll split this patch into 2. The > first part would just simplify the test by moving functions around and use > #ifdef precisely. The seconds part would convert it to the TAP. > Yes. That will make is easier to review and maintain. thanks, -- Shuah