From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Christoph Winklhofer <cj.winklhofer@gmail.com>,
Jiri Slaby <jirislaby@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v4 3/3] w1: add UART w1 bus driver
Date: Mon, 8 Jan 2024 20:29:57 +0100 [thread overview]
Message-ID: <069b44ce-5d95-4d39-91f0-5167a5d941b1@linaro.org> (raw)
In-Reply-To: <ZZw46ZQ5JoxlWflG@cjw-notebook>
On 08/01/2024 19:03, Christoph Winklhofer wrote:
> ...
>>> +static int w1_uart_serdev_receive_buf(struct serdev_device *serdev,
>>> + const unsigned char *buf, size_t count)
>>
>> serdev already uses u8 * here. You are basing on the top of some old tree.
Old? Your change came for v6.8 and this was sent when all trees were
based on v6.7-rc1. What newer tree could have this been?
> Yes, this patch is based on the w1-next branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-w1.git
> was not sure from where to start. I guess that this change is probably in
> the w1-tree after the next stable release.
That's a timing issue. For that particular case, where this was
targeting next-next cycle, you should have based this on linux-next. In
other cases this would require cross-tree merging due to dependencies
which none of us were aware, so no harm.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-08 19:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-06 16:02 [PATCH v4 0/3] " Christoph Winklhofer via B4 Relay
2024-01-06 16:02 ` [PATCH v4 1/3] dt-bindings: w1: UART 1-Wire bus Christoph Winklhofer via B4 Relay
2024-01-13 1:39 ` Rob Herring
2024-01-13 18:04 ` Christoph Winklhofer
2024-01-14 10:54 ` Krzysztof Kozlowski
2024-01-14 14:47 ` Christoph Winklhofer
2024-01-14 15:55 ` Krzysztof Kozlowski
2024-01-15 17:36 ` Christoph Winklhofer
2024-01-15 18:02 ` Krzysztof Kozlowski
2024-01-16 7:10 ` Christoph Winklhofer
2024-01-06 16:02 ` [PATCH v4 2/3] dt-bindings: serial: allow onewire as child node Christoph Winklhofer via B4 Relay
2024-01-13 1:40 ` Rob Herring
2024-01-06 16:02 ` [PATCH v4 3/3] w1: add UART w1 bus driver Christoph Winklhofer via B4 Relay
2024-01-08 6:18 ` Jiri Slaby
2024-01-08 18:03 ` Christoph Winklhofer
2024-01-08 19:29 ` Krzysztof Kozlowski [this message]
2024-01-06 16:56 ` [PATCH v4 0/3] " Krzysztof Kozlowski
2024-01-06 17:57 ` Christoph Winklhofer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=069b44ce-5d95-4d39-91f0-5167a5d941b1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=cj.winklhofer@gmail.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®