From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933755AbcBQGbE (ORCPT ); Wed, 17 Feb 2016 01:31:04 -0500 Received: from mail-ob0-f177.google.com ([209.85.214.177]:36076 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933696AbcBQGbB (ORCPT ); Wed, 17 Feb 2016 01:31:01 -0500 User-Agent: K-9 Mail for Android In-Reply-To: <1455576405-16263-1-git-send-email-clemens.gruber@pqgruber.com> References: <1455576405-16263-1-git-send-email-clemens.gruber@pqgruber.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH v3] phy: marvell: Fix and unify reg-init behavior From: Florian Fainelli Date: Tue, 16 Feb 2016 22:30:48 -0800 To: Clemens Gruber , netdev@vger.kernel.org CC: linux-kernel@vger.kernel.org, "David S . Miller" , Andrew Lunn , Fabio Estevam Message-ID: <06DA03E4-274B-4CD6-BE39-94018C378967@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On February 15, 2016 2:46:45 PM PST, Clemens Gruber wrote: >For the Marvell 88E1510, marvell_of_reg_init was called too late, in >the >config_aneg function. >Since commit 113c74d83eef ("net: phy: turn carrier off on phy attach"), >this lead to the link not coming up at boot anymore, due to the phy >state machine being stuck at waiting for interrupts (off by default on >the 88E1510). >For seven other Marvell PHYs, marvell_of_reg_init was not called at >all. > >Add a generic marvell_config_init function, which in turn calls >marvell_of_reg_init. >PHYs, which already have a specific config_init function with a call to >marvell_of_reg_init, are left untouched. The generic >marvell_config_init >function is called for all the others, to get consistent behavior >across >all Marvell PHYs. > >Signed-off-by: Clemens Gruber Reviewed-by: Florian Fainelli Thanks! -- Florian