From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 689F7389105 for ; Tue, 25 Aug 2026 05:14:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787634844; cv=none; b=bVPtolHHK6J1FKX6+pYMkvTPn/oLk0awoMX8YT5k8bSCxyhWCBvLnSmSbJiZT9kipE3lEvCc+Nr+YuERVwVtL5vMWDJJqCIdcidk7fQlyM93gVNiMn6PMWTt3y3fseZecUftU/3mWKAhxyxNBT+LaOmReB0ozbywe7dGMnoyGhs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787634844; c=relaxed/simple; bh=Ugk3ZMPennCjMotYNWrJ5i3DkacCbwKqfslaRuIOipU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z1MpvBooJ9Gf4Qtl8M9Xn9ZTJqF4wEolU09Kn1mDENPSgdVBCBPDXW1xQ8RFgLaEB0QBUvyjUNRa2zixQX6HgXhZXB0RYFUm6mlcdwcrRskWQh2fRa8WJOKX7nDzhjyCssYoFnUkNwRKZXWdxTqEctpGXyqgc44r5g5tFUDvLvs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UGr70Hnv; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=i+eZYh1u; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UGr70Hnv"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="i+eZYh1u" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787634840; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K9OwnSzTLO9oC5dFpcmND+TzPw2bMH6k9WMlDpSF/Bk=; b=UGr70HnvPGaOpMK6VrvpZ8E9xCYqAQao+fz21ivtyB6YZGEMtVbRfwaBQwsTO90G8caA6T rjZ5SHaQKLw7f68LbF0e/+Tgp5VA8325ZfAcpmkArnBuOJ6LWVETyphNh1z7Uhz+17R8Nf O+8pZQ9x1jvWjydQYdogfHWK1/7he94= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-kSz_4jR7Nd-97qPdqIGtyQ-1; Tue, 25 Aug 2026 01:13:59 -0400 X-MC-Unique: kSz_4jR7Nd-97qPdqIGtyQ-1 X-Mimecast-MFC-AGG-ID: kSz_4jR7Nd-97qPdqIGtyQ_1787634838 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-38e5a616d07so5577906a91.2 for ; Mon, 24 Aug 2026 22:13:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787634838; x=1788239638; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=K9OwnSzTLO9oC5dFpcmND+TzPw2bMH6k9WMlDpSF/Bk=; b=i+eZYh1u6lQQowTxSmDrsYhq6iNKZhFaSA7iQC7OIvdyVHZiXu5EOc5AQovYOqiWHW QVv1VRYa2uMFlzi7rt7Pa11HszF3fj5U+2RLz4FhF4N8ij/MX9A/F3GIAStHAQCTurzO A6blF5xc+6zvZnntBzSA3L4L4PqP72HqjT5fwqK2fljwrCLUmrfl/rOLiatcsad2XVdI 1fCvyXyFTJTsGbJ/kkrSXZ6CugisNION65+nobv2ttHu6v1gXfkaNnRr0D3WlSPwzH3s K53LbcBSJ+fejwwFH5ssGheGszNBxQIe/D21XP5b1RFD/62SGt+W0Oq0+gEAmKJmoWcv ufYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787634838; x=1788239638; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=K9OwnSzTLO9oC5dFpcmND+TzPw2bMH6k9WMlDpSF/Bk=; b=m6o0PGN6AQ5k8DuhF24WKaKzuaYkuc39Gdf96I6rGc2DWpblNaYE4rnMgNgiWOd2sQ l3DJQ3v76yDQPNJPAOoFpi6T4Dz4/CxIos45R85llUuMQsmcBfowMp1IrCeaWSmpNsT3 Zx7FASFDO0yzqPSPEI/2wSvIIb9+jIAx8OBtPtJIOsTzi8CVuUr5VN4xiYh4ZBGDAxba w+GcG7g8xtPur1DZSZkfbD6R3fSgZqIUKLYnZbLd/FapttA09G0+fWh/nD/2Z6XbJ4hf FczXrj1BOJ2jFpxvxnn0nMK7pZWqYcc2Y1CIq3vm3PO5tWr+699GUzexvcwv7d6PpU3T Morg== X-Forwarded-Encrypted: i=1; AHgh+RrErBsb6nEnlC9EEjpnBR8a3CFfkAm+A+qnl0AZ9YI++RDDlvLYr/rXO9cdrO9NF2+zbgqCgr2csVPQ+oQ=@vger.kernel.org X-Gm-Message-State: AFuF++nUa3+ZQZI591FPpaRQ4KDnEzHqG9XCcm8UfwdJSsb3ofTBn8FD 9mxgcUVrSY5lKTIC8yU0jjXAIAgv9UwQW343DbPBDdl6Ig88aev4pA/p712jFg9A/5OFBowZfCy 2nV20jDoAp2CBU+e+loEnIGIO0tVW4ayoDTeRj/wc9OJ+KdFf8ct+R0MpVhuMRcArMQ== X-Gm-Gg: AR+sD10WrYNoYMlTgKmjr8CHPmYlPzcTb46uiK4i7TGB46ad7EPcFYPcWZJz+m2JxFw H0LtsJ2Mnt39gcWnVsYMBsg7DH9fm8jA/CN8NaijSJ2G7bVMXSlYlssxpKPrZ8EUmOZ9RNXoB3J yVXTqEHi5shWkxEB3bE4Kj4QmPRA/faZvaKut0iRreWOyeollMNFR2eb1owJQNn8OUS63ALGJlO c3h1bw9mMfjplyFGD7v2zCMZXMQKy/vLF+dTzszO721/Gnvf9E32Rd/7OeTU3kNyWKLEbIG2FfI 8omwK8YRK1NNh5fIAUFMRpdYP6bepo9msU5SoKuQB+7ycWgayReYoYKAmtiOvSBgjf/hG/sTp3t RRsTtB1MaFTVZts7K4A== X-Received: by 2002:a17:90b:184f:b0:395:5f43:4ec4 with SMTP id 98e67ed59e1d1-3964603084fmr8668903a91.0.1787634837952; Mon, 24 Aug 2026 22:13:57 -0700 (PDT) X-Received: by 2002:a17:90b:184f:b0:395:5f43:4ec4 with SMTP id 98e67ed59e1d1-3964603084fmr8668825a91.0.1787634837463; Mon, 24 Aug 2026 22:13:57 -0700 (PDT) Received: from [192.168.1.2] ([122.171.16.109]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39645da08desm2156603a91.17.2026.08.24.22.13.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2026 22:13:56 -0700 (PDT) Message-ID: <06a45c67-2642-4efa-994a-ee50cd40a697@redhat.com> Date: Tue, 25 Aug 2026 10:43:48 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] kexec: return -ENOEXEC from image probe functions on mismatch To: Will Deacon Cc: Catalin Marinas , Mark Rutland , Huacai Chen , WANG Xuerui , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Andrew Morton , Baoquan He , Mike Rapoport , Pasha Tatashin , Pratyush Yadav , Tao Liu , Philipp Rudo , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, kexec@lists.infradead.org, Bradley Morgan References: <20260821-mpilaniy-v3-0-76b355399d2e@redhat.com> <20260821-mpilaniy-v3-1-76b355399d2e@redhat.com> Content-Language: en-US From: Mukesh Pilaniya In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Will, On 24/08/26 7:37 pm, Will Deacon wrote: > On Fri, Aug 21, 2026 at 07:19:57PM +0530, Mukesh Pilaniya wrote: >> Several kexec_file_load() image probe functions return -EINVAL when >> they do not recognize the image format. A probe function that rejects >> an image should return -ENOEXEC to indicate that the image is not a >> recognized executable format. -EINVAL implies a problem with the >> syscall parameters, not with image recognition. >> >> kexec_image_probe_default() iterates through registered loaders and >> returns the last probe's error code to the caller. That error >> propagates as the kexec_file_load() return value to userspace. >> Returning -EINVAL from a probe when no loader matches is semantically >> incorrect and misleads userspace about the nature of the failure. >> >> Return -ENOEXEC from all probe functions and their helpers when the >> image format is not recognized. >> >> Signed-off-by: Mukesh Pilaniya >> Reviewed-by: Philipp Rudo >> Reviewed-by: Pratyush Yadav >> Reviewed-by: Bradley Morgan >> --- >> arch/arm64/kernel/kexec_image.c | 4 ++-- >> arch/loongarch/kernel/kexec_efi.c | 4 ++-- >> arch/riscv/kernel/kexec_image.c | 4 ++-- >> kernel/kexec_elf.c | 4 ++-- >> 4 files changed, 8 insertions(+), 8 deletions(-) > > Hmm, so after this patch, are there actually any implementations of .probe() > that return anything other than 0 or -ENOEXEC? I couldn't spot any after > a quick look. > > Willkexec_elf_probe() can return -ENOMEM if memory allocation (kzalloc()) fails inside elf_read_phdrs(). This behavior was previously discussed in the first patch of this series [1]. [1] https://lore.kernel.org/all/0d7acb43-2eb4-44ec-9bfb-b89440afc605@redhat.com/#t -- Regards, Mukesh Pilaniya