From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD1342080F1 for ; Thu, 19 Dec 2024 12:25:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734611112; cv=none; b=HRe4vW6jDYbaSKmL5UQpb/983DloJ2k5xJbH42669nnmT8xxAgMOX4gNF9ACREwaSt2NP3Mg7TmpOpDGJBP+2oE4GcHKrAlxoNe8J2Mc2OTel+e5al0UaYao036ZmhoQANrXN4bgFsHC4IFVZ5xuop/N99sIL8a/XWgtYSjM8NA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734611112; c=relaxed/simple; bh=PkUBj1YbzWhoJclLSvkMO/RGqjOE6MatHyndzql4h5s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s+KHnepRBVvhm0/8u2y6utnUVoO4i4d3Rj1yA0g0mfh5CZiHkMi25/inthfFoPPxUSWIx2Zj/vnzpS3YqV/8txCxdNiq5Nl0SNrl0cE0uUMTd6BPFsLpD0sAp7FnKfZyGbe8sYbecrPqfGdi8uHK/MOw3hc9NyCPRguaPUDeFlo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=F4o+Cotc; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="F4o+Cotc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734611109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FKLah1kylTl9Wdpagtc1Y5cy3tJOoD9NlCHAoPZtrLs=; b=F4o+CotcBCkRlFgKP1e+CGX9o8h1sUuYVOpWv364pRe4BxPkY/ZuYXl5jgLYpe1/iyMj9O kpWSwbvCzYqUcbW/gZLfGIkBZGHS4HP/sGatsHDEF7l5+tPjxWAYdAeGBBW1/XinWvaYBB 63P3EsB/Xns/6g7df3xx9dNNfaRCuys= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-364-qOC-xmDdPKuuSN179dhECw-1; Thu, 19 Dec 2024 07:25:08 -0500 X-MC-Unique: qOC-xmDdPKuuSN179dhECw-1 X-Mimecast-MFC-AGG-ID: qOC-xmDdPKuuSN179dhECw Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5401a41056fso314900e87.0 for ; Thu, 19 Dec 2024 04:25:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734611107; x=1735215907; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=FKLah1kylTl9Wdpagtc1Y5cy3tJOoD9NlCHAoPZtrLs=; b=X+2RNJ6Hn7pcxWeUTcqOSCbmERbQpkcVx9fjuUxHB5t7biywI4tzwVVnio9XUMr/Uk Zm2+S5UcsRBZ61Q9ozAATLk3w3rMhbUOB0KyaWbByYkP/A3lXa/WpHqEeWJR6+ILMiEc fpLczuKZqOEhlKe24tf2c60nMNZXkgsIfiqFS8/kxeWg8UAQJ+mOtJPmIjqjSXIhn6Or 7UtZvUHO2BaLOdyC3PiKa9WYLMDhx0mz7mptj4lnik14T0BNXtR5/EaUd1lqdbVkH/fY oMUUlVAn+EbVsosk3XKekDPTyFhTtq2hS1e5gDc6YeXOb4XE2ORdqDj7MsddCFPRSmWA XQCQ== X-Forwarded-Encrypted: i=1; AJvYcCVsg6FlRCldKT4B1ZUe4KAgpFSPf+zqla9g5svnmNoGLVUZ/PuHhRaqF9eFxmvm4M898VD0jMVer/HFGUA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8LqHihnQj1b/YO9ZREg34hYpWw798e/WsmydWKPbzD1NLfIFT Gi33HOSErKiCyIlIHhUfemkpyEJleQJerK7ZCrG/yWhvA0c4Gx48F7jiKbxJpfAFC6RQL79Y43A UJ1iY946zykWtAyfs0UGBkzP+yj5w2XqthlY2+3TMMjYD9zzNGxx5gPqE460E/A== X-Gm-Gg: ASbGncs9J+npzbRjtSePP5GHmrTTnDV/AuubddhEQilR/bmrDgXcqS0ARxBW47MU53O it5Sxznw/UP/A2y0zCcpId8YsabpFMCuCbiAb22S1y3RkEFsN0cu6alVzPcXbF9EOzmEC+4uGdL Ah2KnzY98rUXcSG5VQJx6Rh0PCycx3kHEcu21IfOd2Db3xWAVQamVMFRlfjPzH/jPDGHAamWPlW G2VHsMdktlXn0QV9RnBEIOkp9PgInFIzYoMg8kUva4o+ckwgl2muWMraSBX2xgEUXOvMuCXCD81 oNu/HKkL97RwApB9iR7OyaNv5tK6CqvIkTbMV+C0PC2BpzmpXxfUs5/5Je0y8LoP4HVc+eghs+6 xXpBmwQ== X-Received: by 2002:a5d:64a9:0:b0:386:3803:bbd8 with SMTP id ffacd0b85a97d-388e4dadd3cmr5908500f8f.59.1734610726294; Thu, 19 Dec 2024 04:18:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IG8G6WL9ISj/7Ydh1h6ladKLp3UDwqN34Cpo2NYmH3h/F881jCroj3yPd2SsM7mZjqCewchBA== X-Received: by 2002:a5d:64a9:0:b0:386:3803:bbd8 with SMTP id ffacd0b85a97d-388e4dadd3cmr5908472f8f.59.1734610725938; Thu, 19 Dec 2024 04:18:45 -0800 (PST) Received: from ?IPV6:2003:cb:c749:6600:b73a:466c:e610:686? (p200300cbc7496600b73a466ce6100686.dip0.t-ipconnect.de. [2003:cb:c749:6600:b73a:466c:e610:686]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436611ea423sm17128495e9.2.2024.12.19.04.18.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Dec 2024 04:18:45 -0800 (PST) Message-ID: <06a45f8a-0981-40a2-a12a-5964fcdace13@redhat.com> Date: Thu, 19 Dec 2024 13:18:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/memory-failure: fix VM_BUG_ON_PAGE(PagePoisoned(page)) when unpoison memory To: Miaohe Lin , akpm@linux-foundation.org Cc: nao.horiguchi@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dan Williams References: <20241219115209.574065-1-linmiaohe@huawei.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241219115209.574065-1-linmiaohe@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19.12.24 12:52, Miaohe Lin wrote: > When I did memory failure tests recently, below panic occurs: > > page dumped because: VM_BUG_ON_PAGE(PagePoisoned(page)) > kernel BUG at include/linux/page-flags.h:616! > Oops: invalid opcode: 0000 [#1] PREEMPT SMP NOPTI > CPU: 3 PID: 720 Comm: bash Not tainted 6.10.0-rc1-00195-g148743902568 #40 > RIP: 0010:unpoison_memory+0x2f3/0x590 > RSP: 0018:ffffa57fc8787d60 EFLAGS: 00000246 > RAX: 0000000000000037 RBX: 0000000000000009 RCX: ffff9be25fcdc9c8 > RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff9be25fcdc9c0 > RBP: 0000000000300000 R08: ffffffffb4956f88 R09: 0000000000009ffb > R10: 0000000000000284 R11: ffffffffb4926fa0 R12: ffffe6b00c000000 > R13: ffff9bdb453dfd00 R14: 0000000000000000 R15: fffffffffffffffe > FS: 00007f08f04e4740(0000) GS:ffff9be25fcc0000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000564787a30410 CR3: 000000010d4e2000 CR4: 00000000000006f0 > Call Trace: > > unpoison_memory+0x2f3/0x590 > simple_attr_write_xsigned.constprop.0.isra.0+0xb3/0x110 > debugfs_attr_write+0x42/0x60 > full_proxy_write+0x5b/0x80 > vfs_write+0xd5/0x540 > ksys_write+0x64/0xe0 > do_syscall_64+0xb9/0x1d0 > entry_SYSCALL_64_after_hwframe+0x77/0x7f > RIP: 0033:0x7f08f0314887 > RSP: 002b:00007ffece710078 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 > RAX: ffffffffffffffda RBX: 0000000000000009 RCX: 00007f08f0314887 > RDX: 0000000000000009 RSI: 0000564787a30410 RDI: 0000000000000001 > RBP: 0000564787a30410 R08: 000000000000fefe R09: 000000007fffffff > R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000009 > R13: 00007f08f041b780 R14: 00007f08f0417600 R15: 00007f08f0416a00 > > Modules linked in: hwpoison_inject > ---[ end trace 0000000000000000 ]--- > RIP: 0010:unpoison_memory+0x2f3/0x590 > RSP: 0018:ffffa57fc8787d60 EFLAGS: 00000246 > RAX: 0000000000000037 RBX: 0000000000000009 RCX: ffff9be25fcdc9c8 > RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff9be25fcdc9c0 > RBP: 0000000000300000 R08: ffffffffb4956f88 R09: 0000000000009ffb > R10: 0000000000000284 R11: ffffffffb4926fa0 R12: ffffe6b00c000000 > R13: ffff9bdb453dfd00 R14: 0000000000000000 R15: fffffffffffffffe > FS: 00007f08f04e4740(0000) GS:ffff9be25fcc0000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000564787a30410 CR3: 000000010d4e2000 CR4: 00000000000006f0 > Kernel panic - not syncing: Fatal exception > Kernel Offset: 0x31c00000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff) > ---[ end Kernel panic - not syncing: Fatal exception ]--- > > The root cause is that unpoison_memory() tries to check the PG_HWPoison > flags of an uninitialized page. So VM_BUG_ON_PAGE(PagePoisoned(page)) is > triggered. This can be reproduced by below steps: > 1.Offline memory block: > echo offline > /sys/devices/system/memory/memory12/state > 2.Get offlined memory pfn: > page-types -b n -rlN > 3.Write pfn to unpoison-pfn > echo > /sys/kernel/debug/hwpoison/unpoison-pfn > > Signed-off-by: Miaohe Lin > --- > v2: Use pfn_to_online_page per David. Thanks. > --- > mm/memory-failure.c | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index a7b8ccd29b6f..02be0596ce67 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -2556,10 +2556,18 @@ int unpoison_memory(unsigned long pfn) > static DEFINE_RATELIMIT_STATE(unpoison_rs, DEFAULT_RATELIMIT_INTERVAL, > DEFAULT_RATELIMIT_BURST); > > - if (!pfn_valid(pfn)) > - return -ENXIO; > + p = pfn_to_online_page(pfn); > + if (!p) { > + struct dev_pagemap *pgmap; > > - p = pfn_to_page(pfn); > + if (!pfn_valid(pfn)) > + return -ENXIO; > + pgmap = get_dev_pagemap(pfn, NULL); > + if (!pgmap) > + return -ENXIO; > + put_dev_pagemap(pgmap); > + p = pfn_to_page(pfn); > + } Hm, I wonder if we can do anything reasonable with ZONE_DEVICE pages here? CCing Dan, maybe he knows if this interface used to do something reasonable with ZONE_DEVICE pages. Also, I'm not sure about using the page after doing the put_dev_pagemap(). Likely we would have to do that at the before exiting from this function. -- Cheers, David / dhildenb