From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751626AbdI0Gjv (ORCPT ); Wed, 27 Sep 2017 02:39:51 -0400 Received: from mout.web.de ([212.227.15.14]:55651 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbdI0Gjt (ORCPT ); Wed, 27 Sep 2017 02:39:49 -0400 Subject: Re: ALSA: bebob: Use common error handling code in snd_bebob_stream_start_duplex() To: Takashi Sakamoto , alsa-devel@alsa-project.org Cc: Clemens Ladisch , Jaroslav Kysela , Takashi Iwai , kernel-janitors@vger.kernel.org, LKML References: <85f95150-9cec-7a53-7692-837ba543e1ec@users.sourceforge.net> <541f0f9f-fc87-f65b-bbd8-fec5d45d5d2e@users.sourceforge.net> <3afecbef-b7ac-a4e8-f439-a351916f05e5@users.sourceforge.net> <09bb0e83-01fe-cd12-a084-31db3f12d663@sakamocchi.jp> From: SF Markus Elfring Message-ID: <06a8e3ee-c3c3-b4c7-0cf9-69a2efdaf0ba@users.sourceforge.net> Date: Wed, 27 Sep 2017 08:38:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <09bb0e83-01fe-cd12-a084-31db3f12d663@sakamocchi.jp> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:BT020cEnC6ZKnrNmDDvn3tZjhBcflyjSPzN/RH7T9WHGDCHtmlv 5+CrTQ5xjMzWEligG1RNON1WBo07fCLCNpORDZCIocDM2Rwpmhl5HhIQK1YnZ0r0EeC3oVo a+gkosL38UCwVQ0LAKM5swdies/zAMiONjhnY4VOn7wTroOghtVzR/1TQaoPlLlr4u7p89z y22cer+zC9Vt2KxF/qolw== X-UI-Out-Filterresults: notjunk:1;V01:K0:dKMcIWuyYNU=:vLmE5yBINPWNeFqbs5asCg /TmsGSypO+5Q8OC6XmYpDKQhpIVTZf+brDVIUs+349xXczLLZkbWH/7L6GeSfwUeg3rCa380V Ebi7Agp5FbMxoTjzKQXx4KjnFz653A9OiDiXbYXpkxJa/tMWR+1XKLOguLhacOlYueGn4USqH Ad1ycLdgyhnUinTAeCxiaEDM22BdLC9dlE/pAw+sSUDKYaC9X8kZDlJ6ikl8puJAzg3O36Myv htv6ObNIZbMcLoFI38CxLPEAnxv0TSU3lcfxzn9y1rESaMR2McK9QR50X3jC06UgM9eHvmteu ArA7lub1l8t3AltjxnQUQIkAFwiwrmRZWv+V+GU+0UrsYeOyfdjfdP+7m2lQjWpaZRJm2zX7y /vXzQN3FN8SnBkNUQM7w/SlED4koROU/nR55DDVtXNDQENUKEbrsQ4M3yFFoYwdmS8cv54RAU bvgmVrr4X+acIhJLUjBl9H1HyrZvgwmI2F0Duvm0Pj0IrGaOIEpuLvXRVV9e3lysSPZuY3Awy UnZVe95eI6ebqZU+pQePIaGAw45GxpxRGi5/6p4MhUVD2DwBrzliihd5FqC7DwH8pJmkeMWQ7 3MrTndZTJOCWwlFtWQar3pR9I2TJTnCq8dlRXpp0KNagTrEofqKrVYy14DQKYrY+g/JF62pAF 8CdYkyhu6Ts8JsNdnMxKE4uTpt4yx4ikASPHZX3Ub5DjdrkT06/il/6y6fNmY1Sdqw99BCM5p t68QI7YXbQEYmuuCnFved9Mq9C7y9k+4icpoYckaVhESs4LKGwah6d0Wbm7iiX4JKayMJyZYw FwW7yWynDKuRxTM+4k8DrHqzZFr1LgcgD4OtCSDspZihVvdcQ8= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > As long as I know, the last product with this solution was shipped > at 2010. Thus the driver is under maintenance. Thanks for your information. > I have some tasks for this driver as well as drivers in ALSA firewire stack, > however basically this driver is under maintenance and might not get > further integration. Good to know in principle … > I think that code cleanup for the driver don't help the other developers. I thought in an other direction if other contributors would like to care for longer term support. > It's better to apply such cleanup to more long-live codes such as > core functionality of ALSA. I am trying another general transformation pattern out. > In this point of view, whether your patchset is worth to be applied > or not, Please keep enough time to think about. Automatic source code analysis can find various update candidates. I am just unsure if a bit more software development attention is still appropriate at some places. Do you find any of the affected software modules so outdated so that they should not be touched any more? Regards, Markus