From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6864723D7DC for ; Tue, 28 Jul 2026 00:57:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785200257; cv=none; b=bGD7MjRj3Gtm1pkt+4L1+EGJAWBFigKMZE8MRiN4euKj6wq78RWsFknZRK3v8jqHTtPTEU+nXxElrii/RyHguUEZIW59yhtFWWDXAgJN8QwUP8rXu+j7LN0UUddi8x6sleLFxpERRRa2xwib2JsLvWb9FQn6ompwy9FadZapmXc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785200257; c=relaxed/simple; bh=r7Xt4sAN1oMMGOrDoEkCQxEemememLGVjRCSa6gxa1Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gJj//ZgDou4BSBqdgGU4u1GFUFQ5KUMhtDuvOQnCGv3SwYHtAME1vEEdBRGHfLqCc3p2kByW4hWrdCuX26OzkHZ1l60zU2UwazVxXBbe6TJ9pUVIji+v8QoFf0hyzxr2zi9sJouci2K+nE0v7Dx2NsrsB3nV9OaLfBqNzZ2BgTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lk8BA1YD; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lk8BA1YD" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2cf6d65d8a7so48835365ad.0 for ; Mon, 27 Jul 2026 17:57:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785200256; x=1785805056; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Qto3bVGMAs/3+VEzt+gxU2EaDabuY+anOP1PDkQG9cg=; b=lk8BA1YDwDBlfXA4C43KrCkzrBUe5RzgxKjfXDkZ3uWNugp+ZXm/uV3nLevLlMBczf twGXNddeM+xJY/ybqefreMc/syGA9kfDHOGlm4uMiijLuwBKPWOmGdA7mo7BN35OqapO 08u+wG7MhX7K/nqw94R5f3JlnUqOQeozn2JHTpfXWUeIixEWcLBqbHl6mFEB/xy2tpnW fGNpkrfbNfHW1XD97r1YL15h4sAG0vGyxjQCv1GA0+68I5pd9WjS5h9k57X27RcZbFEi V5V6mZ19WUArvX8/O8su06lqLQ3jxMQMuSbAnviVbXeny3160066yUO2rOmGMirLdJnC d46g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785200256; x=1785805056; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Qto3bVGMAs/3+VEzt+gxU2EaDabuY+anOP1PDkQG9cg=; b=FjUsJB5YrnRedv4dW9TaAbWeTcS4AG1eq2z9gvpQXe9jH7Fu22LMeU90DA2z8jkqUA FmRhVYh9tM49CtOAhQRonZuIDs70iXNAnjsi/lo8ZPhZX9gUjR/1SwXOQCbAzhZx6C60 Yvjk+akpfFVRnmqHuD7Xc7afKLWssOMpVROROXlw79j008xqW8ctar/bjWZoA7I5kZrK xYCW8McPA6LCzDG16GJZqcn4cNJLTue+ZGkGNKUG70NxdPqISTMNKMUU5uYEY7rO/zzE TQ6TEw/4FlB0R3pzNJ9rJjVQ6xmS8RYoCf00bRtmx4iPc5m79Gp/NcRw89Q387eSnZLt 7uwg== X-Forwarded-Encrypted: i=1; AHgh+Rq/5z+jf8VxsMRdBTLU66WPMij9cWAkLIIgAE0nG2A65ZozScNrhU8A4Ya1teBDpyCuFaM3akjyTaIOqHw=@vger.kernel.org X-Gm-Message-State: AOJu0YyeixEJ/mPXyb9xJFG4EdtD9Az7NCLA7Yg2LamkGf7vSi6QKy7z bAy8HkKXjF4UKDsLNlNDd2P2kJHVh7cGDvGY8BOZiUHr25MEiiTK6AiV X-Gm-Gg: AR+sD10JWoyAG/mfAeVer4rPmY2tK1UrTWy4FddZjMYXQLZALpH9kKasEnEkyHbHdaq rT8kaVfUlKO4LpfxdCyaBSqU/CpWTzU7z7HEQ8yLFRFrx6UObZoak01tkWQr3NhfS1P3qCn445b ccW+qTV6rdNWb0E1GAdVoHSF1dZ9NM0HLyuDPTFjiDaIRR9PM6lYiAXoAI9Z2Z+aFJFLIOk4j8O rIUZuXm+Jt4xB1P3xVsThbes2T1qD5AIMRIEZ4KXus+6ZoFQ0Cx6VXWmFOqyxOvy13u7831PlZX LFJXCooWW9pP2wpEKF6Cs1LoHLC2GJfjlWEjJmox0U4s1jxqIuKpDkP9t+5vk/fmzdqA7gjpnjf JF8rhJcuwoZbbHvcCOFZyjDndmTNtBdhRgA1MjrxIFFoEZ0fdrhBg0SrDanVV+tlriBVlPTakWi 6IfI28ZdwmPR/Ck/6oFUnfB8HnKQ== X-Received: by 2002:a17:903:1844:b0:2ca:d91d:d3a7 with SMTP id d9443c01a7336-2d015c9cd4cmr2532745ad.10.1785200255750; Mon, 27 Jul 2026 17:57:35 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfde5e8a44sm43786245ad.35.2026.07.27.17.57.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 17:57:35 -0700 (PDT) Sender: Guenter Roeck Date: Mon, 27 Jul 2026 17:57:34 -0700 From: Guenter Roeck To: Luiz Angelo Daros de Luca Cc: Chris Packham , Andrew Morton , "Darrick J. Wong" , "Mark M. Hoffman" , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [hwmon PATCH v2 6/8] hwmon: (adt7470) Use cached PWM frequency value Message-ID: <06aabaed-98c3-4b06-b2d3-acbbd35e2309@roeck-us.net> References: <20260727-adt7470_fixes-v2-0-598e38a46ba6@gmail.com> <20260727-adt7470_fixes-v2-6-598e38a46ba6@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260727-adt7470_fixes-v2-6-598e38a46ba6@gmail.com> On Mon, Jul 27, 2026 at 09:22:22PM -0300, Luiz Angelo Daros de Luca wrote: > adt7470_pwm_read() currently ignores failures returned by > pwm1_freq_get(). If the register read fails, the negative error code is > returned through *val while the function itself reports success, > potentially exposing a negative PWM frequency through sysfs. > > Fix this by using the cached PWM frequency maintained by the driver, > eliminating the register access from the read path. > > Apart from the corrected error propagation and using the cached value, > no functional change is intended. > > Fixes: ef67959c4253 ("hwmon: (adt7470) Convert to use regmap") > Signed-off-by: Luiz Angelo Daros de Luca Applied. Thanks, Guenter