From: Andrew Lunn <andrew@lunn.ch>
To: Bastian Germann <bage@debian.org>
Cc: hkallweit1@gmail.com, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com, linux@armlinux.org.uk,
olteanv@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: mdio: handle broken-turn-around for non-PHY MDIO devices
Date: Sat, 21 Nov 2026 20:28:48 +0100 [thread overview]
Message-ID: <06addff8-09b0-4b76-aac7-11717fbdd9f9@lunn.ch> (raw)
In-Reply-To: <ee0baf58-5795-424b-9a41-feb9a2e766fe@debian.org>
On Sat, Nov 21, 2026 at 08:07:34PM +0100, Bastian Germann wrote:
> Hi Andrew,
>
> On 11/21/26 18:06, Andrew Lunn wrote:
> > > Parse the property in of_mdiobus_register_phy() and
> > > of_mdiobus_register_device() instead, so it is handled in one place for
> > > both PHYs and other MDIO devices, and drop it from
> > > fwnode_mdiobus_phy_device_register().
> > This seems odd. "handled in one place", yet you do it in two?
> >
> > Is there a reason not to do it in __of_mdiobus_parse_phys() ?
>
> Yes. My v2 draft was exactly that (which is the reason for the commit
> message oddity) but I noticed that children with empty reg that are handled
> in the auto-scan loop would then not get the bit mask set, which is an
> unnecessary behavior change for PHYs.
Ah, O.K. I never liked that scan code filling in missing devices. It
has a warning not to do that. So i don't know if it is actually used.
Also, i could not find any in kernel dt blobs using
broken-turn-around. So we are not going to break anything.
Andrew
---
pw-bot: cr
prev parent reply other threads:[~2026-11-21 19:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 9:29 Bastian Germann
2026-11-21 17:06 ` Andrew Lunn
2026-11-21 19:07 ` Bastian Germann
2026-11-21 19:28 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06addff8-09b0-4b76-aac7-11717fbdd9f9@lunn.ch \
--to=andrew@lunn.ch \
--cc=bage@debian.org \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®