From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 904BDC76188 for ; Wed, 17 Jul 2019 03:34:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E7502173B for ; Wed, 17 Jul 2019 03:34:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728704AbfGQDe4 (ORCPT ); Tue, 16 Jul 2019 23:34:56 -0400 Received: from mx2.suse.de ([195.135.220.15]:39728 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728035AbfGQDe4 (ORCPT ); Tue, 16 Jul 2019 23:34:56 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id D95B7AC66; Wed, 17 Jul 2019 03:34:54 +0000 (UTC) Subject: Re: [PATCH v7 4/5] x86/paravirt: Remove const mark from x86_hyper_xen_hvm variable To: Zhenzhong Duan , linux-kernel@vger.kernel.org Cc: bp@alien8.de, sstabellini@kernel.org, tglx@linutronix.de, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, mingo@redhat.com References: <1562846532-32152-1-git-send-email-zhenzhong.duan@oracle.com> <1562846532-32152-5-git-send-email-zhenzhong.duan@oracle.com> <2433589d-a2d2-6b51-cfbd-c1141014ab93@suse.com> <67261f6e-5dce-2452-a6d6-aa6ca73dfeec@oracle.com> From: Juergen Gross Message-ID: <06b1e979-3ac6-1f3c-616f-5756ac16519b@suse.com> Date: Wed, 17 Jul 2019 05:34:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <67261f6e-5dce-2452-a6d6-aa6ca73dfeec@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17.07.19 04:09, Zhenzhong Duan wrote: > > On 2019/7/16 18:57, Juergen Gross wrote: >> On 11.07.19 14:02, Zhenzhong Duan wrote: >>> .. as "nopv" support needs it to be changeable at boot up stage. >>> >>> Checkpatch report warning, so move variable declarations from >>> hypervisor.c to hypervisor.h >>> >>> Signed-off-by: Zhenzhong Duan >>> Cc: Boris Ostrovsky >>> Cc: Juergen Gross >>> Cc: Stefano Stabellini >>> Cc: Thomas Gleixner >>> Cc: Ingo Molnar >>> Cc: Borislav Petkov >>> --- >>>   arch/x86/include/asm/hypervisor.h | 8 ++++++++ >>>   arch/x86/kernel/cpu/hypervisor.c  | 8 -------- >>>   2 files changed, 8 insertions(+), 8 deletions(-) >>> >>> diff --git a/arch/x86/include/asm/hypervisor.h >>> b/arch/x86/include/asm/hypervisor.h >>> index f7b4c53..e41cbf2 100644 >>> --- a/arch/x86/include/asm/hypervisor.h >>> +++ b/arch/x86/include/asm/hypervisor.h >>> @@ -58,6 +58,14 @@ struct hypervisor_x86 { >>>       bool ignore_nopv; >>>   }; >>>   +extern const struct hypervisor_x86 x86_hyper_vmware; >>> +extern const struct hypervisor_x86 x86_hyper_ms_hyperv; >>> +extern const struct hypervisor_x86 x86_hyper_xen_pv; >>> +extern const struct hypervisor_x86 x86_hyper_kvm; >>> +extern const struct hypervisor_x86 x86_hyper_jailhouse; >>> +extern const struct hypervisor_x86 x86_hyper_acrn; >>> +extern struct hypervisor_x86 x86_hyper_xen_hvm; >> >> This should either stay const and be changed in patch 5, or you >> should adapt its definition in arch/x86/xen/enlighten_hvm.c in >> this patch. > > Ok, thanks for your suggestion. > > I'll choose 2nd opinion as I don't need to change descripton with that. Just resend the last two modified patches then, please. Juergen