From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 913FE403AE9 for ; Wed, 5 Aug 2026 09:43:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785923032; cv=none; b=iqnSJAUOy47g6AbIbC1QN3el6R5IIINTt0IPtUjZ5U8Ah8HMlpXw9ErnFFFOjunCFlurI1dOEvcIOIPy7G71WuffDtUNbUN8gQfDnfX3RCZXpOydrfeGu3dlQDR5mhP28TV/Bk07/9HXfgDjzZ6DDyAQbgBuRpQ3nUtJREcK2hU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785923032; c=relaxed/simple; bh=8s79aeYwOOL8zPp/iTPRuJMIlsaMOrpzvva2ficiOzk=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=SNKRFqwF67TStbstTNcve6LOmG0GwZIc5YsBdRAKEWZinuhgFVxetA6nKqUtaxglVDJP6x/ujXjbF8lOGKFy/tYPrjbosmzpwJHFgP5rGiDTgMIAv7OoxGFXt7/3cK5Pq6LmbTCdURbVEgtVusLva/r6Ti25IBS4X2ZJrhvVv90= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BtLt2tWn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MuhpnoAV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BtLt2tWn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MuhpnoAV" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6758ddgx2669656 for ; Wed, 5 Aug 2026 09:43:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0C8lP3h0YPqAglTQfp6gAPb3PBfqON1O+iSsRvWAj24=; b=BtLt2tWnbgdddhN5 hImAR9mFTcPpQciHDF/be2nczLJZ+QXzRECEjLPbkHV7YQ8hwCAedz1Rarbvdp84 1IeMo5iEaqn+tuGRSVrc7m5vI3Gb7eDA3IaU/J0BYYAbztoXEpPLD5H8uagbiA1t oyU1I6RPTaCjsGlhS93bbmO3KSvuksvRbuAAoLs9SvLJWcv/ve6HFkMytrAjgzeV DXvrvgCk5tg8zN6mOrU3qYv9AONNi2Bg1SBkL3KJrPHsn39EfU3tmY0jI+0bpHFy Kh5sFa/CAZoaG4SNtbp20eW6eZX2VYhv4P7K5OSlK/qi5uA4GYijrbZ8i0Mztn/F bttUlw== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fum3qbxhv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 05 Aug 2026 09:43:49 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cab048cdb3eso1152218a12.0 for ; Wed, 05 Aug 2026 02:43:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785923028; x=1786527828; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=0C8lP3h0YPqAglTQfp6gAPb3PBfqON1O+iSsRvWAj24=; b=MuhpnoAVvA2KkUriqvVwXZvjMVow0mDeO9IxgmYroormf8T4K54BmY0mHBqTTk8dY+ INwsYqdSQnArGE+5k4IPLlzF3TA+vIpR4fSPVR3ntZGwd/Bgl0sE/jFsAw5s0/u1bJKq ZcgxBVpQSgEZMmasAk5qGo9RV0sa9rCJ4oV6/YhQUahOg3b8ErN089QfhnKCdHUlITxE MaALQ8ydaNi+cYbhOtGr/GnQMvF775HIzAP4/WOcUYtvIavivNWBlgM8X3zuzW4KDGeI 18BHB2tDUPcPxXBk5cQME7Od5oqOQUhHKwb7d7bGh8hmo54D5WIVppwvKUStD1oBYHOW EnuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785923028; x=1786527828; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0C8lP3h0YPqAglTQfp6gAPb3PBfqON1O+iSsRvWAj24=; b=S0/ajs0mhlj5rRYJ0SxEb3UMyEKsTfEEUTWfKnlYQ0bIlol1Za48y99Iye7WQ+QiMj ppj9U/hRyqoEAXK80yWZjR9hb3uHCycvVFCxAcQyDMNgaYNRnwqjf9e24uBsjzZ7uung 9GLx22SWFvgXDkv5BXs37lvRPjn+u4912/vfy0fcFTTCdF1dYWZ9mC2QYY5KJ/jbsk8/ PynBGicaMkJajeDwWURbIPj6V3oKESK0M9VeQyJldX3FTHKyLGwUIT9AEvwuNMGycnvQ tRqGVSavzo5pZkYjxMW4qJyzlFgTBr9W0JpRxxy83rMP8qdB77/7edCdt23JPlALdcCW pXJg== X-Forwarded-Encrypted: i=1; AHgh+Rr33UomANa74tI0BwqZ1pPLHHkYjAxVrPMWTb/0YF1CBnXvfjaXCCXa+bl1Pozsu7B8FVWZGzI9N+le2tA=@vger.kernel.org X-Gm-Message-State: AOJu0YzQXzY9hGXKosj4FDOXBaNm77pkqk1CzAP7FTPvMMzHkMoHwUjW 14vaSkTU7fvrzejaB9o4hSYOaTEAH+Y4FGixiIpIv+2AlLDtWHkUwtyRaJkxfu70XHpR4ueXAXC sSPdbU0z+Tc54y+1di7cIneFRgm8yAaar/5V71pITNmGbIsJ1UQvwDPKpZ+qeQ5TF+pN5rgfaKh c= X-Gm-Gg: AR+sD12vZQkl/S3SjOg4LMhkd24SJrk6n+XTX0owFUfdE8GnNq3dwH7XXewzoePoRAN HmrQCJCNdot1VOMVOsw4LFvrHpmDNTOfGi+xXfleboiyCXzZbcB8FCcSf8GQWNy3czX7X4gqT43 TdkGqMRJ2Rr8g7L+bfFAxxDFsNLWhgVJ2ALBWPK9opYRcEVMAZui1kgBukZjaRqXnnVeSBKhcqS jKrkEW97UI0vUJZREgSISRfMSd1iENYFsVTDiNoNoop6wzyslPRiO2DVq44J0ZQIhc03Wmi43Rk oNIM/jzYHos8mVnBtnNgbmpLYPhCAkNo9keiux/Phpl1x0GmVIBudviw4XHwG9gBavdvl5nEAmI V8uluSdYX635WmLnZcWqA1fFUYf63fHd5aA== X-Received: by 2002:a05:6a20:e290:b0:3c4:3112:33 with SMTP id adf61e73a8af0-3cb85de7c9bmr5995365637.6.1785923028473; Wed, 05 Aug 2026 02:43:48 -0700 (PDT) X-Received: by 2002:a05:6a20:e290:b0:3c4:3112:33 with SMTP id adf61e73a8af0-3cb85de7c9bmr5995311637.6.1785923028002; Wed, 05 Aug 2026 02:43:48 -0700 (PDT) Received: from [10.217.219.96] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cbe707cab43sm1169143a12.3.2026.08.05.02.43.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 02:43:47 -0700 (PDT) Message-ID: <06b60666-4f99-4769-ad4c-0b69b58704cd@oss.qualcomm.com> Date: Wed, 5 Aug 2026 15:13:43 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] i2c: qcom-geni: Use modern PM operation macros To: Mukesh Kumar Savaliya , andi.shyti@kernel.org, linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260729073040.3227692-1-mukesh.savaliya@oss.qualcomm.com> Content-Language: en-US From: Viken Dadhaniya In-Reply-To: <20260729073040.3227692-1-mukesh.savaliya@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA1MDA3NiBTYWx0ZWRfX7UUYBVExmO9k 8KSOpW93WBmVuuIgEVDsogZT1lY+ERHd4Yr+o0PECdlVWaAWFm0P+LUqcsbayftXk86aVcAiC2S +zWuFeThv38Hs9dlSYO8c3R2/S63LVUeGQYh5LlBsJfRpaU76l/l9G1CzsThhh/6qlLUSG3cLDS fs97n7D3o5ZEIWvtpc4y8gFZxpSYbj0+doo4Q/A0mziIgMTIKcygErp5fQrCRlu21qfRfSSqGKN kpVRjbRNPBaZRBV7jDq/ppTD2qfnwpcGn8CcYUf2Nk6I8U80ULudCmBb2nilKf4ubyLPxI65jbp W7QlrPYB82X8D57KIQg8/vBlGTUyrwQwJjKatgi4l3HyBi9fXx+Ksl+vTQWqGHTN2j4Kdx/AakS loaLrLrbTgjK9Z+xzLnJOyX1I9K56sF2uzeXUwh+QnqHU7YS1XnusGTMlBCN7bFAujnq7Y0NzTh 9+GjD1s1xJQtGoaHhhA== X-Proofpoint-GUID: 1yP0cOUUaPlht4buvThpU9uxYAgMJsxh X-Authority-Analysis: v=2.4 cv=LsiiDHdc c=1 sm=1 tr=0 ts=6a7305d5 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=m9ln40nSR70YO6FPyLoA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-ORIG-GUID: 1yP0cOUUaPlht4buvThpU9uxYAgMJsxh X-Proofpoint-Spam-Info: AW1haW4tMjYwODA1MDA3NiBTYWx0ZWRfX6Ul6pFFnNTRl qE0tTX3Z8lvoTX2XpMH98+KS4EeRimHd3nF+HXOfuoyDVKv69rTcZtrUOj/ewyruUkbCZm5TGrt RRyEhP9mV12Aq1say4EMDUpIlfU6XFo= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-05_03,2026-08-04_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 suspectscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608050076 Reviewed-by: Viken Dadhaniya On 7/29/2026 1:00 PM, Mukesh Kumar Savaliya wrote: > The driver uses the legacy SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() and > SET_RUNTIME_PM_OPS() helpers to initialize struct dev_pm_ops. > > Switch to the modern NOIRQ_SYSTEM_SLEEP_PM_OPS() and RUNTIME_PM_OPS() > macros instead. These macros keep PM callbacks referenced by the > compiler and help avoid potential unused-function warnings in > configurations where PM support is disabled or partially enabled. > > No functional change intended. > > Signed-off-by: Mukesh Kumar Savaliya > --- > drivers/i2c/busses/i2c-qcom-geni.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > index d5c977e34994..71ae821dd147 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -1163,7 +1163,7 @@ static void geni_i2c_shutdown(struct platform_device *pdev) > i2c_mark_adapter_suspended(&gi2c->adap); > } > > -static int __maybe_unused geni_i2c_runtime_suspend(struct device *dev) > +static int geni_i2c_runtime_suspend(struct device *dev) > { > int ret = 0; > struct geni_i2c_dev *gi2c = dev_get_drvdata(dev); > @@ -1181,7 +1181,7 @@ static int __maybe_unused geni_i2c_runtime_suspend(struct device *dev) > return 0; > } > > -static int __maybe_unused geni_i2c_runtime_resume(struct device *dev) > +static int geni_i2c_runtime_resume(struct device *dev) > { > int ret = 0; > struct geni_i2c_dev *gi2c = dev_get_drvdata(dev); > @@ -1197,7 +1197,7 @@ static int __maybe_unused geni_i2c_runtime_resume(struct device *dev) > return 0; > } > > -static int __maybe_unused geni_i2c_suspend_noirq(struct device *dev) > +static int geni_i2c_suspend_noirq(struct device *dev) > { > struct geni_i2c_dev *gi2c = dev_get_drvdata(dev); > int ret; > @@ -1211,7 +1211,7 @@ static int __maybe_unused geni_i2c_suspend_noirq(struct device *dev) > return ret; > } > > -static int __maybe_unused geni_i2c_resume_noirq(struct device *dev) > +static int geni_i2c_resume_noirq(struct device *dev) > { > struct geni_i2c_dev *gi2c = dev_get_drvdata(dev); > int ret; > @@ -1225,9 +1225,10 @@ static int __maybe_unused geni_i2c_resume_noirq(struct device *dev) > } > > static const struct dev_pm_ops geni_i2c_pm_ops = { > - SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(geni_i2c_suspend_noirq, geni_i2c_resume_noirq) > - SET_RUNTIME_PM_OPS(geni_i2c_runtime_suspend, geni_i2c_runtime_resume, > - NULL) > + NOIRQ_SYSTEM_SLEEP_PM_OPS(geni_i2c_suspend_noirq, > + geni_i2c_resume_noirq) > + RUNTIME_PM_OPS(geni_i2c_runtime_suspend, geni_i2c_runtime_resume, > + NULL) > }; > > static const struct geni_i2c_desc geni_i2c = {