From: Randy Dunlap <rdunlap@infradead.org>
To: Sebastian Fricke <sebastian.fricke@collabora.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
bagasdotme@gmail.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
laurent.pinchart@ideasonboard.com, hverkuil-cisco@xs4all.nl,
mchehab@kernel.org, kernel@collabora.com,
bob.beckett@collabora.com, nicolas.dufresne@collabora.com
Subject: Re: [PATCH v2 1/2] docs: Add debugging section to process
Date: Thu, 14 Nov 2024 22:28:51 -0800 [thread overview]
Message-ID: <06bb8d73-ba52-440a-be95-42977145c026@infradead.org> (raw)
In-Reply-To: <20241115060542.lqpu3sdqnsxass6q@basti-XPS-13-9310>
On 11/14/24 10:05 PM, Sebastian Fricke wrote:
> Hey Randy,
>
> Thank you for the review, I'll apply these changes, I just found one
> advice below not terribly helpful maybe you can clarify ...
>
> On 14.11.2024 21:06, Randy Dunlap wrote:
>>
>>
>> On 11/13/24 3:17 AM, Sebastian Fricke wrote:
>>> This idea was formed after noticing that new developers experience
>>> certain difficulty to navigate within the multitude of different
>>> debugging options in the Kernel and while there often is good
>>> documentation for the tools, the developer has to know first that they
>>> exist and where to find them.
>>> Add a general debugging section to the Kernel documentation, as an
>>> easily locatable entry point to other documentation and as a general
>>> guideline for the topic.
>>>
>>> Signed-off-by: Sebastian Fricke <sebastian.fricke@collabora.com>
>>> ---
>>> .../driver_development_debugging_guide.rst | 214 ++++++++++++++++
>>> Documentation/process/debugging/index.rst | 65 +++++
>>> .../debugging/userspace_debugging_guide.rst | 278 +++++++++++++++++++++
>>> Documentation/process/index.rst | 8 +-
>>> 4 files changed, 562 insertions(+), 3 deletions(-)
>>>
>>
>>
>>> diff --git a/Documentation/process/debugging/userspace_debugging_guide.rst b/Documentation/process/debugging/userspace_debugging_guide.rst
>>> new file mode 100644
>>> index 000000000000..a7c94407bcae
>>> --- /dev/null
>>> +++ b/Documentation/process/debugging/userspace_debugging_guide.rst
>>> @@ -0,0 +1,278 @@
>>> +.. SPDX-License-Identifier: GPL-2.0
>>> +
>>> +==========================
>>> +Userspace debugging advice
>>> +==========================
>>> +
>>> +A brief overview of common tools to debug the Linux Kernel from userspace.
>>
>> Make that a sentence?
>
> Can you clarify this?
>
> This could either mean:
> - What you even bother to make a sentence out of that?
> - Please make a proper sentence out of this because it is hard to
> understand
> - Please go into more detail because this is too brief
>
> Or maybe something completely different :)
Sorry for my brevity.
I just meant "do you want to make that line a sentence, because it is not a sentence
in its current form." But I'm not going to lose any sleep over it.
Thanks.
--
~Randy
next prev parent reply other threads:[~2024-11-15 6:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 11:17 [PATCH v2 0/2] Documentation: Debugging guide Sebastian Fricke
2024-11-13 11:17 ` [PATCH v2 1/2] docs: Add debugging section to process Sebastian Fricke
2024-11-15 4:52 ` Randy Dunlap
2024-11-15 5:06 ` Randy Dunlap
2024-11-15 6:05 ` Sebastian Fricke
2024-11-15 6:28 ` Randy Dunlap [this message]
2024-11-13 11:17 ` [PATCH v2 2/2] docs: Add debugging guide for the media subsystem Sebastian Fricke
[not found] <20241028-media_docs_improve_v3-v2-0-f350f98e1870@collabora.com>
[not found] ` <20241028-media_docs_improve_v3-v2-1-f350f98e1870@collabora.com>
2024-11-13 11:25 ` [PATCH v2 1/2] docs: Add debugging section to process Sebastian Fricke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06bb8d73-ba52-440a-be95-42977145c026@infradead.org \
--to=rdunlap@infradead.org \
--cc=bagasdotme@gmail.com \
--cc=bob.beckett@collabora.com \
--cc=corbet@lwn.net \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=sebastian.fricke@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®