From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758438AbdHYTlL (ORCPT ); Fri, 25 Aug 2017 15:41:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:33517 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758419AbdHYTlJ (ORCPT ); Fri, 25 Aug 2017 15:41:09 -0400 Subject: Re: [RFC 1/3] dt-bindings: interrupt-controller: Add Realtek RTD1295 To: Rob Herring Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Roc He , =?UTF-8?B?6JKL5Li955C0?= , Mark Rutland , devicetree@vger.kernel.org References: <20170817101140.32000-1-afaerber@suse.de> <20170817101140.32000-2-afaerber@suse.de> <20170822021459.l3oiid3f4fs6vfa2@rob-hp-laptop> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: <06bc5f05-cbfb-edc3-7881-dafeba6fa8ea@suse.de> Date: Fri, 25 Aug 2017 21:41:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170822021459.l3oiid3f4fs6vfa2@rob-hp-laptop> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 22.08.2017 um 04:14 schrieb Rob Herring: > On Thu, Aug 17, 2017 at 12:11:38PM +0200, Andreas Färber wrote: >> Add binding for Realtek RTD1295 IRQ mux. >> >> Signed-off-by: Andreas Färber >> --- >> .../interrupt-controller/realtek,rtd119x-mux.txt | 28 ++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/realtek,rtd119x-mux.txt >> >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/realtek,rtd119x-mux.txt b/Documentation/devicetree/bindings/interrupt-controller/realtek,rtd119x-mux.txt >> new file mode 100644 >> index 000000000000..4b43370e3d74 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/interrupt-controller/realtek,rtd119x-mux.txt >> @@ -0,0 +1,28 @@ >> +Realtek RTD119x/129x IRQ Mux Controller >> +======================================= >> + >> +Required properties: >> + >> +- compatible : Should be one of the following: >> + - "realtek,rtd1295-irq-mux" >> + - "realtek,rtd1295-iso-irq-mux" >> +- reg : Specifies base physical address and size of the registers. >> +- interrupts : Specifies the interrupt line which is mux'ed. >> +- interrupt-controller : Presence indicates the node as interrupt controller. >> +- #interrupt-cells : Shall be 1. See common bindings in interrupt.txt. >> + >> + >> +Optional properties: >> + >> +See interrupt.txt for common bindings. > > What else would apply here? interrupt-parent is the only thing I see, > but that's really implicit anyway. interrupt-names would be another optional property not needed today. interrupt-controller and #interrupt-cells are common properties, too. I'll drop both lines if you prefer. Otherwise okay? Regards, Andreas >> + >> + >> +Example: >> + >> + interrupt-controller@98007000 { >> + compatible = "realtek,rtd1295-iso-irq-mux"; >> + reg = <0x98007000 0x100>; >> + interrupts = ; >> + interrupt-controller; >> + #interrupt-cells = <1>; >> + }; >> -- >> 2.12.3 -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)