From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Daniel Graefe <daniel.graefe@fau.de>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
devel@driverdev.osuosl.org, linux-kernel@i4.cs.fau.de,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Roman Sommer <roman.sommer@fau.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2] staging: media: omap4iss: Added SPDX license identifiers
Date: Wed, 27 Jun 2018 06:36:58 -0700 [thread overview]
Message-ID: <06bca9497a878d5f494fd97dbe2d8448caab9afd.camel@perches.com> (raw)
In-Reply-To: <20180627084013.ybnbxbgha77cdujn@mwanda>
On Wed, 2018-06-27 at 11:40 +0300, Dan Carpenter wrote:
> On Tue, Jun 26, 2018 at 11:30:56PM +0200, Daniel Graefe wrote:
> > Changes in v2:
> > - replaced "GPL-2.0-or-later" with "GPL-2.0+"
>
> We should make checkpatch.pl complain when people use wrong tags like
> GPL-2.0-or-later.
I'd rather we use the latest version of the spdx forms.
https://lkml.org/lkml/2018/2/2/883
I think it's better to modify checkpatch when the kernel
uses the latest forms.
There is a separate script that validates the spdx forms.
./scripts/spdxcheck.py
That script, which still needs the patch below, would work
with either style.
https://patchwork.kernel.org/patch/10448573/
$ python ./scripts/spdxcheck.py
include/dt-bindings/reset/amlogic,meson-axg-reset.h: 9:41 Invalid License ID: BSD
or for more verbose output
$ python ./scripts/spdxcheck.py -v
include/dt-bindings/reset/amlogic,meson-axg-reset.h: 9:41 Invalid License ID: BSD
License files: 14
Exception files: 1
License IDs 19
Exception IDs 1
Files checked: 60967
Lines checked: 646729
Files with SPDX: 17393
Files with errors: 1
prev parent reply other threads:[~2018-06-27 13:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 13:21 [PATCH] " Daniel Graefe
2018-06-25 13:43 ` Laurent Pinchart
2018-06-26 21:30 ` [PATCH v2] " Daniel Graefe
2018-06-27 8:40 ` Dan Carpenter
2018-06-27 13:36 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06bca9497a878d5f494fd97dbe2d8448caab9afd.camel@perches.com \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel.graefe@fau.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=roman.sommer@fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®