mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Mark Pearson <mpearson@squebb.ca>,
	David Ober <dober6023@gmail.com>,
	wim@linux-watchdog.org
Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
	David Ober <dober@lenovo.com>
Subject: Re: [PATCH v3] Watchdog: New module for ITE 5632 watchdog
Date: Thu, 29 Feb 2024 10:47:38 -0800	[thread overview]
Message-ID: <06bf41c9-34b8-4361-a6d9-72afeddae1b4@roeck-us.net> (raw)
In-Reply-To: <6c97c63b-af35-4919-b5a2-a867776be8e9@app.fastmail.com>

On 2/29/24 10:12, Mark Pearson wrote:
[ ... ]

>> Is it necessary to treat this differently than, say,
>> drivers/hwmon/it87.c and drivers/watchdog/it87_wdt.c ?
>> Those work together nicely because most of the address space is
>> separate; access through Super-IO registers
>> is limited enough that it can be shared by using request_muxed_region()
>> in both drivers.
>>
>> I'll have to look deeper into NCT6692D (and NCT6686, for that matter),
>> to see if those require mfd drivers.
>> I'll also need to get the datasheets for those chips and confirm that
>> they really need different watchdog
>> drivers to start with.
>>
> Ack - I'll look at those and see. Quick look at the watchdog driver and it looks possible but I need to check the details more carefully.
> Afraid I can't share the datasheet as I don't have permission to release it. How much of a blocker is that for you?
> 

I do have the datasheet for the NCT6683 EC space. I'll need to check if
it matches the code submitted for the NCT6686 watchdog.

For NCT6692D, I asked Nuvoton if they can share the datasheet.
Given that it is some kind of security controller chip, it may well be
that Lenovo has an NDA with Nuvoton which prevents them from sharing
the datasheet. We'll see.

Undocumented ITE chips are simply not supportable. No matter what, someone
will have to step up as maintainer for those chips.

Guenter


  reply	other threads:[~2024-02-29 18:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21 12:29 David Ober
2024-02-23 19:58 ` Mark Pearson
2024-02-23 20:21   ` Guenter Roeck
2024-02-24  0:43     ` Mark Pearson
2024-02-24 15:49       ` Guenter Roeck
2024-02-24 20:19         ` Mark Pearson
2024-02-25  6:43           ` Guenter Roeck
2024-02-26 16:23             ` Mark Pearson
2024-02-29 16:40               ` Mark Pearson
2024-02-29 17:25                 ` Guenter Roeck
2024-02-29 18:12                   ` Mark Pearson
2024-02-29 18:47                     ` Guenter Roeck [this message]
2024-02-29 19:15                       ` Mark Pearson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06bf41c9-34b8-4361-a6d9-72afeddae1b4@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=dober6023@gmail.com \
    --cc=dober@lenovo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=mpearson@squebb.ca \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®