From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 791BF3F9F3D for ; Wed, 5 Aug 2026 10:47:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785926858; cv=none; b=u5X7f/3BhEKDIQNtljIJX9sT/+hcp3PoyCzx5iOXtaiETRr0qks+HxZgsmPu37N5EukOe9SeZjmkisdwaXqcMH69lhOWCDKI/dyEVfbjlPY3Gj6ZHWAuRmkNxjFExlfWCdLAm5fVfDGQ1tR7KuYdZFrIoqHu0k/ravnJnutfhF8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785926858; c=relaxed/simple; bh=/PWgap84eb3PT1vleRSyOWs+iiOmgUCOw0Xq2cxMshQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uF+1ZvmNHgs8xLiKDfI8gNvjLZ3mB4xrh02ZmFWTiNkoV4hZeoIVuOoGKva0LUQy7xZwBbitVSY7a1fU4DQ6yNSwuSjyFOu6BWICCOA/B54xxpkg3XmP1EXWei67WRFYpC7wR1OKvB72dmuLL8OS9lUxfezILVkHkKf7qBGR+8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UmftY71P; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QyL1iTdB; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UmftY71P"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QyL1iTdB" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6758dHsk2468157 for ; Wed, 5 Aug 2026 10:47:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ss/eK8cGELilAVeOlfILSBb56cf4qKwKczaCfskWD/I=; b=UmftY71PWWRdkCSl QPyRRH/qp7st/mTNnUr8FAnvF3jXeE1cbfAEyoeOwmecjSMEmNWB7TK5WgAsxk0+ 096stGNpyiNK3eOUjpudoCBrEuxdBiNmz0zUICEhAUBtPjjWSuLjXhgddh2NyUvs rhQ2u86OQHBuic9PqdmWJ5QcH/afH4/fipUTui0+g0KvGWzM4dpvwtePQTc4msQ8 xYNYXkpfyMo8B6K5VMwZhP1X9czdI64dcY+AdNkG7q6/zWZYX7I8UEkpUZ7UhSyV KBH/nyUHEccPOVu/Ku3hU+T4jJVcIUFddxqeE0s/Y1/r3kLu9BCoFFFvttcgBQuq tL4JHQ== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fum56m6au-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 05 Aug 2026 10:47:36 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-ca6bd8a190cso1117499a12.0 for ; Wed, 05 Aug 2026 03:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785926856; x=1786531656; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ss/eK8cGELilAVeOlfILSBb56cf4qKwKczaCfskWD/I=; b=QyL1iTdB03C/3h5X/Og84we0DVfqVtmeHajEnzLNy2DfBUtg6D/t3AJYTYPCHg7ZKc usEhxnNl54A0MhdNRkJC5UsiPM2ABoF4XPQgNeOm+9cmP3HzLIScl9xLqzMiOFS3zUXB kLlW1fwZSHjK45Jr5B7y5oiyxJIJWcn2BByn8B136hnnI7ln0zoYoHqCZXooFeGOEB3f 09mt9LrZo28wwOgum25inoIpp199MMZTS/W57LFBtJ57J7hRmvai3ljFzFnbTkL1Lrnv HmbMY2pIzC+TdIU3e5CHsYIxLb4dhMtjiwSL+PItKy7z/0haL196dnEHuDIWOr+g3efy 5t3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785926856; x=1786531656; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ss/eK8cGELilAVeOlfILSBb56cf4qKwKczaCfskWD/I=; b=G4/QoZpcsCy2P9P5UqdztUyeU9srYAFJrjiupCu1uNMtMlrNAh5QlZx0W2Qpkyviif ZEFqqraheOaZNK++zxzEFZGs8dFBXNmr+/3uTPsH/BR9tEOWQpnq6TK18GFwgAym9rEc xopS8n6WE1lPD9w1tQyCBrCBveo+KtZoe824I4HpxvDwj/TTBqmjKGJ+vjtWthLlAHeK GEU9cEobRCdTx3CxHoSmAHeR7IhxPa5l8JoXeLq86EQs4/snMuK3dBR3vytcnZzkRs/3 gow+SBYPUWnkqqSuFkznz86lumQoTPUuiaXjmTaMqvsO4DJJ0WxYf7lFqg+FVvQD4N1N tCiA== X-Forwarded-Encrypted: i=1; AHgh+Rpd0vUklfbs0D0wlNX7+vRh8Hu+3BKvWi27w33BXGpCvZ/0P3s6fQm5quwMH+5v3BzJAdhMUhENV/lQ/9c=@vger.kernel.org X-Gm-Message-State: AOJu0YwdZRvvD3JwDPmFdJNr8khUiv7fwdC8+ksTc3T2Fpw87SD0ztqU Rp8df3ptsKS8Yn86Gte2C6Ld0aIZdUBpZBm0czqbizTz/RGL0T1gofFAG9BUUWAtinumXpp4bXy zep3Emonj9sDxiLb7RHwuGi8297o67EK+dm6CZmU8cOtrYW6mTW/wnCWrTrZTLRP76Fc= X-Gm-Gg: AR+sD1372qTPsTfb6E7AU/iuDZpKJXANE1q45mABo+FRnaMXGbKNMAYL6/UNsZs9SVO pzAddHI0WWCJmCgEsIYour6PyygU5rlscRFUk0eaTPoCZX+cjZpjJ0/EVwtEucWxHkAn07JiONi BC3mF4LHVJOH6UxNWbwpGhcXcyDXm010wXA814OKydRTxzR8zIk/xuoKDZmkRNFsROgrlEx1Dbd V/W5ozmGCim3l1ul4aJq7mw7mPMI73o+vR5bBGSrvxg4NoIZzWwUJQvo7qxKTpF9r8xnL9/AnPK +vywVW5ibtYNCZHrWfcDpq1GEr9WO8RKFzR0+FH6LGu1ASOz5p0Jo7Xsi26U0shZ8+p6l8sNH2M 32dCAolwqTkm3Pq1TnPsUaVSIqg7jQ18q X-Received: by 2002:a05:6a21:4685:b0:3c0:b766:74f4 with SMTP id adf61e73a8af0-3cb85f4a279mr6962687637.31.1785926855967; Wed, 05 Aug 2026 03:47:35 -0700 (PDT) X-Received: by 2002:a05:6a21:4685:b0:3c0:b766:74f4 with SMTP id adf61e73a8af0-3cb85f4a279mr6961166637.31.1785926842212; Wed, 05 Aug 2026 03:47:22 -0700 (PDT) Received: from [10.217.217.28] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cbe707c9970sm1315488a12.6.2026.08.05.03.47.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 03:47:21 -0700 (PDT) Message-ID: <06c37244-d589-4867-a189-efdb300bbce1@oss.qualcomm.com> Date: Wed, 5 Aug 2026 16:17:14 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/3] thermal: qcom: add support for PMIC5 Gen3 ADC thermal monitoring To: Daniel Lezcano , Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Andy Shevchenko Cc: linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Kamal Wadhwa , David Collins , Anjelique Melendez , Neil Armstrong , Stephan Gerhold , Andy Shevchenko References: <20260722-gen3_adc_tm-v4-0-011981f756c8@oss.qualcomm.com> <20260722-gen3_adc_tm-v4-3-011981f756c8@oss.qualcomm.com> Content-Language: en-US From: Jishnu Prakash In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: Rjj37tIV8l4cvav2arbDq5KYca_vLJlb X-Authority-Analysis: v=2.4 cv=Co+PtH4D c=1 sm=1 tr=0 ts=6a7314c8 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=y6G8bwdjvvgfd2dEMfwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODA1MDA4NiBTYWx0ZWRfX9az4yP3LNXyF 1suShrpP0kXyKcONPJYZYcNaAJD1/SjaZH2eEnAnTqa+CcjMR8ARNJc2G2A5AmCWKMj9PCKoAQp 3sB+hSmNaQA2tIiHKlrVy+GJF0mfjLk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA1MDA4NiBTYWx0ZWRfX/FhKWFwxZlbe HYdwVhy+/PClGX/ax96p74VrQySbUvptEVoxADYmIdS7wx3mHrycerA4Q3NKIwpQf1tezFNtQkA 60aKQ5wCWTPpWX6Wq90Bv0nVdVnrQtulp/C1j4e6X0oF2qOlJWrtnYz6MAULFJc78NGYz1jvMaw l5xX0D0QAvgPL/glcIpkvsqq8Qf4Z4/CyRr5w+MFw4O4TvlzTc8pyg5By7PRCTe4IMGWaOgmB98 qxbo3UbukeIh7nEyPdLzDcFJbdwg0mqzBr96UTKD2YVQE5nwaTouVu0PBt+awJru+ZaPwu1g47d 9afnog8jiv+RVrFIrjfefkycBVmjEt/P3kTGhw9bhZnImatSjrrSpD5pr7Q/NxWrnTJ2yf70ygO XQbGaOubcfVnxgYZiyqnjBp7phLFo5Yo1zC4Hsfiv6ZdTdPVrV8dYm5DyuLjnCodYCB5G5T1KwV eU87TMUFgargX/YZv8w== X-Proofpoint-GUID: Rjj37tIV8l4cvav2arbDq5KYca_vLJlb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-05_03,2026-08-04_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 spamscore=0 phishscore=0 bulkscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608050086 On 7/27/2026 9:13 PM, Daniel Lezcano wrote: > > Hi, > > Andy ? Are fine with these changes ? > Hi Andy, I have addressed all your V3 comments in this V4 patch. Can you please check and confirm if it looks fine to you ? Thanks, Jishnu > > > On 7/22/26 13:26, Jishnu Prakash wrote: >> Add support for ADC_TM part of PMIC5 Gen3 in an auxiliary driver >> under the Gen3 ADC driver. Its functionality is similar to that of >> PMIC5 Gen2 ADC_TM, which implements the threshold setting and >> interrupt generating functions, used to support thermal trip points. >> >> In Gen3 ADC, the register interface is implemented on one or more SDAM >> (Shared Direct Access Memory) peripherals instead of dedicated ADC >> peripherals. Each ADC SDAM has eight channels which can be configured >> for either immediate reads (main ADC driver's functionality) or ADC_TM >> reads. By convention, the first channel of the first ADC SDAM is reserved >> for all immediate reads and remaining channels across all SDAMs are used >> for ADC_TM functionality. >> >> On the first SDAM, the interrupt line and configuration registers are >> shared between the main ADC and auxiliary ADC_TM drivers. Access to the >> registers is protected through a mutex shared between the drivers. The >> ADC_TM driver accesses this mutex and some other functions shared from >> the main driver (like adc5_gen3_get_scaled_reading() for immediate channel >> reads in the .get_temp() callback) through APIs exported into a shared >> namespace. >> >> Signed-off-by: Jishnu Prakash >> --- >>   drivers/thermal/qcom/Kconfig                  |   9 + >>   drivers/thermal/qcom/Makefile                 |   1 + >>   drivers/thermal/qcom/qcom-spmi-adc-tm5-gen3.c | 434 ++++++++++++++++++++++++++ >>   3 files changed, 444 insertions(+) >>