mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Michal Wilczynski <m.wilczynski@samsung.com>,
	mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, drew@pdp7.com,
	guoren@kernel.org, wefu@redhat.com, jassisinghbrar@gmail.com,
	paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, frank.binns@imgtec.com,
	matt.coster@imgtec.com, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
	simona@ffwll.ch, ulf.hansson@linaro.org, jszhang@kernel.org,
	p.zabel@pengutronix.de, m.szyprowski@samsung.com
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	dri-devel@lists.freedesktop.org, linux-pm@vger.kernel.org
Subject: Re: [RFC PATCH v2 11/19] dt-bindings: gpu: Add 'resets' property for GPU initialization
Date: Mon, 23 Dec 2024 17:29:06 +0100	[thread overview]
Message-ID: <06c381c3-f181-4422-8aec-d4efcc6d3f07@kernel.org> (raw)
In-Reply-To: <20241223125553.3527812-12-m.wilczynski@samsung.com>

On 23/12/2024 13:55, Michal Wilczynski wrote:
> diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> index 256e252f8087..4078cc816ea1 100644
> --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> @@ -37,6 +37,12 @@ properties:
>    power-domains:
>      maxItems: 1
>  
> +  resets:
> +    maxItems: 1
> +
> +  reset-names:
> +    const: gpu
Name being equal to the name of the block is not useful. Drop
reset-names. Reset framework allows to get the reset instance without name.

Best regards,
Krzysztof

  reply	other threads:[~2024-12-23 16:29 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20241223125600eucas1p22d9257e92c798e9f4346a76d1d0fc73d@eucas1p2.samsung.com>
2024-12-23 12:55 ` [RFC PATCH v2 00/19] Enable drm/imagination BXM-4-64 Support for LicheePi 4A Michal Wilczynski
     [not found]   ` <CGME20241223125601eucas1p1d274193122638075dc65310a22616bae@eucas1p1.samsung.com>
2024-12-23 12:55     ` [RFC PATCH v2 01/19] dt-bindings: clock: Add VO subsystem clocks and update address requirements Michal Wilczynski
2024-12-23 16:05       ` Krzysztof Kozlowski
2024-12-23 20:50       ` Stephen Boyd
2024-12-24  8:53         ` Krzysztof Kozlowski
2024-12-24  9:23           ` Michal Wilczynski
2024-12-24 13:33             ` Krzysztof Kozlowski
     [not found]   ` <CGME20241223125603eucas1p26a140c47956d7901c08cb06e7be744c7@eucas1p2.samsung.com>
2024-12-23 12:55     ` [RFC PATCH v2 02/19] clk: thead: Add clock support for VO subsystem in T-Head TH1520 SoC Michal Wilczynski
     [not found]   ` <CGME20241223125604eucas1p26b870756eeaf2a5666b70de3f7554c13@eucas1p2.samsung.com>
2024-12-23 12:55     ` [RFC PATCH v2 03/19] dt-bindings: power: thead,th1520: Add support for power domains Michal Wilczynski
2024-12-23 15:16       ` Rob Herring (Arm)
2024-12-23 16:02         ` Michal Wilczynski
2024-12-23 16:06           ` Krzysztof Kozlowski
2024-12-23 16:09       ` Krzysztof Kozlowski
2024-12-24  9:31         ` Michal Wilczynski
2024-12-24 13:32           ` Krzysztof Kozlowski
     [not found]   ` <CGME20241223125606eucas1p10ca3adc99322ff33d617a227733e5e67@eucas1p1.samsung.com>
2024-12-23 12:55     ` [RFC PATCH v2 04/19] dt-bindings: firmware: thead,th1520: Add support for firmware node Michal Wilczynski
2024-12-23 16:11       ` Krzysztof Kozlowski
     [not found]   ` <CGME20241223125607eucas1p1eac1c05d699337f9af118c1885b14b1d@eucas1p1.samsung.com>
2024-12-23 12:55     ` [RFC PATCH v2 05/19] firmware: thead: Add AON firmware protocol driver Michal Wilczynski
2024-12-23 16:17       ` Krzysztof Kozlowski
     [not found]   ` <CGME20241223125608eucas1p25f0be9eb6fb7ab906f942201560dd881@eucas1p2.samsung.com>
2024-12-23 12:55     ` [RFC PATCH v2 06/19] soc: thead: power-domain: Add power-domain driver for TH1520 Michal Wilczynski
2024-12-23 16:20       ` Krzysztof Kozlowski
2024-12-23 16:26       ` Krzysztof Kozlowski
     [not found]   ` <CGME20241223125610eucas1p2721f8a199bc6ff16345b3b46fc44dd63@eucas1p2.samsung.com>
2024-12-23 12:55     ` [RFC PATCH v2 07/19] riscv: Enable PM_GENERIC_DOMAINS for T-Head SoCs Michal Wilczynski
     [not found]   ` <CGME20241223125611eucas1p1acf9a7f030c4c8687f946c34f8043bcd@eucas1p1.samsung.com>
2024-12-23 12:55     ` [RFC PATCH v2 08/19] dt-bindings: reset: Add T-HEAD TH1520 SoC Reset Controller Michal Wilczynski
2024-12-23 16:22       ` Krzysztof Kozlowski
     [not found]   ` <CGME20241223125612eucas1p1d27f793116fa405911f07cfc926c0129@eucas1p1.samsung.com>
2024-12-23 12:55     ` [RFC PATCH v2 09/19] reset: thead: Add TH1520 reset controller driver Michal Wilczynski
2024-12-23 16:25       ` Krzysztof Kozlowski
     [not found]   ` <CGME20241223125614eucas1p181b9db4e69de9915f0234fb1d1348465@eucas1p1.samsung.com>
2024-12-23 12:55     ` [RFC PATCH v2 10/19] drm/imagination: Add reset controller support for GPU initialization Michal Wilczynski
     [not found]   ` <CGME20241223125615eucas1p10cd69b9a6f03f33ce9b9346558de6ce6@eucas1p1.samsung.com>
2024-12-23 12:55     ` [RFC PATCH v2 11/19] dt-bindings: gpu: Add 'resets' property " Michal Wilczynski
2024-12-23 16:29       ` Krzysztof Kozlowski [this message]
     [not found]   ` <CGME20241223125617eucas1p25256081c64ae4e64a12c6ec427f75e8e@eucas1p2.samsung.com>
2024-12-23 12:55     ` [RFC PATCH v2 12/19] dt-bindings: gpu: Add compatibles for T-HEAD TH1520 GPU Michal Wilczynski
2024-12-23 16:31       ` Krzysztof Kozlowski
     [not found]   ` <CGME20241223125618eucas1p2ad4887b41bb99a9ebbd0b8c2e2aa4af4@eucas1p2.samsung.com>
2024-12-23 12:55     ` [RFC PATCH v2 13/19] drm/imagination: Add support for IMG BXM-4-64 GPU Michal Wilczynski
     [not found]   ` <CGME20241223125619eucas1p1f9c4afd9b4f458ab92750e0526c95581@eucas1p1.samsung.com>
2024-12-23 12:55     ` [RFC PATCH v2 14/19] drm/imagination: Enable PowerVR driver for RISC-V Michal Wilczynski
     [not found]   ` <CGME20241223125621eucas1p17ecf251c74bc60e69323afe1ffc0c8fb@eucas1p1.samsung.com>
2024-12-23 12:55     ` [RFC PATCH v2 15/19] riscv: dts: thead: Extend device tree clk with VO reg Michal Wilczynski
     [not found]   ` <CGME20241223125622eucas1p18f67a49dd69b93f0e7770e12b95ceb77@eucas1p1.samsung.com>
2024-12-23 12:55     ` [RFC PATCH v2 16/19] riscv: dts: thead: Add mailbox node Michal Wilczynski
     [not found]   ` <CGME20241223125624eucas1p217e1756d45cfb39429c7a4543a84d7f2@eucas1p2.samsung.com>
2024-12-23 12:55     ` [RFC PATCH v2 17/19] riscv: dts: thead: Introduce power domain nodes with aon firmware Michal Wilczynski
     [not found]   ` <CGME20241223125625eucas1p2ffc3f2d8fd13bd71550ebed4e901b7de@eucas1p2.samsung.com>
2024-12-23 12:55     ` [RFC PATCH v2 18/19] riscv: dts: thead: Introduce reset controller node Michal Wilczynski
     [not found]   ` <CGME20241223125626eucas1p137d01dbee3cb24c38c0d4aa46404c7d5@eucas1p1.samsung.com>
2024-12-23 12:55     ` [RFC PATCH v2 19/19] riscv: dts: thead: Add GPU node to TH1520 device tree Michal Wilczynski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06c381c3-f181-4422-8aec-d4efcc6d3f07@kernel.org \
    --to=krzk@kernel.org \
    --cc=airlied@gmail.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=drew@pdp7.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=frank.binns@imgtec.com \
    --cc=guoren@kernel.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=jszhang@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=m.szyprowski@samsung.com \
    --cc=m.wilczynski@samsung.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matt.coster@imgtec.com \
    --cc=mripard@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=ulf.hansson@linaro.org \
    --cc=wefu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®