From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F7923A453C for ; Wed, 25 Mar 2026 16:26:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774455978; cv=none; b=K6Mw1r0faH+g2TFqUlTY1VXiktekG65mXq+dO2zBk7qoYzUMHkkqDDEVoGkjc6bldzIuP/nzHk+cOjVYYNzYfJnBCaNKDhOESJl45gfSOA/p9sp74m0h57QIPxd35P04huRG2J6FBRxCXxOQYYWrNcKvbQ53WhNaJTgyqCiASVc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774455978; c=relaxed/simple; bh=A53eXc1wKqhkXLFR8RFAyruE51u9fpUJf8NFVVelxRQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Pu+D81nOurnmcB+M+RU3a10K87wz1WIQ5YA2laDa/y7lad4oAjAKYxR1Tcp4ZmeXpZajUR1DasWb7YfjwIpJg2BTdJCj1VbcvYZ5H0Rg4Rj96g2xoE0k9tpUdUuoFboX6sb1cGWbzaLcghzoRmORl5qQ4P91S3dx2yOErSa6rkw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PQY8Glx3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PQY8Glx3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66847C4CEF7; Wed, 25 Mar 2026 16:26:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774455978; bh=A53eXc1wKqhkXLFR8RFAyruE51u9fpUJf8NFVVelxRQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PQY8Glx3Ab/gAmdDUlBBYg+cdJxT4kK8rgIfGTW3p3uNWAesqThnHfTJC0puKQj9q aeIS6EM2QHtjk12s6+SaYiWaBAUmbchesJgM+CXqDQm4qCf29LfeNQaF8Jj2TWH5NK UFdwdInCCYaa18UHHazaqdkNSIFmHolUN2x/yx30n1IiKNPzTHau6RtV+qAPNiWkuV xmPJfwlbIbop92oUUmnHna51LXQEvRtNps4uXuvvCkSgb7e9fhRLY1WmKQHOax5G+c CySZHodmGv5zVdEbxzWUZ5Qk97PS1NvmBue0I/Z+VmLgHGPJD1nwhBLq3yEYfqEh4G Jx7S/V/vOlrzw== Date: Wed, 25 Mar 2026 16:26:12 +0000 From: "Lorenzo Stoakes (Oracle)" To: Andrew Morton Cc: "David Hildenbrand (Arm)" , Vernon Yang , Wei Yang , lorenzo.stoakes@oracle.com, ziy@nvidia.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vernon Yang Subject: Re: [PATCH mm-new v8 2/4] mm: khugepaged: refine scan progress number Message-ID: <06c83e1b-d7ee-48d5-a5c4-faad39db2f53@lucifer.local> References: <1da56bbb-9211-42d7-9b08-3ee56d2b538d@kernel.org> <8a5277e0-d70e-4849-9763-ed90e350a118@kernel.org> <22dccc17-787c-448e-a571-23c7a9afeaff@lucifer.local> <20260325080930.a205fca9e7e61c4a793f5228@linux-foundation.org> <3cf94628-3c6a-43ed-9fc1-29bd5a911497@kernel.org> <8d2e809c-e4c8-4d35-a2ae-62777b6dfbcc@lucifer.local> <0437ad42-612e-461f-906d-6757eb19a8de@kernel.org> <20260325091735.bf440358cf83c5d0369e0674@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260325091735.bf440358cf83c5d0369e0674@linux-foundation.org> On Wed, Mar 25, 2026 at 09:17:35AM -0700, Andrew Morton wrote: > On Wed, 25 Mar 2026 16:22:55 +0100 "David Hildenbrand (Arm)" wrote: > > > > > > > Really larger stuff should be resent I think, esp. if there's multiple > > > fixes in the series. > > > > > > A reply with the same-patch-but-with-fix-applied would definitely be > > > useful! > > > > Right, for completeness, this is what we had in an off-list thread: > > > > " > > Not sure if that's a problem for others, but I got the feeling that this > > escalated a bit lately. > > > > I know, that we prefer fixups to sort out smaller stuff. So far so good. > > In the last time there were some series where I was seriously completely > > lost which state of the patches would go upstream, or what I should even > > review, because there were just fixups over fixups. > > > > Fixups are nice, but for someone reviewing a series, too many fixups > > (either as inline patch or even worse, as independent patches) just > > causes a mess. > > > > It also gives the impression of "this is mostly done, so don't waste > > your time reviewing it anymore." --- "just the finishing touches" --- > > "don't jump in late and cause trouble". > > " > > hm OK, so what to do. We're OK with teeny -fixes but anything more > substantial we ask for a full resend and I do the heres-what-changed > reply? > Yeah that works for me. > I presently don't fold the -fixes until the very last moment. Could do > that much earlier if it helps anything? Possibly useful to people who > are looking at the series in the mm.git tree. It'd generally be easier imo to have those changes folded, but with something added to the commit message to indicate this so I can know whether or not that was folded in. Maybe just directly squash the commits? Thanks, Lorenzo