From: Michal Simek <michal.simek@amd.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michal Simek <michal.simek@xilinx.com>,
Nobuhiro Iwamatsu <iwamatsu@nigauri.org>,
<linux-spi@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] spi: dt-bindings: cadence: add missing 'required'
Date: Mon, 4 Jul 2022 15:09:55 +0200 [thread overview]
Message-ID: <06cd1d42-0c9e-a1b7-4219-d30cc202694a@amd.com> (raw)
In-Reply-To: <20220704130618.199231-1-krzysztof.kozlowski@linaro.org>
On 7/4/22 15:06, Krzysztof Kozlowski wrote:
>
>
> During the conversion the bindings lost list of required properties.
>
> Fixes: aa7968682a2b ("spi: convert Cadence SPI bindings to YAML")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/spi/spi-cadence.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-cadence.yaml b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> index 9787be21318e..82d0ca5c00f3 100644
> --- a/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> @@ -49,6 +49,13 @@ properties:
> enum: [ 0, 1 ]
> default: 0
>
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clock-names
> + - clocks
> +
> unevaluatedProperties: false
>
> examples:
> --
> 2.34.1
>
Reviewed-by: Michal Simek <michal.simek@amd.com>
Thanks,
Michal
next prev parent reply other threads:[~2022-07-04 13:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 13:06 Krzysztof Kozlowski
2022-07-04 13:06 ` [PATCH 2/2] spi: dt-bindings: zynqmp-qspi: " Krzysztof Kozlowski
2022-07-04 13:10 ` Michal Simek
2022-07-04 13:09 ` Michal Simek [this message]
2022-07-04 18:03 ` [PATCH 1/2] spi: dt-bindings: cadence: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06cd1d42-0c9e-a1b7-4219-d30cc202694a@amd.com \
--to=michal.simek@amd.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iwamatsu@nigauri.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®