From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>,
bgolaszewski@baylibre.com, pavel@ucw.cz, dmurphy@ti.com
Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH -next] leds: max77650: Remove set but not used variable 'parent'
Date: Sun, 26 May 2019 19:11:34 +0200 [thread overview]
Message-ID: <06cdba20-4bce-6739-7db9-dcf3a3c7b6bf@gmail.com> (raw)
In-Reply-To: <20190525141941.16088-1-yuehaibing@huawei.com>
Hi YueHaibing,
Thank you for the patch.
On 5/25/19 4:19 PM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/leds/leds-max77650.c: In function max77650_led_probe:
> drivers/leds/leds-max77650.c:67:17: warning: variable parent set but not used [-Wunused-but-set-variable]
>
> It is never used and can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/leds/leds-max77650.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/leds/leds-max77650.c b/drivers/leds/leds-max77650.c
> index 6b74ce9cac12..8a8e5c65b157 100644
> --- a/drivers/leds/leds-max77650.c
> +++ b/drivers/leds/leds-max77650.c
> @@ -64,7 +64,6 @@ static int max77650_led_probe(struct platform_device *pdev)
> {
> struct device_node *of_node, *child;
> struct max77650_led *leds, *led;
> - struct device *parent;
> struct device *dev;
> struct regmap *map;
> const char *label;
> @@ -72,7 +71,6 @@ static int max77650_led_probe(struct platform_device *pdev)
> u32 reg;
>
> dev = &pdev->dev;
> - parent = dev->parent;
> of_node = dev->of_node;
>
> if (!of_node)
>
Applied.
--
Best regards,
Jacek Anaszewski
prev parent reply other threads:[~2019-05-26 17:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-25 14:19 YueHaibing
2019-05-26 17:11 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06cdba20-4bce-6739-7db9-dcf3a3c7b6bf@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome