From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FE953EF673 for ; Mon, 29 Jun 2026 14:54:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782744873; cv=none; b=JV78sUBEY2llbuLx1mWKNwzRyPS6uqxsSC5SwiHCvp2K8TVYTN3LjYOos+Z/5orRNA0ACIFySTcSRt9eVmrHELBIrhlujoVaHggIFne2Ses0k5qUgj71YqsGGH6gTZZtlSOrBQfoiYadVrcdFrizu+iO/Bt47BcSZ46PusyVtPQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782744873; c=relaxed/simple; bh=v8CIyeLb1wkX+wqVPNxYQnc2a8miRec7mlz6SuvIKW4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XvVyWJpAHvPPE43lTdFZEbhiGTIUu5IHeGfV6NQjNnkKWlVk3kmDMFQ8qXGH/T4luynRU9miOHpo1QXOD9o8qCoHLbkvDryLrPqlZZHa8vVJ/pXUAXy/bk+jwsgjYTbRQqda6OFNERQcL8hZqgTE2IDsL6jQkUgsQ41mw76AJaU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=Gb6cUZ+M; arc=none smtp.client-ip=209.85.161.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="Gb6cUZ+M" Received: by mail-oo1-f48.google.com with SMTP id 006d021491bc7-6a16bcd0a2aso720163eaf.0 for ; Mon, 29 Jun 2026 07:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1782744869; x=1783349669; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4Z8Fz1fRVkTQIb2KN3JUG08EPIq1mQm84WayplzduZo=; b=Gb6cUZ+M9gtsVEyfnuz8i+HOjiNJOqHJjhwLfazTdEdCh7Hhdp8aLRxgJHHFHXkj06 3Cs5wSFyNqGfDDq3/o4Hh1mjIkYN107xhn800h72ZrkQ5JWpfeVVNo3OXGVQYV+TrPqE 49TIpK7j2TDEKBk7wtwtjOk2OgSLOdbHop8+jX+pGWWsTscQybbeGEP4DuH/wfxlks4i FMzEMbBsS3mYSzeHOFp0C9dd+4xmBYqAy3L2LNj0Nc8kdbsQdWGGKMywJMUFjjxQ+1tj kq9HEDKdirAUFOOZKjABl2W66HYZBaSJoKiMJdYI4CZEeSv0md+R8G5rQEzcIVjbVpIS j5Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782744869; x=1783349669; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4Z8Fz1fRVkTQIb2KN3JUG08EPIq1mQm84WayplzduZo=; b=nupDxPWbbOV1NiLjpDVYwdwIRb9b4maclVeTnj7wMwgDIJeVE1sPU7q1XRY5A6mDSq O9aOWxrWblCWqU9jOK53/PrjMQa8yWgP19cpkzuWYngUmUMuC+qqp/bj6XmfXqgWtJI9 D1HM1mJcdGUmJcOD7weBh36n1q85uX3BxXD9qQZ+RA+n/OLbd6KtHQ22UsZ4tjtrOMLO N6Zs7wYfuSd1BPo119E7olBcmNKC5GLwEr4z3p5sqWRkam58rjhoMT/KT2LXh3jED8K5 jlhl0GSbyhy/ZXof5yfjBPD7UpBAfIfIgMo7xuE6UTFY3IYH9nVMgInd21SekZuIm5hb J0+g== X-Forwarded-Encrypted: i=1; AFNElJ9gdlngQgf6VmDAuPBY8TQ2qhyuP7uUlqZhJMX0hIgOBa+qCmQkBcN4+oIIcfj7ZPrdwC/7u3qV3J/xPKI=@vger.kernel.org X-Gm-Message-State: AOJu0YyLoH5d7Bgoyed+3cVAaOlUJGhsQVccBJ6//K8K+eGYoyI1oDk4 cYNU6FHPp46QEWYGgIOtOEoEXOepEzIH0fr1CC1Zy58ps0+WzR+BC3Q1dCsXEWSXrvE= X-Gm-Gg: AfdE7ck9PYtRlAYZAaSwmFnK69sXo3i6V5SpywrERfufVt3oaDhhjVSc8EMHSWUiOdM 8OdIhc+yL8/gEixHRpGJsha2Q8o3fp7DDxoXZWosQ5UeZBOC1JrNbjPb2DmTx+nPhYXcbhhYHNk A+xNe407W9YFkYX35k3m0BCbX1HCM6EHZQXA8KL/rGZ0hRt37DkLzuOkF07EEozk5xZ3g2/yG4Q ajFLW8aOFryyWqOzrj2txTc0Emp1U3I3NEzUaBwQP02wS6toQx8cy3hcqjdM+ZctIoZPKCrOesB 5H4NE/GVzxSXUiWVALu/hnb0RTz2uUh6siHsMrAElvPzfBy8j+1lKAU0V8OAJRezVvxhRZFkoma YDqZQzf680XovxQOVhOJrK4QnG9YOzjlWb82Tva7Q9F093V6J6JbmXt3OKf/6sYzJA4WYMtPJ1v JwdNHVRPBdjadURXpoz70U95Q7qRT6LwQzZtdSVN511shNXdO+RO6RPSS6Xb/oDjU= X-Received: by 2002:a05:6820:708d:20b0:69d:f864:d35b with SMTP id 006d021491bc7-6a1890a067dmr11074eaf.23.1782744869202; Mon, 29 Jun 2026 07:54:29 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:3533:aa22:9a69:df1c? ([2600:8803:e7e4:500:3533:aa22:9a69:df1c]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-448db51ef14sm36094fac.0.2026.06.29.07.54.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 07:54:28 -0700 (PDT) Message-ID: <06ce8972-55f6-4114-a3c5-1d3bd6f45d73@baylibre.com> Date: Mon, 29 Jun 2026 09:54:28 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] iio: adc: add Axiado SARADC driver To: Petar Stepanovic , Akhila Kavi , Prasad Bolisetty , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Harshit Shah Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260622-axiado-ax3000-ax3005-saradc-v3-0-e57c7c7ae675@axiado.com> <20260622-axiado-ax3000-ax3005-saradc-v3-2-e57c7c7ae675@axiado.com> <6770a7af-06cc-4240-9b20-c299e7080ab1@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/28/26 9:33 PM, Petar Stepanovic wrote: > > On 6/28/2026 1:07 AM, David Lechner wrote: ... >>> +}; >>> + >>> +static void axiado_saradc_disable(void *data) >>> +{ >>> + struct axiado_saradc *info = data; >>> + >>> + writel(AX_SARADC_GLOBAL_CTRL_PD, info->regs + AX_SARADC_GLOBAL_CTRL_REG); >> People usual make read and write wrappers or use regmap to avoid having >> to write `info->regs + AX_SARADC_GLOBAL_CTRL_REG` so many times. > > My understanding is that simple read/write wrappers are not always > preferred unless they provide additional value. Would switching the > driver to regmap be acceptable here to avoid repeating the base address > calculation? > Yes, regmap is always nice because it brings a lot of extra features for free.