From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 182943DFC8A for ; Mon, 24 Aug 2026 06:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787552153; cv=none; b=kt4zvHwVhMuB4C72COtOUIrKcCPgk5RJ3IkLNy0SwEMMWBgAAM86UJYjaKCwqXYfyiob6fglaSkKcIn3W4vlgjO9c0VVkV9Tn+8O+3zbpnn/TzUh1+Mz+IsgjtEQyGMaZzD55JKHbCglPKUaDXpUpYhOs+VzrS5TCabBEXk3Kek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787552153; c=relaxed/simple; bh=tRQCXgKtyVduFGdDijZW87qrNHFarcqJUlMobl3NQIU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Pt0pjf0fodJnYDJeXx0G0sIAWedfKN208gcbPnObCavaYqfM4Bu5WFkgSZDn591lNL/Vbc98/kMnGrSo9/SIN1cqm5iVx4W7HC7/fxtjm5/cyTgGw7o+dpPWIUgK/2rEusYX56ZjawwuEXxOZZyQUOLHxzqqsRjXpTsMFtg2PQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d6ta27ZT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WanDSWYV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d6ta27ZT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WanDSWYV" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67O67l9h1662757 for ; Mon, 24 Aug 2026 06:15:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Y30mWngwb6kQRZHbIUppMdqrLbx0K2yCmsdwDBbotd8=; b=d6ta27ZTlsxf/jdo /nsLxC9EiTAsiCuUNO8Wwk2CozrjNqx970szHEdoDQfO4/NVQNcat4QC+MzLe1W5 J3NgWQ0PaGstxdUTng9cCGVWaZ/DQDaOQdlNEXNFRbDhPKOG+91tQBzGVaMeVgD6 Wat8V5oeqtZlMy8LwqsHE4agJ0OGfYdtkwA3Ue8UasXr90CVgAhhVyUDHQFnVT7K St2Fd6CQzmalljIiO8U+U0kYZXBLRn99wFleb3lfD6aOFyNgzMFqkxaZdB8hRS+W 0ZKvmWCUDa8EVK7ylQ4f2R+TMsYmwfSNoSS3UdQwIYRLA2rnMym6ni78+Ul7CvPP +e3eaA== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g8gdsg0tm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Aug 2026 06:15:50 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-77f133855b9so3098137.1 for ; Sun, 23 Aug 2026 23:15:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787552150; x=1788156950; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Y30mWngwb6kQRZHbIUppMdqrLbx0K2yCmsdwDBbotd8=; b=WanDSWYVESssoWrfYYHU853ZKYMSlWI17JLtsn9TkCMvxJkeOWNZKTLWh9pIOBW8Z+ FGxCvhqJ+AXjt2ByWLz3Ons41kfFWwPpECzlw39mMpacqtqVDrI1ES0i100nqOeBS+F5 G3MGu+8RfVmQ03lFZY9E1YGr87CYv7FZXgGnmjlFOc0u9wUPEVbdYpyt7vZdlCiu764w pMVrLZDPN8nUfhihQeALVcozZSsrD2GJZ5VXvnDxEM+pnNtXpN4KPLAKp47BdRT3uN7q IIieGZl3/yjM5EikuHj3s1/ilEL/6LRbZUPa+TowEcJqw9L7/Ul29nBH32PeQdEcJosb qTxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787552150; x=1788156950; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Y30mWngwb6kQRZHbIUppMdqrLbx0K2yCmsdwDBbotd8=; b=BDrNPvOAd+QPP3/tKq7sDLXedHb0OKzngbpJ+3uv9nNYKJKfF7w9X69tbJS/qWW4+W wWD9GgDMMWc2Xlm6Imub9x2CQXMAujEKSDcO2kONiH3Cc9QbMB50kNh/6MzQoR3vxEu6 Y5VHAA6GOutT3ow4O5L3ucw5iIAyox7Lw5rxqS5dlc7/Ei5ucstWUBgriN++5JlO/S3A LtnYn02OcFbPrzdZa+LPgV9sJsA7TF24RbvTDD69zIAFeBIYhU4QjNGKsLmiBzDd8dH8 Y7b5ZtGhSwpjrog1646nlPf+Np3aFNbV1KeCo/B1N4JWVXjgSxLp+nqv5e5NI/+u6IZ5 ArNg== X-Forwarded-Encrypted: i=1; AHgh+Ro5haOPwjsmBYtztmawt2jsaumcZ7/uMzRkbChdXxukGk/LVZhW4avPmHjtBlL5jdzEndeeD132ZOz6owg=@vger.kernel.org X-Gm-Message-State: AFuF++n/uDRnZ121s/EM5lmpkB9Bz9JITQVGSZ9iHLS5iKrw4tVo7wKd VklfnN/GhdoHslUUOKBUG6xHuzWehyFZ6sS+pPhh2vxgFC7btInLImPNbsxv3qTN47dIr1agF4t vqACrlh4JAxuJ2JUWahRC6tG67KSbCHilfFxFDMBFECNC87zgerMXIq+Xh9Zc4ZAWB6s= X-Gm-Gg: AR+sD13x3M+OmDZDRCiU6bssswzUqLpIjEuMTNVEu1rzmR3NdKuYYyfqjWRs+XJCMKc meoReESk1JT3kTMQPcmV1fIo3auXK+vf0NQN8uQCA1uQYizU9m4Q0x9QxjFcHG9vrJ5kaucLQRV 1kvu5sF99AIfjmdN/gN6uE8So18o4pjMKtRuPHEpWIyzm8Rr1Z5nnn31q2awKGdxNOpAdMQVJib XlDYjooVbqSjh5jUdpNC4+ZIfVkMZYPELJVQYUNTsyUy9an+0jxnUwdOD7zcfV5prsfZhpS9unp P85oequbt3d7ZUzR2EMakvCWauuxbU4Q9JtuaGbiKyoFi7VtXL66QamRVx5pvjZop/Dj2S7CzlM KcCcuyHBbPPxumc8CSGbT/k/P X-Received: by 2002:a67:fc4b:0:b0:77b:6331:7472 with SMTP id ada2fe7eead31-77b63317868mr2098743137.2.1787552150351; Sun, 23 Aug 2026 23:15:50 -0700 (PDT) X-Received: by 2002:a67:fc4b:0:b0:77b:6331:7472 with SMTP id ada2fe7eead31-77b63317868mr2098734137.2.1787552149949; Sun, 23 Aug 2026 23:15:49 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a59e199ad5sm6808499a12.18.2026.08.23.23.15.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Aug 2026 23:15:49 -0700 (PDT) Message-ID: <06cec69d-2188-4bc0-a4ea-98d99de8a37f@oss.qualcomm.com> Date: Mon, 24 Aug 2026 08:15:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] remoteproc: qcom_q6v5_mss: Don't require PAS for memory protection To: Paul Hollinsky , Bjorn Andersson , Mathieu Poirier Cc: Sumit Garg , Konrad Dybcio , Konrad Dybcio , Mukesh Ojha , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, regressions@lists.linux.dev References: <20260821081540.89137-1-phollinsky@holtechnik.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260821081540.89137-1-phollinsky@holtechnik.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: qHuSV_aDmDT4Bx5i--lD5zWytIdpBbsz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI0MDA1MiBTYWx0ZWRfXw4cf0uuv+c2k qh0I5X2koAAFrexmxvUVO89Q+LNh09rUISK3ryK+pmvya8gJmREG88uHQ8/q4qfXbru/ELedFe3 TmdXJoji15HcakTwFtu/oaCxuP4C/m8hs3BcbK/QIbXq/NyUO/XxBpJ15f9jbMCAuA8yAhxB6n6 p6gFv7VGdBu1kEGyDcl8rh1jBeGeqrEgYappOxobhq85qsDJkdTGTY7MLP2usthirtfMxUr6ngD 9MwjAJDQffKOy7ovnHI3CVi6rl+5iRqWZ6y+RhnLA/vl5gZoKyT3r0uBcE6nmTRhTd5i2yQTR0m yFB5U0Zl1r8fmtnr2Sl/cyRfqP9ukggd/w8hiOnsGy4wyHUpEP+dmKBZs+PRUoN3ld60KVd4FBD 3QW+CB+mJ7AEsAZ8xko95PGmzQPRVvaLD/5H4Hh5mnZ4vvf5KAH7TG7IFB/qX+RfNs7SarqxVDr mIxigS65vTEBQzAW4Tw== X-Authority-Analysis: v=2.4 cv=Fqo1OWrq c=1 sm=1 tr=0 ts=6a8be196 cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=8dbcrQVTAAAA:8 a=EUspDBNiAAAA:8 a=O9LFjDSsXfd6YXdYHBYA:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 a=2958AbVqUNA9gn3SDOjC:22 X-Proofpoint-ORIG-GUID: qHuSV_aDmDT4Bx5i--lD5zWytIdpBbsz X-Proofpoint-Spam-Info: AW1haW4tMjYwODI0MDA1MiBTYWx0ZWRfXwbdaOBwqlPHU h+9EW4yP22cihugOgBxFtNaleUAQUZ0mYjz0cQScjXZzwZdxXPCgpOqeGGqHwpithPh+djXfCUb nWG9FGw1OdfzlYU/Ovk60o1eTXeOUJI= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-24_02,2026-08-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 phishscore=0 spamscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608240052 On 8/21/26 10:15 AM, Paul Hollinsky wrote: > Commit f3b1357673dd ("remoteproc: qcom_q6v5_mss: Switch to generic PAS > TZ APIs") changed the probe-time gate for need_mem_protection platforms > from qcom_scm_is_available() to qcom_pas_is_available(). Memory > protection in this driver is implemented with qcom_scm_assign_mem(), > which is a TZ service distinct from PAS. The only PAS call in the driver > is qcom_pas_mem_setup(), and it is already guarded by need_pas_mem_setup. > > No descriptor sets both flags: sc7180, sc7280, sdm660, sdm845, msm8996 > and msm8998 set need_mem_protection only, while msm8937, msm8940 and > msm8953 set need_pas_mem_setup only. On TrustZone firmware that does not > implement PAS - for example SC7180 Chromebooks, where call-availability > queries report every QCOM_SCM_SVC_PIL command as unavailable - the modem > consequently never probes: > > platform 4080000.remoteproc: deferred probe pending: (reason unknown) > > On those machines the modem is also what loads the WLAN firmware, so > ath10k never receives QMI and wifi does not come up either. > > Gate memory protection on SCM availability as it was before, and require > PAS only where a PAS call is actually issued. Keeping the SCM check > matters: qcom_scm_assign_mem() passes __scm->mempool to > qcom_tzmem_alloc() without testing __scm, so dropping the gate entirely > would allow a NULL dereference when qcom_scm has not yet probed. > > Fixes: f3b1357673dd ("remoteproc: qcom_q6v5_mss: Switch to generic PAS TZ APIs") > Link: https://lore.kernel.org/r/20260808034716.58888-1-phollinsky@holtechnik.com > Signed-off-by: Paul Hollinsky > --- Reviewed-by: Konrad Dybcio Konrad