mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Hawkins, Nick" <nick.hawkins@hpe.com>
Cc: "christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
	"simon.horman@corigine.com" <simon.horman@corigine.com>,
	"Verdun, Jean-Marie" <verdun@hpe.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/5] net: hpe: Add GXP UMAC Driver
Date: Tue, 8 Aug 2023 22:54:47 +0200	[thread overview]
Message-ID: <06d1bc6a-0584-4d62-a2f4-61a42f236b3c@lunn.ch> (raw)
In-Reply-To: <DB60B268-85DA-43A2-A20F-52D684473348@hpe.com>

On Tue, Aug 08, 2023 at 08:39:39PM +0000, Hawkins, Nick wrote:
> Hi Andrew,
> 
> Thank you for your feedback, I have several follow up questions:
> 
> > So what you call a PHY is probably a PCS. Please look at the API used
> > in driver/net/pcs/. The real PHYs are external.
> 
> I doubled checked the internal PHY is considered a PHY, but I believe
> I can represent it as a PCS.

Is there proper documentation somewhere? register set? Is there
registers to kick off Base1000X/SGMII auto-neg? Somewhere to get the
results of the auto-neg? Since this is Base1000X/SGMII you want to
know if the link between it and the external PHY has established. And
if there is not an external PHY, but an SFP, this auto neg is with the
link peer, not the PHY. If it follows 802.3 clause 37, there should
already be a lot of helper code for you. Is this is licensed core?

> To confirm: I believe you are suggesting that
> we create a driver here for the handling of the internal PHY but not the
> external PHY?

The patches seem to suggest your board has an external Marvell PHY. So
i would expect it to use drivers/net/phy/marvell.c. Other boards,
using other PHYs, would use other PHY drivers.

> If so would it be leveraging the MDIO driver already created in this
> patchset? Or perhaps would it be replacing it for the internal PHY?

Many of the PCS drivers in driver/net/pcs are MDIO devices, so yes, it
would be layered on top of it.

      Andrew

  reply	other threads:[~2023-08-08 21:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-02 20:18 [PATCH v2 0/5] ARM: Add GXP UMAC Support nick.hawkins
2023-08-02 20:18 ` [PATCH v2 1/5] dt-bindings: net: Add HPE GXP UMAC MDIO nick.hawkins
2023-08-02 20:18 ` [PATCH v2 2/5] net: hpe: Add " nick.hawkins
2023-08-02 22:39   ` Andrew Lunn
2023-08-16  0:55     ` Hawkins, Nick
2023-08-16  1:29       ` Andrew Lunn
2023-08-02 22:42   ` Randy Dunlap
2023-08-03 11:39   ` Simon Horman
2023-08-02 20:18 ` [PATCH v2 3/5] dt-bindings: net: Add HPE GXP UMAC nick.hawkins
2023-08-02 22:45   ` Andrew Lunn
2023-08-03 15:52   ` Conor Dooley
2023-08-16 16:26     ` Hawkins, Nick
2023-08-17  8:55       ` Conor Dooley
2023-08-02 20:18 ` [PATCH v2 4/5] net: hpe: Add GXP UMAC Driver nick.hawkins
2023-08-02 23:20   ` Andrew Lunn
2023-08-04 20:55     ` Hawkins, Nick
2023-08-05  6:45       ` Andrew Lunn
2023-08-08 20:39         ` Hawkins, Nick
2023-08-08 20:54           ` Andrew Lunn [this message]
2023-08-09 23:55             ` Hawkins, Nick
2023-08-10  1:54               ` Andrew Lunn
2023-08-02 20:18 ` [PATCH v2 5/5] MAINTAINERS: HPE: Add GXP UMAC Networking Files nick.hawkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06d1bc6a-0584-4d62-a2f4-61a42f236b3c@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nick.hawkins@hpe.com \
    --cc=pabeni@redhat.com \
    --cc=robh+dt@kernel.org \
    --cc=simon.horman@corigine.com \
    --cc=verdun@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®