mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Pablo Mazzini <pmazzini@gmail.com>
Cc: Chen-Yu Tsai <wens@kernel.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Linus Walleij <linusw@kernel.org>,
	Samuel Holland <samuel@sholland.org>,
	linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v1 04/11] pinctrl: sunxi: add Allwinner B288 pin controller driver
Date: Fri, 25 Sep 2026 10:21:56 +0200	[thread overview]
Message-ID: <06d3fafb-5cdd-4978-aa11-a1dcb218c37b@arm.com> (raw)
In-Reply-To: <CAAxh=jtj7m=0chzXG1osVy0ftHys9mwf9S62kz1Oimgm3rsCUg@mail.gmail.com>

Hi Pablo,

On 9/24/26 22:28, Pablo Mazzini wrote:
> Hi Andre,
> 
>> look at pinctrl-sun55i-a523.c for an example
> 
> Thanks for the pointer - much nicer. Converted for v2.
> 
>> Can you put it into our wiki
> 
> The page already has the table and it matches the BSP exactly.

Lol, it was even me putting it there, but I hid it under that Collapse 
feature, so I didn't spot it yesterday. All good then, and thanks for 
the confirmation about them matching!

Cheers,
Andre

> 
> Thanks,
> Pablo
> 
> On Thu, Sep 24, 2026 at 10:17 AM Andre Przywara <andre.przywara@arm.com> wrote:
>>
>> Hi,
>>
>> many thanks for going through the task of creating this table - though I
>> think you wouldn't need to do this anymore, since we now have another
>> way of describing pins, which avoids this lenghty table in the driver:
>> look at pinctrl-sun55i-a523.c for an example.
>>
>> This would allow the "driver" to be a mere high level description, and
>> leave the mux values to the DT.
>>
>> That being said: it's good to have that info, for the lack of a manual.
>> Can you by any chance try to make a table out of it and put it into our
>> wiki (https://linux-sunxi.org/B288)? That would then be the replacement
>> for the manual. Maybe write a small tool to convert this data struct
>> into Wiki table format.
>>
>> Some general things inline ...
>>
>> On 9/23/26 22:16, Pablo Mazzini wrote:
>>> 78 pins across ports B, C, D, F and G. PH0 is BSP FPGA-only and omitted.
>>>
>>> Signed-off-by: Pablo Mazzini <pmazzini@gmail.com>
>>> ---
>>>    drivers/pinctrl/sunxi/Kconfig              |  10 +
>>>    drivers/pinctrl/sunxi/Makefile             |   1 +
>>>    drivers/pinctrl/sunxi/pinctrl-sun8i-b288.c | 623 +++++++++++++++++++++
>>>    3 files changed, 634 insertions(+)
>>>    create mode 100644 drivers/pinctrl/sunxi/pinctrl-sun8i-b288.c
>>>
>>> diff --git a/drivers/pinctrl/sunxi/Kconfig b/drivers/pinctrl/sunxi/Kconfig
>>> index dc62eba96348..a08186133090 100644
>>> --- a/drivers/pinctrl/sunxi/Kconfig
>>> +++ b/drivers/pinctrl/sunxi/Kconfig
>>> @@ -56,6 +56,16 @@ config PINCTRL_SUN8I_A23_R
>>>        default MACH_SUN8I
>>>        select PINCTRL_SUNXI
>>>
>>> +config PINCTRL_SUN8I_B288
>>> +     bool "Support for the Allwinner B288 PIO"
>>> +     default MACH_SUN8I
>>> +     select PINCTRL_SUNXI
>>> +     help
>>> +       Say Y here to enable pin controller and GPIO support for the
>>> +       Allwinner B288 (sun8iw10p1) SoC, as used in e-book readers such
>>> +       as the PocketBook Verse. This covers ports B, C, D, F and G,
>>> +       including the four banks of external interrupt capable pins.
>>> +
>>>    config PINCTRL_SUN8I_H3
>>>        bool "Support for the Allwinner H3 PIO"
>>>        default MACH_SUN8I
>>> diff --git a/drivers/pinctrl/sunxi/Makefile b/drivers/pinctrl/sunxi/Makefile
>>> index 951b3f1e4b4f..5129c0f19f3e 100644
>>> --- a/drivers/pinctrl/sunxi/Makefile
>>> +++ b/drivers/pinctrl/sunxi/Makefile
>>> @@ -18,6 +18,7 @@ obj-$(CONFIG_PINCTRL_SUN50I_A100)   += pinctrl-sun50i-a100.o
>>>    obj-$(CONFIG_PINCTRL_SUN50I_A100_R) += pinctrl-sun50i-a100-r.o
>>>    obj-$(CONFIG_PINCTRL_SUN8I_A83T)    += pinctrl-sun8i-a83t.o
>>>    obj-$(CONFIG_PINCTRL_SUN8I_A83T_R)  += pinctrl-sun8i-a83t-r.o
>>> +obj-$(CONFIG_PINCTRL_SUN8I_B288)     += pinctrl-sun8i-b288.o
>>>    obj-$(CONFIG_PINCTRL_SUN8I_H3)              += pinctrl-sun8i-h3.o
>>>    obj-$(CONFIG_PINCTRL_SUN8I_H3_R)    += pinctrl-sun8i-h3-r.o
>>>    obj-$(CONFIG_PINCTRL_SUN8I_V3S)             += pinctrl-sun8i-v3s.o
>>> diff --git a/drivers/pinctrl/sunxi/pinctrl-sun8i-b288.c b/drivers/pinctrl/sunxi/pinctrl-sun8i-b288.c
>>> new file mode 100644
>>> index 000000000000..ffd7eef68d19
>>> --- /dev/null
>>> +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-b288.c
>>> @@ -0,0 +1,623 @@
>>> +// SPDX-License-Identifier: GPL-2.0-or-later
>>> +/*
>>> + * Allwinner B288 (sun8iw10p1) SoC pinctrl driver.
>>> + *
>>> + * Derived from Allwinner's BSP driver pinctrl-sun8iw10p1.c, which is:
>>> + * Copyright (C) 2014 Jackie Hwang <huangshr@allwinnertech.com>
>>> + *
>>> + * Based on pinctrl-sun8i-a23.c, which is:
>>> + * Copyright (C) 2014 Chen-Yu Tsai <wens@csie.org>
>>> + * Copyright (C) 2014 Maxime Ripard <maxime.ripard@free-electrons.com>
>>> + */
>>> +
>>> +#include <linux/module.h>
>>> +#include <linux/platform_device.h>
>>> +#include <linux/of.h>
>>> +#include <linux/pinctrl/pinctrl.h>
>>> +
>>> +#include "pinctrl-sunxi.h"
>>> +
>>> +static const struct sunxi_desc_pin sun8i_b288_pins[] = {
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 0),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "uart2"),
>>> +               SUNXI_FUNCTION(0x3, "jtag0"),
>>> +               SUNXI_FUNCTION(0x5, "vdevice"),
>>
>> What's vdevice? I don't think we used to describe those weird functions.
>>
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>
>> I know Allwinner does this, but we do not describe the HighZ mux, it's
>> all 1's anyway, and the same for all pins.
>>
>> Those comments are probably irrelevant if you go with the new pinctrl
>> driver style. Most of the settings there should be straightforward to
>> figure out, just remember to add an IRQ map, to account for the missing
>> interrupts on PortC.
>>
>> Cheers,
>> Andre
>>
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 0)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 1),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "uart2"),
>>> +               SUNXI_FUNCTION(0x3, "jtag0"),
>>> +               SUNXI_FUNCTION(0x4, "spdif0"),
>>> +               SUNXI_FUNCTION(0x5, "vdevice"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 1)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 2),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "uart2"),
>>> +               SUNXI_FUNCTION(0x3, "jtag0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 2)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 3),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "uart2"),
>>> +               SUNXI_FUNCTION(0x3, "jtag0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 3)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 4),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "uart0"),
>>> +               SUNXI_FUNCTION(0x3, "pwm0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 4)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 5),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "uart0"),
>>> +               SUNXI_FUNCTION(0x3, "pwm1"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 5)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 6),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "twi0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 6)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 7),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "twi0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 7)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 10),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "spi1"),
>>> +               SUNXI_FUNCTION(0x3, "uart4"),
>>> +               SUNXI_FUNCTION(0x4, "pwm2"),
>>> +               SUNXI_FUNCTION(0x5, "wifi_uart0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 10)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 11),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "spi1"),
>>> +               SUNXI_FUNCTION(0x3, "uart4"),
>>> +               SUNXI_FUNCTION(0x4, "pwm3"),
>>> +               SUNXI_FUNCTION(0x5, "wifi_uart0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 11)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 12),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "i2s1"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 12)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 13),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "i2s1"),
>>> +               SUNXI_FUNCTION(0x4, "pwm4"),
>>> +               SUNXI_FUNCTION(0x5, "uart3"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 13)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 14),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "i2s1"),
>>> +               SUNXI_FUNCTION(0x4, "pwm5"),
>>> +               SUNXI_FUNCTION(0x5, "uart3"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 14)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 15),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "i2s1"),
>>> +               SUNXI_FUNCTION(0x3, "ac0"),
>>> +               SUNXI_FUNCTION(0x4, "twi1"),
>>> +               SUNXI_FUNCTION(0x5, "uart3"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 15)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 16),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "i2s1"),
>>> +               SUNXI_FUNCTION(0x3, "ac0"),
>>> +               SUNXI_FUNCTION(0x4, "twi1"),
>>> +               SUNXI_FUNCTION(0x5, "uart3"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 16)),
>>> +     /*Hole*/
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(C, 0),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "nand0"),
>>> +               SUNXI_FUNCTION(0x4, "spi0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled")),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(C, 1),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "nand0"),
>>> +               SUNXI_FUNCTION(0x3, "sdc2"),
>>> +               SUNXI_FUNCTION(0x4, "spi0"),
>>> +               SUNXI_FUNCTION(0x5, "sdc3"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled")),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(C, 2),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "nand0"),
>>> +               SUNXI_FUNCTION(0x4, "spi0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled")),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(C, 3),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "nand0"),
>>> +               SUNXI_FUNCTION(0x4, "spi0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled")),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(C, 4),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "nand0"),
>>> +               SUNXI_FUNCTION(0x3, "sdc2"),
>>> +               SUNXI_FUNCTION(0x5, "sdc3"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled")),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(C, 5),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "nand0"),
>>> +               SUNXI_FUNCTION(0x3, "sdc2"),
>>> +               SUNXI_FUNCTION(0x5, "sdc3"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled")),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(C, 6),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "nand0"),
>>> +               SUNXI_FUNCTION(0x3, "sdc2"),
>>> +               SUNXI_FUNCTION(0x4, "uart1"),
>>> +               SUNXI_FUNCTION(0x5, "sdc3"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled")),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(C, 7),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "nand0"),
>>> +               SUNXI_FUNCTION(0x3, "sdc2"),
>>> +               SUNXI_FUNCTION(0x4, "uart1"),
>>> +               SUNXI_FUNCTION(0x5, "sdc3"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled")),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(C, 8),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "nand0"),
>>> +               SUNXI_FUNCTION(0x3, "sdc2"),
>>> +               SUNXI_FUNCTION(0x4, "uart1"),
>>> +               SUNXI_FUNCTION(0x5, "sdc3"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled")),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(C, 9),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "nand0"),
>>> +               SUNXI_FUNCTION(0x3, "sdc2"),
>>> +               SUNXI_FUNCTION(0x4, "uart1"),
>>> +               SUNXI_FUNCTION(0x5, "sdc3"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled")),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(C, 10),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "nand0"),
>>> +               SUNXI_FUNCTION(0x3, "sdc2"),
>>> +               SUNXI_FUNCTION(0x4, "uart1"),
>>> +               SUNXI_FUNCTION(0x5, "sdc3"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled")),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(C, 11),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "nand0"),
>>> +               SUNXI_FUNCTION(0x3, "sdc2"),
>>> +               SUNXI_FUNCTION(0x4, "uart1"),
>>> +               SUNXI_FUNCTION(0x5, "sdc3"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled")),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(C, 12),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "nand0"),
>>> +               SUNXI_FUNCTION(0x3, "sdc2"),
>>> +               SUNXI_FUNCTION(0x4, "uart1"),
>>> +               SUNXI_FUNCTION(0x5, "sdc3"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled")),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(C, 13),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "nand0"),
>>> +               SUNXI_FUNCTION(0x3, "sdc2"),
>>> +               SUNXI_FUNCTION(0x4, "uart1"),
>>> +               SUNXI_FUNCTION(0x5, "sdc3"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled")),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(C, 14),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "nand0"),
>>> +               SUNXI_FUNCTION(0x3, "sdc2"),
>>> +               SUNXI_FUNCTION(0x5, "sdc3"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled")),
>>> +     /* Hole */
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 0),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x3, "uart1"),
>>> +               SUNXI_FUNCTION(0x4, "csi0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 0)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 1),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x3, "uart1"),
>>> +               SUNXI_FUNCTION(0x4, "csi0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 1)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 2),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x3, "uart5"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 2)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 3),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x3, "uart5"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 3)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 4),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x3, "uart5"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 4)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 5),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x3, "uart5"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 5)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 6),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 6)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 7),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 7)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 8),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x3, "uart1"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 8)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 9),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x3, "uart1"),
>>> +               SUNXI_FUNCTION(0x4, "csi0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 9)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 10),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 10)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 11),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 11)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 12),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 12)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 13),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x4, "csi0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 13)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 14),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x4, "csi0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 14)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 15),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x4, "csi0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 15)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 16),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x4, "csi0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 16)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 17),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x4, "csi0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 17)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 18),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x4, "csi0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 18)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 19),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x4, "csi0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 19)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 20),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x4, "csi0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 20)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 21),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x4, "csi0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 21)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 22),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x4, "csi0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 22)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 23),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x4, "csi0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 23)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 24),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x3, "spi2"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 24)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 25),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x3, "spi2"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 25)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 26),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x3, "spi2"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 26)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 27),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "lcd0"),
>>> +               SUNXI_FUNCTION(0x3, "spi2"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 27)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 28),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "pwm0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 28)),
>>> +
>>> +     /* Hole */
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(F, 0),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "sdc0"),
>>> +               SUNXI_FUNCTION(0x4, "jtag0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 0)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(F, 1),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "sdc0"),
>>> +               SUNXI_FUNCTION(0x4, "jtag0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 1)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(F, 2),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "sdc0"),
>>> +               SUNXI_FUNCTION(0x4, "uart0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 2)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(F, 3),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "sdc0"),
>>> +               SUNXI_FUNCTION(0x4, "jtag0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 3)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(F, 4),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "sdc0"),
>>> +               SUNXI_FUNCTION(0x4, "uart0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 4)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(F, 5),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "sdc0"),
>>> +               SUNXI_FUNCTION(0x4, "jtag0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 5)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(F, 6),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 6)),
>>> +
>>> +     /* Hole */
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(G, 0),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "pwm6"),
>>> +               SUNXI_FUNCTION(0x3, "dmic0"),
>>> +               SUNXI_FUNCTION(0x4, "spi1"),
>>> +               SUNXI_FUNCTION(0x5, "sdc1"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 3, 0)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(G, 1),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "pwm7"),
>>> +               SUNXI_FUNCTION(0x3, "dmic0"),
>>> +               SUNXI_FUNCTION(0x4, "spi1"),
>>> +               SUNXI_FUNCTION(0x5, "sdc1"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 3, 1)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(G, 2),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "twi1"),
>>> +               SUNXI_FUNCTION(0x3, "dmic0"),
>>> +               SUNXI_FUNCTION(0x4, "spi1"),
>>> +               SUNXI_FUNCTION(0x5, "sdc1"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 3, 2)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(G, 3),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "twi1"),
>>> +               SUNXI_FUNCTION(0x3, "dmic0"),
>>> +               SUNXI_FUNCTION(0x4, "spi1"),
>>> +               SUNXI_FUNCTION(0x5, "sdc1"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 3, 1)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(G, 4),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "twi2"),
>>> +               SUNXI_FUNCTION(0x3, "dmic0"),
>>> +               SUNXI_FUNCTION(0x4, "spi1"),
>>> +               SUNXI_FUNCTION(0x5, "sdc1"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 3, 4)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(G, 5),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "twi2"),
>>> +               SUNXI_FUNCTION(0x4, "ac0"),
>>> +               SUNXI_FUNCTION(0x5, "sdc1"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 3, 5)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(G, 6),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "i2s0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 3, 6)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(G, 7),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "i2s0"),
>>> +               SUNXI_FUNCTION(0x3, "dsd0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 3, 7)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(G, 8),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "i2s0"),
>>> +               SUNXI_FUNCTION(0x3, "dsd0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 3, 8)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(G, 9),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "i2s0"),
>>> +               SUNXI_FUNCTION(0x3, "dsd0"),
>>> +               SUNXI_FUNCTION(0x4, "bist_result0"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 3, 9)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(G, 10),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "i2s0"),
>>> +               SUNXI_FUNCTION(0x3, "dsd0"),
>>> +               SUNXI_FUNCTION(0x4, "bist_result1"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 3, 10)),
>>> +     SUNXI_PIN(SUNXI_PINCTRL_PIN(G, 11),
>>> +               SUNXI_FUNCTION(0x0, "gpio_in"),
>>> +               SUNXI_FUNCTION(0x1, "gpio_out"),
>>> +               SUNXI_FUNCTION(0x2, "spdif0"),
>>> +               SUNXI_FUNCTION(0x4, "pll_lock_dbg"),
>>> +               SUNXI_FUNCTION(0x7, "io_disabled"),
>>> +               SUNXI_FUNCTION_IRQ_BANK(0x6, 3, 11)),
>>> +
>>> +};
>>> +
>>> +static const struct sunxi_pinctrl_desc sun8i_b288_pinctrl_data = {
>>> +     .pins = sun8i_b288_pins,
>>> +     .npins = ARRAY_SIZE(sun8i_b288_pins),
>>> +     .irq_banks = 4,
>>> +};
>>> +
>>> +static int sun8i_b288_pinctrl_probe(struct platform_device *pdev)
>>> +{
>>> +     return sunxi_pinctrl_init(pdev,
>>> +                               &sun8i_b288_pinctrl_data);
>>> +}
>>> +
>>> +static const struct of_device_id sun8i_b288_pinctrl_match[] = {
>>> +     { .compatible = "allwinner,sun8i-b288-pinctrl", },
>>> +     {}
>>> +};
>>> +
>>> +static struct platform_driver sun8i_b288_pinctrl_driver = {
>>> +     .probe  = sun8i_b288_pinctrl_probe,
>>> +     .driver = {
>>> +             .name           = "sun8i-b288-pinctrl",
>>> +             .of_match_table = sun8i_b288_pinctrl_match,
>>> +     },
>>> +};
>>> +builtin_platform_driver(sun8i_b288_pinctrl_driver);
>>


  reply	other threads:[~2026-09-25  8:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23 20:16 [PATCH v1 01/11] dt-bindings: clock: add Allwinner B288 CCU Pablo Mazzini
2026-09-23 20:16 ` [PATCH v1 02/11] clk: sunxi-ng: add Allwinner B288 CCU driver Pablo Mazzini
2026-09-23 20:16 ` [PATCH v1 03/11] dt-bindings: pinctrl: add Allwinner B288 pin controller Pablo Mazzini
2026-09-24  9:07   ` Andre Przywara
2026-09-24 20:16     ` Pablo Mazzini
2026-09-23 20:16 ` [PATCH v1 04/11] pinctrl: sunxi: add Allwinner B288 pin controller driver Pablo Mazzini
2026-09-24  9:17   ` Andre Przywara
2026-09-24 20:28     ` Pablo Mazzini
2026-09-25  8:21       ` Andre Przywara [this message]
2026-09-23 20:16 ` [PATCH v1 05/11] dt-bindings: rtc: sun6i-a31: add Allwinner B288 Pablo Mazzini
2026-09-23 20:16 ` [PATCH v1 06/11] rtc: sun6i: add Allwinner B288 compatible Pablo Mazzini
2026-09-23 20:16 ` [PATCH v1 07/11] dt-bindings: i2c: mv64xxx: add Allwinner B288 Pablo Mazzini
2026-09-23 20:16 ` [PATCH v1 08/11] dt-bindings: mmc: sun4i-a10-mmc: " Pablo Mazzini
2026-09-23 20:16 ` [PATCH v1 09/11] dt-bindings: interrupt-controller: add Allwinner B288 NMI Pablo Mazzini
2026-09-23 20:17 ` [PATCH v1 10/11] dt-bindings: arm: sunxi: add PocketBook Verse Pablo Mazzini
2026-09-23 20:17 ` [PATCH v1 11/11] ARM: sunxi: add B288 and the PocketBook Verse board Pablo Mazzini
2026-09-24  9:03 ` [PATCH v1 01/11] dt-bindings: clock: add Allwinner B288 CCU Andre Przywara
2026-09-24 20:12   ` Pablo Mazzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06d3fafb-5cdd-4978-aa11-a1dcb218c37b@arm.com \
    --to=andre.przywara@arm.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=pmazzini@gmail.com \
    --cc=samuel@sholland.org \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®