mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Clément Léger" <cleger@rivosinc.com>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Conor Dooley <conor@kernel.org>,
	corbet@lwn.net, Paul Walmsley <paul.walmsley@sifive.com>,
	aou@eecs.berkeley.edu, robh@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, anup@brainfault.org,
	shuah@kernel.org, atishp@atishpatra.org,
	linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v5 08/16] riscv: add ISA parsing for Zca, Zcf, Zcd and Zcb
Date: Tue, 4 Jun 2024 09:18:25 +0200	[thread overview]
Message-ID: <06d8ae43-4aad-4637-a33b-9bae91b23872@rivosinc.com> (raw)
In-Reply-To: <mhng-d5016935-99b6-4dc6-bbd2-ed84eb834f98@palmer-ri-x1c9a>



On 30/05/2024 23:13, Palmer Dabbelt wrote:
> On Wed, 22 May 2024 00:20:09 PDT (-0700), cleger@rivosinc.com wrote:
>>
>>
>> On 21/05/2024 21:49, Conor Dooley wrote:
>>> On Fri, May 17, 2024 at 04:52:48PM +0200, Clément Léger wrote:
>>>
>>>> +static int riscv_ext_zca_depends(const struct riscv_isa_ext_data
>>>> *data,
>>>> +                 const unsigned long *isa_bitmap)
>>>> +{
>>>> +    return __riscv_isa_extension_available(isa_bitmap,
>>>> RISCV_ISA_EXT_ZCA) ? 0 : -EPROBE_DEFER;
>>>> +}
>>>> +static int riscv_ext_zcd_validate(const struct riscv_isa_ext_data
>>>> *data,
>>>> +                  const unsigned long *isa_bitmap)
>>>> +{
>>>> +    return __riscv_isa_extension_available(isa_bitmap,
>>>> RISCV_ISA_EXT_ZCA) &&
>>>> +           __riscv_isa_extension_available(isa_bitmap,
>>>> RISCV_ISA_EXT_d) ? 0 : -EPROBE_DEFER;
>>>> +}
>>>
>>> Could you write the logic in these out normally please? I think they'd
>>> be more understandable (particular this second one) broken down and with
>>> early return.
>>
>> Yes sure. I'll probably make the same thing for zcf_validate as well as
>> removing the #ifdef and using IS_ENABLED():
>>
>> static int riscv_ext_zcf_validate(const struct riscv_isa_ext_data *data,
>>                   const unsigned long *isa_bitmap)
>> {
>>     if (IS_ENABLED(CONFIG_64BIT))
>>         return -EINVAL;
>>
>>     if (__riscv_isa_extension_available(isa_bitmap, RISCV_ISA_EXT_ZCA) &&
>>         __riscv_isa_extension_available(isa_bitmap, RISCV_ISA_EXT_f))
>>            return 0;
>>
>>     return -EPROBE_DEFER;
>> }
> 
> Are you going to send a v6 (sorry if I missed it, I'm trying to untangle
> all these ISA parsing patch sets).

Yes, I was waiting for more feedback/Rb by it seems like I now have
everything I need. I'll send that.

Thanks,

Clément

> 
>>
>>>
>>> Otherwise,
>>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>>>
>>> Cheers,
>>> Conor.

  reply	other threads:[~2024-06-04  7:18 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-17 14:52 [PATCH v5 00/16] Add support for a few Zc* extensions, Zcmop and Zimop Clément Léger
2024-05-17 14:52 ` [PATCH v5 01/16] dt-bindings: riscv: add Zimop ISA extension description Clément Léger
2024-05-29 22:10   ` Charlie Jenkins
2024-05-17 14:52 ` [PATCH v5 02/16] riscv: add ISA extension parsing for Zimop Clément Léger
2024-05-29 22:08   ` Charlie Jenkins
2024-05-29 22:21     ` Charlie Jenkins
2024-05-30  8:12       ` Clément Léger
2024-05-30 14:37         ` Charlie Jenkins
2024-05-30 14:38           ` Clément Léger
2024-05-17 14:52 ` [PATCH v5 03/16] riscv: hwprobe: export Zimop ISA extension Clément Léger
2024-05-29 22:11   ` Charlie Jenkins
2024-05-17 14:52 ` [PATCH v5 04/16] RISC-V: KVM: Allow Zimop extension for Guest/VM Clément Léger
2024-05-17 15:17   ` Anup Patel
2024-05-29 22:16   ` Charlie Jenkins
2024-05-17 14:52 ` [PATCH v5 05/16] KVM: riscv: selftests: Add Zimop extension to get-reg-list test Clément Léger
2024-05-17 15:18   ` Anup Patel
2024-05-17 14:52 ` [PATCH v5 06/16] dt-bindings: riscv: add Zca, Zcf, Zcd and Zcb ISA extension description Clément Léger
2024-05-29 22:13   ` Charlie Jenkins
2024-05-17 14:52 ` [PATCH v5 07/16] riscv: add ISA extensions validation callback Clément Léger
2024-05-17 16:44   ` Conor Dooley
2024-05-21  7:58     ` Clément Léger
2024-05-17 14:52 ` [PATCH v5 08/16] riscv: add ISA parsing for Zca, Zcf, Zcd and Zcb Clément Léger
2024-05-21 19:49   ` Conor Dooley
2024-05-22  7:20     ` Clément Léger
2024-05-30 21:13       ` Palmer Dabbelt
2024-06-04  7:18         ` Clément Léger [this message]
2024-05-17 14:52 ` [PATCH v5 09/16] riscv: hwprobe: export Zca, Zcf, Zcd and Zcb ISA extensions Clément Léger
2024-05-30 15:25   ` Charlie Jenkins
2024-05-17 14:52 ` [PATCH v5 10/16] RISC-V: KVM: Allow Zca, Zcf, Zcd and Zcb extensions for Guest/VM Clément Léger
2024-05-17 14:52 ` [PATCH v5 11/16] KVM: riscv: selftests: Add some Zc* extensions to get-reg-list test Clément Léger
2024-05-17 14:52 ` [PATCH v5 12/16] dt-bindings: riscv: add Zcmop ISA extension description Clément Léger
2024-05-17 14:52 ` [PATCH v5 13/16] riscv: add ISA extension parsing for Zcmop Clément Léger
2024-05-30 15:48   ` Charlie Jenkins
2024-05-17 14:52 ` [PATCH v5 14/16] riscv: hwprobe: export Zcmop ISA extension Clément Léger
2024-05-17 14:52 ` [PATCH v5 15/16] RISC-V: KVM: Allow Zcmop extension for Guest/VM Clément Léger
2024-05-17 14:52 ` [PATCH v5 16/16] KVM: riscv: selftests: Add Zcmop extension to get-reg-list test Clément Léger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06d8ae43-4aad-4637-a33b-9bae91b23872@rivosinc.com \
    --to=cleger@rivosinc.com \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=atishp@atishpatra.org \
    --cc=conor@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kvm-riscv@lists.infradead.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®