From: Yunsheng Lin <linyunsheng@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>, Ronak Doshi <doshir@vmware.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Pv-drivers <Pv-drivers@vmware.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Guolin Yang <gyang@vmware.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] vmxnet3: use gro callback when UPT is enabled
Date: Fri, 17 Mar 2023 10:37:22 +0800 [thread overview]
Message-ID: <06e4a534-d15d-4b17-b548-4927d42152e1@huawei.com> (raw)
In-Reply-To: <20230316133405.0ffbea6a@kernel.org>
On 2023/3/17 4:34, Jakub Kicinski wrote:
> On Thu, 16 Mar 2023 05:21:42 +0000 Ronak Doshi wrote:
>> Below are some sample test numbers collected by our perf team.
>> Test socket & msg size base using only gro
>> 1VM 14vcpu UDP stream receive 256K 256 bytes (packets/sec) 217.01 Kps 187.98 Kps -13.37%
>> 16VM 2vcpu TCP stream send Thpt 8K 256 bytes (Gbps) 18.00 Gbps 17.02 Gbps -5.44%
>> 1VM 14vcpu ResponseTimeMean Receive (in micro secs) 163 us 170 us -4.29%
>
> A bit more than I suspected, thanks for the data.
Maybe we do some investigation to find out why the performace lost is more than
suspected first.
For example if LRO'ed skb is added in gro_list->list, and then new LRO'ed skb from
the same flow only go through the whole GSO processing only to find out we have to
flush out the old LRO'ed in the gro_list->list, and add new LRO'ed skb in gro_list->list
again?
> .
>
next prev parent reply other threads:[~2023-03-17 2:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 22:25 Ronak Doshi
2023-03-09 0:34 ` Yunsheng Lin
2023-03-09 22:50 ` Ronak Doshi
2023-03-10 1:02 ` Yunsheng Lin
2023-03-14 21:09 ` Ronak Doshi
2023-03-15 1:51 ` Yunsheng Lin
2023-03-15 2:27 ` Ronak Doshi
2023-03-15 3:04 ` Yunsheng Lin
2023-03-15 23:44 ` Ronak Doshi
2023-03-16 1:47 ` Yunsheng Lin
2023-03-16 4:03 ` Ronak Doshi
2023-03-16 4:13 ` Jakub Kicinski
2023-03-16 5:21 ` Ronak Doshi
2023-03-16 20:34 ` Jakub Kicinski
2023-03-17 2:37 ` Yunsheng Lin [this message]
2023-03-17 20:27 ` Ronak Doshi
2023-03-18 2:43 ` Jakub Kicinski
2023-03-23 5:43 Ronak Doshi
2023-03-23 15:48 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06e4a534-d15d-4b17-b548-4927d42152e1@huawei.com \
--to=linyunsheng@huawei.com \
--cc=Pv-drivers@vmware.com \
--cc=davem@davemloft.net \
--cc=doshir@vmware.com \
--cc=edumazet@google.com \
--cc=gyang@vmware.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®