From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EF66C6FD18 for ; Fri, 31 Mar 2023 09:44:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232353AbjCaJoT (ORCPT ); Fri, 31 Mar 2023 05:44:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230293AbjCaJoJ (ORCPT ); Fri, 31 Mar 2023 05:44:09 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49548975D for ; Fri, 31 Mar 2023 02:43:54 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id t10so87147024edd.12 for ; Fri, 31 Mar 2023 02:43:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares.net; s=google; t=1680255824; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OdHfhgdLXpGdQQ70tB5QV01kX6mq0IL4v/ZUmR7Biio=; b=K7VEmmVcYK0t9OlaAgHLB918aOf7dQXmRvQD5I5PHW7jcIw+sqQK6ruQUOrYwa4aIE Kei2+OjvtqEtrnkAW069tkfYK0ju2KCL5eIqqsz+cSRVfVgQrAB/RMo8RwSC9ximfRcP RmZT+IRH7F5loMxIneO+hPakQKBDhcU/AQfKEF13x+s5loiTKMZIQxrkDcWEcaKK+K9U +evkll95TimfGbI3bDa0FavxwdnqVCrNqsJYnmt35BrxPqYwS0YwKdiVI4MI/hPYVQxm h3KML8zUlqFog2Z1XCPUTbleFeuYFS3EmoXXlDB4D6cZmTLq658N03Jv9y5amOGyeGhY g8bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680255824; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OdHfhgdLXpGdQQ70tB5QV01kX6mq0IL4v/ZUmR7Biio=; b=W90uGcU+VZDUa5xJ2fWW9VGb7npjWafP2p2xz/bWVKy/UXnhlyiOJrVi1/8ck0jLma GnjXXuWw8Hg64WzCtpxRsgNr6MzsEEX4Tv4JcxU1qrnaoGqUBnPqNc6IfjNx1Eyrts15 ZHNdvnt9MNToUd8VpoD30IZz6zaK9Blr/7c/Fj0xPE7EA24QyRnyvrkiE/NbgB07MakX qSgyPmVY+AY7prVzvnpn0x9wWWs5O/eLhAfRrCx5svhffWbcF3Tej0WB2adZ9/9/lO0k R1jjCxAi6kk1QwV70UDS0biGXG90gNO2tY/n0sD71aXwGXA06HzZ8BEsIiIC6UvWODrj YXnw== X-Gm-Message-State: AAQBX9cG4lhi556NdjbuorHnrWpa3ADrdAL+tKnODpo7FDwyYbAfRdrI j+BoRWAalYpE8K7bwz/aheRFew== X-Google-Smtp-Source: AKy350b9Uqz0FLCeTKbuaA/ehixKd+VLyzVlriWLonP7gdRAobgYN/1BHqbglH+Sc5bYCl8nkR4Vyw== X-Received: by 2002:a17:906:3449:b0:93b:b8f3:225d with SMTP id d9-20020a170906344900b0093bb8f3225dmr26683289ejb.15.1680255824071; Fri, 31 Mar 2023 02:43:44 -0700 (PDT) Received: from [10.44.2.5] ([81.246.10.41]) by smtp.gmail.com with ESMTPSA id f21-20020a170906085500b00947b74db538sm388008ejd.154.2023.03.31.02.43.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 02:43:43 -0700 (PDT) Message-ID: <06e5749d-bd38-1d96-e4a0-e5e7a51dc52c@tessares.net> Date: Fri, 31 Mar 2023 11:43:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3 3/4] checkpatch: allow Closes tags with links Content-Language: en-GB To: Joe Perches , Jonathan Corbet , Andy Whitcroft , Dwaipayan Ray , Lukas Bulwahn , =?UTF-8?Q?Kai_Wasserb=c3=a4ch?= , Thorsten Leemhuis , Andrew Morton , David Airlie , Daniel Vetter , Konstantin Ryabitsev , Bagas Sanjaya , Linus Torvalds Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, mptcp@lists.linux.dev References: <20230314-doc-checkpatch-closes-tag-v3-0-d1bdcf31c71c@tessares.net> <20230314-doc-checkpatch-closes-tag-v3-3-d1bdcf31c71c@tessares.net> From: Matthieu Baerts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joe, Thank you for this review. On 31/03/2023 00:43, Joe Perches wrote: > On Thu, 2023-03-30 at 20:13 +0200, Matthieu Baerts wrote: >> As a follow-up of a previous patch modifying the documentation to >> allow using the "Closes:" tag, checkpatch.pl is updated accordingly. >> >> checkpatch.pl now no longer complain when the "Closes:" tag is used by >> itself or after the "Reported-by:" tag. >> >> Fixes: 76f381bb77a0 ("checkpatch: warn when unknown tags are used for links") >> Fixes: d7f1d71e5ef6 ("checkpatch: warn when Reported-by: is not followed by Link:") > > I don't think this _fixes_ anything. > I believe it's merely a new capability. When we first saw the new warnings checkpatch.pl was producing on a pre Linux 6.3-rc1, we thought it was an issue with checkpatch: the "Closes:" tag with a URL has been used for years without any complaints from checkpatch and people as far as I know. At some point we had to stop using it to please checkpatch and that's why we thought something had to be fixed: we initially [1] thought the "Closes:" tag case had been forgotten when the two mentioned commits had been created. But I'm fine to see these "Fixes" tags removed, I understand the "Closes:" tags were tolerated before but just not documented. Do I send a v4 without these two "Fixes" tags? It means only the v6.3 would not accept "Closes:" tags but we can work around that. [1] https://lore.kernel.org/all/a27480c5-c3d4-b302-285e-323df0349b8f@tessares.net/ Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net