From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751349AbdBZVCw (ORCPT ); Sun, 26 Feb 2017 16:02:52 -0500 Received: from userp1050.oracle.com ([156.151.31.82]:18914 "EHLO userp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbdBZVCu (ORCPT ); Sun, 26 Feb 2017 16:02:50 -0500 Subject: Re: [GIT PULL] Kselftest update for 4.11-rc1 To: Mike Rapoport , Linus Torvalds , Andrea Arcangeli References: <5355691a-e765-51d9-d6ab-cc5310fa30f0@osg.samsung.com> <20170226113744.GA17152@rapoport-lnx> Cc: Shuah Khan , Stephen Rothwell , linux-kselftest@vger.kernel.org, LKML , "davem@davemloft.net" From: Mike Kravetz Message-ID: <06e6875c-18bd-ccac-366d-b796d3200766@oracle.com> Date: Sun, 26 Feb 2017 12:40:36 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170226113744.GA17152@rapoport-lnx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: userp1040.oracle.com [156.151.31.81] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/26/2017 03:37 AM, Mike Rapoport wrote: > On Sat, Feb 25, 2017 at 03:42:55PM -0800, Linus Torvalds wrote: >> On Fri, Feb 24, 2017 at 1:09 PM, Shuah Khan wrote: >>> >>> Stephen saw a conflict during kselftest merge with next >> [..] >> >> There was also a conflict with some of Andrew's new userfaultfd tests. >> >> I'm not at all sure I merged that correctly, although I tried to make >> the resolution at least look sane. The odd thing about those new tests >> is that it's all the same source file, except built with different >> compile-time defines to be different test binaries. >> >> I didn't find any way to do that with any standard selftest makefile >> magic, so I just did the build rules by hand. >> >> Somebody should actually verify that it does the right thing, please.. >> Adding the two Mike's that did those test additions to the participant >> list. > > The userfaultfd_* tests are built and they are working just fine. Thanks Mike, I also verified that the tests build/run as they should. > Maybe it's worth adding userfaultfd_{hugetlb,shmem}.c which will define the > required defines and include userfaultfd.c? > Than we can get away with only specifying LDFLAGS += -lpthread in the > Makefile. I started the current scheme when adding support for hugetlbfs, which I thought would be a 'one off'. Did not know about the shmem work that was in progress. Another option is to only have a single userfaultfd executable and pass an option (anon, hugetlb, shmem ...) that indicates the type of pages/mapping to test. In any case, the makefile modifications work so this is not urgent. Perhaps we can discuss with Andrea and figure out what would be the best scheme moving forward. -- Mike Kravetz