From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2C2A3D9DA8 for ; Mon, 31 Aug 2026 09:11:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788167495; cv=none; b=uG3FSpRu/vOOPKkZNX/7qsKkeLf/KC/v3F+y6zVun43Jcg3sk98bJBkxw8o5xm86EVscfp6dnefcnUQxX9j7pSszBg1AYMZLlDNBppYyZdVvozhrGkV4cFlOo3LWCCYTIDbQbRgOo0Mgc8I/7QoAL3oyP57xAbZT71N6cLEYwgk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788167495; c=relaxed/simple; bh=wACfMGJ18cylwFY5eH2Nn2T6G6UKm6Fbj9mzSfm1oSc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WPOit2V9tU5BHvmHdzF8UmLibiUnIKsH4BZHvwHKr25+Biq2+8AFIvQTVnMrEC7tpMuyrVMnF8f00XV45fitRKWSBhdjQwJ1aynrQn3HLZz5ixR+JQdBaX5AMeARL10iUYAuhnwJaAgXh2qnOnYTeQXvcCKjdVox34Zxw6wDBW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j3AV5lWM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=b5Ru+1dK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j3AV5lWM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="b5Ru+1dK" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67V7xaSg3427321 for ; Mon, 31 Aug 2026 09:11:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nOBwJphAd4cD2oSNE9q8Kd3iMs48r1qUtnTODQfgbqg=; b=j3AV5lWMlFbf9yBb kfH8H9fSkW5REqUOSF4Ve2qmLG0N4cSJSm1cGni1wylf/yAJo6ZO8g+qAiHMTvMV uHO7avN4YkLHUr6/y4hjGhpUiqpxG3dsgCx35fkSqCDgvEu/kk2I9FCvAluiHqIU 639QDhdnXce+NTq+bpUoiVTbgq/Py1k/jft2dXt5U+CW/5QG1sDuXxEJvstLYdkV Jic6At52RCVj1R6lqoiwF33ZpWNNc7Pj3iVQ0bax8Z0RHjXsaMaD8XNlLn2F3XIb ccNBrgxdBWfWGNv2imTKFygKzrjgqCHdvzqjP2sN+J5h9OaYAdyfWFLLUBDYAtu8 aRQWBg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gd4pm8kta-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 31 Aug 2026 09:11:32 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cc640dfde3so38504715ad.1 for ; Mon, 31 Aug 2026 02:11:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788167491; x=1788772291; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nOBwJphAd4cD2oSNE9q8Kd3iMs48r1qUtnTODQfgbqg=; b=b5Ru+1dK/8w/RjVYZcjr6reriuorzb4tCnAbCQ0k82xl42YCkxCMUKKsqAJKj10++B H2uUzp6iyf1TtF7z5ARC19eEL2p+e2iynJxc8QAZXWy1rlCll5+RHCrgBYZ6Kss6q7+a Elu24KjYazLvuA2U6P0jG09S3uoAByJgghEAZpoSxydpKZQUk7zTDfo0NWH9J0GeEBkk 2AeKN9PVU/AKlwZR+7mvxbbWTOrVIUe+bYcbqunldCn8eH4zlrHoQRNrco+riTjU9l10 oaOtkwliBIm6M0/nPBa4J2e2t0y9nQXEQsaZWm3gyUkxSq8J8DjpIfu49SQiTRLAf4w1 Lwxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788167491; x=1788772291; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nOBwJphAd4cD2oSNE9q8Kd3iMs48r1qUtnTODQfgbqg=; b=fphKeQ7zxaPNKJr8RxuxNZACApxBxhMj6Bmmlhi1IApNefb5vhxXu55dAnMSlTSS46 RDzNMqMp3I/fOywV0XkI0KVXHIdsNy3RYY7Fkp/OClxkLhmrxRbuW9IGvve0uiNBu/Ux 1Z56OWpJuXZTkZddUj33cIVYPim0jIzvnm/pd/EwTGhV5ecxxsS5lMj2yzRa1GG52rtX jfgbJYQOvwFoGRek9r7m0a6VusjZndTwGSM9UBH684TALCmTYjz+S5pLdIfjBqNBj6Df I1tIGw0ElVjIgjUXZdUWEqXFWjuhcFkWaR1dOKEL+VTNf+TOnyHTQ+CUXEJeRn0hcDMB LdIw== X-Forwarded-Encrypted: i=1; AKwUvBzVHFoItpiVxRmH84MSwxC43+eROXerL6HXjsfazJeOrkzIxSfLsRtcpX1svNrA1wtorwCTuKBsSgiaAjg=@vger.kernel.org X-Gm-Message-State: AFuF++lMoSJKLXtFpxrxGJFMhPY5om36gg0e/j4wPKJOBbfCxexVUU2M tfA0YAam2PuzMZcsi5PVZw/hq4Vqz9moHe8YLEoUOzy5M9OhQ1ijO4KArXnmabrbYtSJmmMexm6 wAXHz312iT7d4ttI5IaPvUMEPiv19O3Bj0YHseauM+LnUP0Rcs92UBvq/8bOt3tPKOxA= X-Gm-Gg: AR+sD13giBWdeDdYDZ1JORGFs/h2djJkGBMP8q1lKggCDdvtw8OhYEnz0WAtRrug8jg i/9cMmvDe5Sa6oTNEMEQRTslKfV5Blv1bXjVTTLiZPtazpoALsu+4yL0+Wo4Sv9fh0Z6ZbXA6qz NHOOqxtpJNmmId2QNz4W9bEYYxRzUwWGC+hDQWCmg2FzzSeLzRLCmcU/c6IL2QeW9HVASvAQqzS 5g/oLv9xceAxD2Fcn8i5syDObuWeKT/cqMLEO0RD5MynyS+h/2bLTK8iRgljbYaFoEVcHHW0hRd YdOrkoZfE6nq2hRWh6xXITMzKAm57giPKtDZzcp1pncY1QRtWg6WefcfXTuLBfU6ICnF4dHV1+F WsGGbY/PiKIudFiuRXyz8GihZ+SGTfhQ31w== X-Received: by 2002:a17:902:ef4e:b0:2d8:d4cd:dc93 with SMTP id d9443c01a7336-2d8d4cddf80mr261831855ad.22.1788167491458; Mon, 31 Aug 2026 02:11:31 -0700 (PDT) X-Received: by 2002:a17:902:ef4e:b0:2d8:d4cd:dc93 with SMTP id d9443c01a7336-2d8d4cddf80mr261831065ad.22.1788167491015; Mon, 31 Aug 2026 02:11:31 -0700 (PDT) Received: from [10.217.218.20] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3286f7be440sm32564294eec.7.2026.08.31.02.11.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Aug 2026 02:11:30 -0700 (PDT) Message-ID: <06f17ae1-6d42-4a56-88b3-9f5568f6c9e6@oss.qualcomm.com> Date: Mon, 31 Aug 2026 14:41:19 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] i2c: at91: release DMA channels on remove and probe error To: Shengzhuo Wei , Codrin Ciubotariu , Andi Shyti , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Wolfram Sang , Ludovic Desroches , Oleksij Rempel , Pengutronix Kernel Team , Frank Li , Sascha Hauer , Fabio Estevam , Yao Yuan , Viken Dadhaniya , Bjorn Andersson , Vinod Koul , Konrad Dybcio , Praveen Talari Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-msm@vger.kernel.org, stable@vger.kernel.org References: <20260827-i2c-dma-channel-leak-v1-0-271d4adc03a0@cherr.cc> <20260827-i2c-dma-channel-leak-v1-1-271d4adc03a0@cherr.cc> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: <20260827-i2c-dma-channel-leak-v1-1-271d4adc03a0@cherr.cc> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: jzZcmoqZy38Mb4zOS22_KTqR3O8IWBa- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODMxMDA3OCBTYWx0ZWRfXzUXPx7Vr/8Rg woWddnEnic0bmeYAAL3f5drbkzlPKOwN9b7uIc6MTkZr70g7hl/5d/H4zbXo0kK/Fbi4CjPpY/9 /uPErp7QCA0Qiq/ukA37gDlbBsOebXokCPDsH6EbTsikunK6msOinjGpvA+dN5saGD3+RRaHX14 diTq2lw8x7eciUxfOmbhvJ6M51x1Ernz5qEsdaCOJZobgN31/9Asn68+ZYuUJF/DUb25hl8+VTh SY6A2rvv5EklUx9SzLP3M9Fui02EY943gOjLy1GANQtKaIbuzJBg4EjOsTHA1pORLdSjj2hG1Kp hY/ekRxKwhYcZ6IxPFECcQMViu2GgIq4oOGeEQb5A6Pu3WwWrq/YNxwxadWbFG7/vO6bSb03V56 4gy3M1IIVfOy6w6ETypO44l9JlV/7yKmrxVvrBjXw7y3W6xZQrOsuTBwWpGH2Vi9R6f+8vPByoe iC8XoDVw2BXWACqoidQ== X-Proofpoint-GUID: jzZcmoqZy38Mb4zOS22_KTqR3O8IWBa- X-Proofpoint-Spam-Info: AW1haW4tMjYwODMxMDA3OCBTYWx0ZWRfX56iD7xFJ/Pi+ LHrzufNHmkj7uPxiSciql82pfrh5AbYGLAnFOBbgscGZBNTcYGEVQk2MZJddp4B7mrnpXab4Y1u xSQ4J3CcqnId4RVigGgbnxCOzJanosU= X-Authority-Analysis: v=2.4 cv=GbQnWwXL c=1 sm=1 tr=0 ts=6a954544 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=AkmRZ_q-vRwkFVX3bY4A:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-31_03,2026-08-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 adultscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608310078 On 8/27/2026 9:13 PM, Shengzhuo Wei wrote: > at91_twi_configure_dma() requests exclusive tx/rx DMA channels, but > nothing ever releases them on driver detach, and the probe error path > after the channels are acquired (i2c_add_numbered_adapter() failure) > returns without releasing them either, because the remove callback is > not invoked after a failed probe. > > Move the release into a helper, call it from the existing > configure-failure path, the adapter-registration failure path, and > at91_twi_remove(). > > Fixes: 60937b2cdbf9 ("i2c: at91: add dma support") > Cc: stable@vger.kernel.org > Signed-off-by: Shengzhuo Wei > Assisted-by: GLM:5.3 > --- Acked-by: Mukesh Kumar Savaliya