From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752258AbcHHJKq (ORCPT ); Mon, 8 Aug 2016 05:10:46 -0400 Received: from lucky1.263xmail.com ([211.157.147.133]:46005 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752043AbcHHJKn (ORCPT ); Mon, 8 Aug 2016 05:10:43 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: suzhuangluan@hisilicon.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <6035ac1556aae650f6fdc65469779846> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH V4]mmc: dw_mmc-k3: UHS-SD card for Hisilicon Hikey To: Jinguojun , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ulf.hansson@linaro.org, adrian.hunter@intel.com, jh80.chung@samsung.com, wsa+renesas@sang-engineering.com, arnd@arndb.de, rmk+kernel@arm.linux.org.uk, shawn.lin@rock-chips.com References: <1470276973-41683-1-git-send-email-kid.jin@hisilicon.com> <74c80b1c-5570-0ee0-4132-ff703d8d5eb4@hisilicon.com> Cc: shawn.lin@rock-chips.com, guodong.xu@linaro.org, kongfei@hisilicon.com, suzhuangluan@hisilicon.com From: Shawn Lin Message-ID: <06f63a26-251d-5ba8-f877-dae75aa8e362@rock-chips.com> Date: Mon, 8 Aug 2016 17:10:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <74c80b1c-5570-0ee0-4132-ff703d8d5eb4@hisilicon.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi guy, On 2016/8/8 15:10, Jinguojun wrote: > Hi,maintainers > > Pls help to review code,this is the newest patch after your advise > Please give Jaehoon more time to review your patch before sending a ping or resending one(~2 weeks), as it's only four days(weekend included) since v4 was done....IMHO, it's quite bold... > Thx > On 2016/8/4 10:16, Jin Guojun wrote: >> mmc: dw_mmc-k3: Hisilicon Hikey have no tuning function in >> dw_mmc-k3.c,so we must do the tuning function stub when we init UHS card. >> Hrmmm.... remove "mmc: dw_mmc-k3:" from the meat of commit msg。 And you do nothing for dw_mci_hi6220_execute_tuning, why? Could you elaborate more.. >> V1:add .prepare_command in dw_mmc.c >> V2:delete .prepare_command, add err = 0 in dw_mci_execute_tuning >> V3:delete err = 0 in dw_mci_execute_tuning,add .execute_tuning in >> dw_mmc-k3.c >> V4:add "linux-mmc@vger.kernel.org", patch version, Changelog, etc.. The changelog is totally wrong, namely it should not be listed in the commit msg... >> >> Signed-off-by: Jin Guojun >> --- >> drivers/mmc/host/dw_mmc-k3.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c >> index 8e9d886..6247894 100644 >> --- a/drivers/mmc/host/dw_mmc-k3.c >> +++ b/drivers/mmc/host/dw_mmc-k3.c >> @@ -131,11 +131,17 @@ static void dw_mci_hi6220_set_ios(struct dw_mci *host, struct mmc_ios *ios) >> host->bus_hz = clk_get_rate(host->biu_clk); >> } >> >> +static int dw_mci_hi6220_execute_tuning(struct dw_mci_slot *slot, u32 opcode) >> +{ >> + return 0; >> +} >> + >> static const struct dw_mci_drv_data hi6220_data = { >> .caps = dw_mci_hi6220_caps, >> .switch_voltage = dw_mci_hi6220_switch_voltage, >> .set_ios = dw_mci_hi6220_set_ios, >> .parse_dt = dw_mci_hi6220_parse_dt, >> + .execute_tuning = dw_mci_hi6220_execute_tuning, >> }; >> >> static const struct of_device_id dw_mci_k3_match[] = { >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Best Regards Shawn Lin