From: Saeed Mahameed <saeed@kernel.org>
To: YueHaibing <yuehaibing@huawei.com>,
leon@kernel.org, davem@davemloft.net, kuba@kernel.org,
vuhuong@mellanox.com
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net/mlx5: Fix passing zero to 'PTR_ERR'
Date: Thu, 12 Nov 2020 15:58:10 -0800 [thread overview]
Message-ID: <06f889297f97217961e4e563d2715f28d1e8d953.camel@kernel.org> (raw)
In-Reply-To: <20201112142845.54580-1-yuehaibing@huawei.com>
On Thu, 2020-11-12 at 22:28 +0800, YueHaibing wrote:
> Fix smatch warnings:
>
> drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_lgcy.c:105
> esw_acl_egress_lgcy_setup() warn: passing zero to 'PTR_ERR'
> drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_ofld.c:177
> esw_acl_egress_ofld_setup() warn: passing zero to 'PTR_ERR'
> drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_lgcy.c:184
> esw_acl_ingress_lgcy_setup() warn: passing zero to 'PTR_ERR'
> drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c:262
> esw_acl_ingress_ofld_setup() warn: passing zero to 'PTR_ERR'
>
> esw_acl_table_create() never returns NULL, so
> NULL test should be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
Applied to net-next-mlx5
thanks
prev parent reply other threads:[~2020-11-12 23:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 14:28 YueHaibing
2020-11-12 23:58 ` Saeed Mahameed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06f889297f97217961e4e563d2715f28d1e8d953.camel@kernel.org \
--to=saeed@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vuhuong@mellanox.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®