mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Colin King <colin.king@canonical.com>,
	Artem Bityutskiy <dedekind1@gmail.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-mtd@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	hyc.lee@gmail.com, Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH][next] ubifs: fix uninitialized error variable err
Date: Mon, 17 Jul 2017 18:03:28 +0200	[thread overview]
Message-ID: <07004331-e62a-7c02-97db-bc69f8256c9b@nod.at> (raw)
In-Reply-To: <20170717160001.20285-1-colin.king@canonical.com>

Colin,

Am 17.07.2017 um 18:00 schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Variable err is not initialized and so the check to see if it is
> non-zero is basically checking a random garbage value. Fix this
> by initializing err to zero.
> 
> Detected by CoverityScan, CID#1451370 ("Uninitialized variable")
> 
> Fixes: 781f675e2d7e ("ubifs: Fix unlink code wrt. double hash lookups")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks, geert already pointed out that I've merged a bad patch.
I managed to merge the patch without the issues fixed that Hyunchul Lee
identified. ;-(

Thanks,
//richard

      reply	other threads:[~2017-07-17 16:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17 16:00 Colin King
2017-07-17 16:03 ` Richard Weinberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07004331-e62a-7c02-97db-bc69f8256c9b@nod.at \
    --to=richard@nod.at \
    --cc=adrian.hunter@intel.com \
    --cc=colin.king@canonical.com \
    --cc=dedekind1@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=hyc.lee@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®