mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Kazlauskas, Nicholas" <nicholas.kazlauskas@amd.com>
To: "Colin King" <colin.king@canonical.com>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Zhou" <David1.Zhou@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Charlene Liu" <Charlene.Liu@amd.com>,
	"Dmytro Laktyushkin" <Dmytro.Laktyushkin@amd.com>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amd/display: remove duplicated comparison expression
Date: Mon, 11 Nov 2019 08:37:56 -0500	[thread overview]
Message-ID: <0700f347-8590-7ab7-411d-0ae08fe9263d@amd.com> (raw)
In-Reply-To: <20191109154921.223093-1-colin.king@canonical.com>

On 2019-11-09 10:49 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> There is comparison expression that is duplicated and hence one
> of the expressions can be removed.  Remove it.
> 
> Addresses-Coverity: ("Same on both sides")
> Fixes: 12e2b2d4c65f ("drm/amd/display: add dcc programming for dual plane")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>

Thanks!

Nicholas Kazlauskas

> ---
>   drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 1fdba13b3d0f..1fa255e077d0 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -1491,7 +1491,6 @@ static enum surface_update_type get_plane_info_update_type(const struct dc_surfa
>   	}
>   
>   	if (u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
> -			|| u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
>   			|| u->plane_info->plane_size.chroma_pitch != u->surface->plane_size.chroma_pitch) {
>   		update_flags->bits.plane_size_change = 1;
>   		elevate_update_type(&update_type, UPDATE_TYPE_MED);
> 


  reply	other threads:[~2019-11-11 13:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-09 15:49 Colin King
2019-11-11 13:37 ` Kazlauskas, Nicholas [this message]
2019-11-11 17:35   ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0700f347-8590-7ab7-411d-0ae08fe9263d@amd.com \
    --to=nicholas.kazlauskas@amd.com \
    --cc=Charlene.Liu@amd.com \
    --cc=David1.Zhou@amd.com \
    --cc=Dmytro.Laktyushkin@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=colin.king@canonical.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®