From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B3C0C76186 for ; Thu, 25 Jul 2019 03:15:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B20321855 for ; Thu, 25 Jul 2019 03:15:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389927AbfGYDPJ (ORCPT ); Wed, 24 Jul 2019 23:15:09 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:60716 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388449AbfGYDPJ (ORCPT ); Wed, 24 Jul 2019 23:15:09 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id CFDA1E13BD828B343EFF; Thu, 25 Jul 2019 11:15:07 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.213) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 25 Jul 2019 11:15:02 +0800 Subject: Re: [PATCH v2] f2fs: use EINVAL for superblock with invalid magic To: Icenowy Zheng , Jaegeuk Kim CC: , References: <20190725030852.33161-1-icenowy@aosc.io> From: Chao Yu Message-ID: <07060e23-bc6f-5d35-a7f3-e75c8ebb3b65@huawei.com> Date: Thu, 25 Jul 2019 11:15:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190725030852.33161-1-icenowy@aosc.io> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/7/25 11:08, Icenowy Zheng wrote: > The kernel mount_block_root() function expects -EACESS or -EINVAL for a > unmountable filesystem when trying to mount the root with different > filesystem types. > > However, in 5.3-rc1 the behavior when F2FS code cannot find valid block > changed to return -EFSCORRUPTED(-EUCLEAN), and this error code makes > mount_block_root() fail when trying to probe F2FS. > > When the magic number of the superblock mismatches, it has a high > probability that it's just not a F2FS. In this case return -EINVAL seems > to be a better result, and this return value can make mount_block_root() > probing work again. > > Return -EINVAL when the superblock has magic mismatch, -EFSCORRUPTED in > other cases (the magic matches but the superblock cannot be recognized). > > Fixes: 10f966bbf521 ("f2fs: use generic EFSBADCRC/EFSCORRUPTED") > Signed-off-by: Icenowy Zheng Reviewed-by: Chao Yu Thanks,