From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3F4F18FDAE for ; Tue, 3 Dec 2024 07:40:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733211632; cv=none; b=J/hezJ7mYty4Akj7iHCG5XLjjS3+HTm5SWa7egKRpy/DqhqhE2r6T9qtLjFoRXFixhdX1u5Lw3fT7KO7n4NhSxtwMfLVold/0yh+b+snChDqV2KDmt42b1XA5nz2FI9lOn1YGZSIVQo0hL4pXxntUpSrvJkTK3jgPUlgryy2Kds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733211632; c=relaxed/simple; bh=aC6uyDIFdnQ/ymIK+YdQ6AOiIbBcniP4ju7dhl9Kzig=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FzdTRWcLLqnL6ZWeuIvLxXcWnPEAom4A9yNeUL3PFGqhfqPHOmTWBHUuoKn4PwAPDI7rR62FjtCsZo/1r6jlrpT6vuivLLqHxO/kGLISUPQRN930SDVwwIRAgt39lueLT8ufzNAD1uRw1FAPe08BHBdlhzJICfy3u+ECMccvQwI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Wd55cP32; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Wd55cP32" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4B36rT0Z023609 for ; Tue, 3 Dec 2024 07:40:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lO8NsXbzPR2jsufulhi9jEDxuqQUNCDFlqI0eKnZHKI=; b=Wd55cP3217V+ZOhx 9G45tX3rRPaoSIY7gt6bYMDIsMUm1VFDJEfg4DyCxznxNkUWRsFY7TAVSMleFDgP H6U/gDRIzboGnEZRkHIHVurG7KwHju4qoQ8uWkcIXXwTfuDsT7yBbQ9l8S4MsYwX 7qpAen4Cs9xu+cqFz0JHe3hXS/gQz5n9M+1f2BFzGwSU1WEuDvbdypIFx/tSmh6R CS+hcnWGH4sA32JRGks89gBMRiKGDRbU6EKjk5YULyp6p5idYFld1usX92dfndWg 9TPT0WlAAaV/vf+3oElEmQMHUYWYUJ4ETrptPc7L8tIx/w7TxOftcEIsWgWHcal2 5oVmcQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 437tstfang-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 03 Dec 2024 07:40:24 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-215699398bdso24055525ad.0 for ; Mon, 02 Dec 2024 23:40:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733211623; x=1733816423; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lO8NsXbzPR2jsufulhi9jEDxuqQUNCDFlqI0eKnZHKI=; b=woB5Q6+aDBBgSdy/HbAc88MwE746Qj2XHyqLZV52JsvMP95PxLq/Ls+DhRVG2Hp7Hr pgXSiiqJQm0zJfqVs8r8QcJBP/EwhG3HFxgig/rbPxtfbfum6LiA9KhBmdPyO3n0PkaJ t3EHdTp8uJz73ZwKS7IcZ6mXw4own/XiREOnoePiVBnBgNzWz3p7WIyx+bzSF4d4w4ii kftvbLdzlxrAsYg3myBgw/ClhKi8sfF//Ei1PinqI4xjNkvqS0jlef/3jEpo+AVKz631 pH4TWlDIZWAamjkR0tBCY6Cu5cVHTH7h66JxrtagdiqacyTlJjs9FSrYze/o671/fNFy f3nw== X-Forwarded-Encrypted: i=1; AJvYcCWZfejwXYNDUYhDHwBT1WQ145HHVxvMBUPhWlH9t8ZP3uegaxnasC2XMi1nPyK4v+u0Nc92moWB9pt09bM=@vger.kernel.org X-Gm-Message-State: AOJu0YyjQ0+bCuuTmwj2iGYnZTaTL/WOkLBRRU1WNzGieJaEzewpnhNG VwqJaBL0dCJfbpIrAYgtZdnOqcyEYKs3s94SQOLcM5PJHEGWHN+3jkXgI66fNmcVBc3HC325e8a oliKBIjKkc444V1am00oVvQ1XvhrLEfDtjY4Q10YV+QDC+8Zn/+K+TUfg2uk48L4= X-Gm-Gg: ASbGnct129Nm6kGeLW1uUkhM0dE+p1NAM2BH30Hmv07aDaEmJYqtJxo/8xs3sMTXbw3 gFIOgpDwEuHCq0fiRTFOoGCcLQNTQVcFtzVlNmmuqzR3oNBSRPqMO/+jFeeT/fnTNjAetSJd4O+ UTmnM2vpPQB5U8z7oSI6l9Pe9nax+Zv26KB+rE6/E6tdNlkjo6gUVv/u8J0wTIm0mxCZU59RwlV htmILHWscaqtsygD4uKLISpFdJ93RXnXCUQnPCPBl4yVENcJkNz9RmZDDm+qVIODLyJ9rDeujzx x6xQXQ== X-Received: by 2002:a17:902:dac5:b0:211:f8c8:373d with SMTP id d9443c01a7336-215bd0c1566mr28115115ad.31.1733211623242; Mon, 02 Dec 2024 23:40:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IFF3EyLqZQow0ncyltq3o6H+hJOd1Mbf3qno+5shgyQHr2MT59dxXW5CqvbHyRcmqkG2ODN6A== X-Received: by 2002:a17:902:dac5:b0:211:f8c8:373d with SMTP id d9443c01a7336-215bd0c1566mr28114855ad.31.1733211622864; Mon, 02 Dec 2024 23:40:22 -0800 (PST) Received: from [10.92.169.167] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-215218f47e4sm88595425ad.23.2024.12.02.23.40.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Dec 2024 23:40:22 -0800 (PST) Message-ID: <07087ab9-7724-4405-8fb2-942c1b76ed57@oss.qualcomm.com> Date: Tue, 3 Dec 2024 13:10:17 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 3/3] arm64: dts: qcom: sc8280xp-blackrock: dt definition for WDK2023 To: Jens Glathe Cc: Kalle Valo , linux-arm-msm@vger.kernel.org, Konrad Dybcio , Bjorn Andersson , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Merck Hung , xlazom00@gmail.com, Conor Dooley , Krzysztof Kozlowski References: <20241202-jg-blackrock-for-upstream-v9-0-385bb46ca122@oldschoolsolutions.biz> <20241202-jg-blackrock-for-upstream-v9-3-385bb46ca122@oldschoolsolutions.biz> <0352b36d-92fa-42ba-bc20-40cef0f9ea42@oss.qualcomm.com> <7f5d424d-09a1-46ca-92a6-a1e7f8084bf0@oldschoolsolutions.biz> Content-Language: en-US From: Krishna Kurapati In-Reply-To: <7f5d424d-09a1-46ca-92a6-a1e7f8084bf0@oldschoolsolutions.biz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: JB3RR5ySNHe_8WLeEa5c0M3Kq5x3So7- X-Proofpoint-GUID: JB3RR5ySNHe_8WLeEa5c0M3Kq5x3So7- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 spamscore=0 impostorscore=0 mlxlogscore=902 mlxscore=0 priorityscore=1501 suspectscore=0 phishscore=0 adultscore=0 clxscore=1015 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412030064 On 12/3/2024 12:37 PM, Jens Glathe wrote: > On 03.12.24 06:08, Krishna Kurapati wrote: > > [...] >> >> Although functionally unused, there is one more connector node that >> runs between QMPPHY and DWC3 node. For example in [1], please check >> "usb_dp_qmpphy_usb_ss_in" and "usb_1_dwc3_ss" >> >> Would be good to check why it is missing and add it further. >> >> [1]: >> https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> >> > I checked, there's an extra endpoint for usb_?_qmpphy_usb_ss_in and > usb_?_qmpphy_dp_in.  usb_?_qmpphy_usb_ss_in  are defined (and "wired") > between port@1 of usb_?_qmpphy and port@1 of usb_?_dwc3, in > sc8280xp.dtsi. On port@2 of the qmpphy is usb_?_qmpphy_dp_in as > endpoint, which is further defined in sc8280xp-microsoft-blackrock.dts > as connecting to mdss0_dp?_out. Maybe that's wrong, it's the same as in > sc8280xp-lenvo-thinkpad-x13s.dts. > You are right. Ignore my comment, that node is specified in the base dtsi file for sc8280xp. From usb pov, your code looks good. Thanks, Krishna,