From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 980C11990B7 for ; Wed, 30 Jul 2025 10:16:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753870589; cv=none; b=lN5W9r3/NwST2iTbbaUX1WKt0tfoQx+wlPwGqjihbw4ke+S1vyIou9LHttOS44imFtTHZBcGuxsQ7Cp8pXGYNn5zGwhVJP7jK8IQPARnwVQhsMMLzZJxWesJJ3DjKjdYf4E3yP1kBuK3hnoxIV3uvDn2YvOv/0fVc7jck6Mh/Yc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753870589; c=relaxed/simple; bh=uut0TxsQwYWw9IdoyR5yFTrLz137/PO55syezkU2RTs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mrmhG2ecE0qnpd7YoyDD5LLgMqWOlWkdYhuncnrWn/U5tZjvpiPnX+XDy5uqvskwvVhPJJ/iIAkg9pH0hwNkdm0eHCuXkGP4OjezjeEWf6hI2zjmeCUqDG+9kL7tEUi+Ot2RGZIwbd4fOcikhNBWLYfkFiJ0z+/EyluJtG9GHko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Kw5bmzUS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Kw5bmzUS" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56U6JiPI027029 for ; Wed, 30 Jul 2025 10:16:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= e74WcFwkTr6qVr34ZJAvZTfeytAh6aWlboCX6N91C3A=; b=Kw5bmzUSHx4PROsj WFRjmhqaxrVUj/5aGffpMHtJaySYHJKSY7gbM1742maN0xiQAkLy+hHEDb16UgwV UcCLWhxRDLqFv0M9FGqOkSyQ1ZKRGtjf9oMWfzonCyS3lDfQiUB1BcDvfr+pFMxo VwxGQnokbaF/DeCxN77CsEGOxmsgDTf3R+ESA05MvX0gz8NP5ChOjHHPc2XvTY1H 1q5nKz4sc9Pq15owH390aNtsUt49yr1gi8mlvVk0Sel9m47bjjzBF8WzRT46vXTL LGAAR+XsE3RKLJLEf+5/r1K2AaSbKsskxYf/KlJNRTp9AnDg2AmK7coCk1eh2a3n ngFqwA== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 484q3xuadq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 30 Jul 2025 10:16:26 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-707641946ecso1746066d6.1 for ; Wed, 30 Jul 2025 03:16:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753870585; x=1754475385; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e74WcFwkTr6qVr34ZJAvZTfeytAh6aWlboCX6N91C3A=; b=UVmc0kOXDpPrPUCOoZilwDqjOrtRv+jnvzA66kO6zFJq3vLQm2+wY+hCHtLnv2lh05 zCAp0hTdgxA7hb23OZ5DBq8+0ZkF0q0h340iKFW0fomVnFf7jnyyadC3ZLwJyomebYPN Nmgbv+6eMy4UCJ2Cucqtf3dj50EVt+IfG30PLkOGmXUr+I7qlfBByJIGsBlSTprXQEzE fB8zb+8xfgbwF9YOH8ykOaDRyYuCcbK3N+ZCIx+sPLB2MHLlYZwyD06h6+OsNXCSBA/S 8stOa4lW7VqFGAdNjmBQWfI5UIDbsJEafXMA/81bPMOV2zGUnqKUq0mPu54zb+X7FQC8 JBMQ== X-Forwarded-Encrypted: i=1; AJvYcCUi5uELxSGpw8nA8O8Fcf5FJgrXSJAL+7ZaEY3RJiTno26Ym0gIYtG0aXxnyAmQrie+BeEOXhNg/chHm2M=@vger.kernel.org X-Gm-Message-State: AOJu0YzTFVqeFBHXeKa/W2PwIaK5GpuOjdjKWhEEZHSwFQcrHf8DNYSo A4ouj5h3JqunvxWGb2ZTpzYX7LfY6HD2jkunwpgx6cuEZaDviwXs0kGlFoxV3Oe4gLDOywf+sRb hL5OEm88+5rcCRmxvnP9okA3YXWdNwH1bi9JIbmOTrCNg5KvajUsfDu2XhSYQjpTsnkw= X-Gm-Gg: ASbGnctrkeW23kp87h7DznC0ur2z9ChJEHCggT/1g8PCLaq628k+/UE0X0pLhLA5CWS dIee1FClYsoToPmCCZOuD/tqC1Z4OD7mTCmOUPnZzjEcLvIJpxH860pYuUpk+bfPI9SxsE/Ecpi qlFjs2hwgyp5M+XCNBlhDAKINlU7V3O3Oe2bDUbjoeRUU+qLbZHUL5CppbfmmuUdqwykahWQvOz nr8ISsWz59oxdWaxAhwDRWxM+uNIklYn8eB/6INMqTTKDkFUdDC3LrCi29Z360/y3F1jyzEI07e Yq0BYfGTNiIH5/0gwYgwqErNl7Tc4n259WW5EMQMBAh1EwPm7/KjVNGWX/ReAe9aGbpOdV8wOtn AK6TtOm/ZDQWjoK16Sg== X-Received: by 2002:a05:620a:a907:b0:7e6:6f9d:4b06 with SMTP id af79cd13be357-7e66f9d4b93mr156062785a.0.1753870585393; Wed, 30 Jul 2025 03:16:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFMVovcbr9AHNlT90gl+k15THWxhh7Sd7H8hPKD8T+t66JapkQsUuAU5RAVLiYqLUQ/JNBoxw== X-Received: by 2002:a05:620a:a907:b0:7e6:6f9d:4b06 with SMTP id af79cd13be357-7e66f9d4b93mr156060585a.0.1753870584897; Wed, 30 Jul 2025 03:16:24 -0700 (PDT) Received: from [192.168.43.16] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-af635accc38sm715115266b.114.2025.07.30.03.16.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Jul 2025 03:16:24 -0700 (PDT) Message-ID: <070915c8-4d7f-40d2-ba38-e20a801c9089@oss.qualcomm.com> Date: Wed, 30 Jul 2025 12:16:21 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 5/5] soc: qcom: ubwc: Add QCS8300 UBWC cfg To: Yongxing Mou , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kuogee Hsieh , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250730-mdssdt_qcs8300-v5-0-bc8ea35bbed6@quicinc.com> <20250730-mdssdt_qcs8300-v5-5-bc8ea35bbed6@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250730-mdssdt_qcs8300-v5-5-bc8ea35bbed6@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=JovxrN4C c=1 sm=1 tr=0 ts=6889f0fa cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=COk6AnOGAAAA:8 a=TI01094hTbTrXjSAet8A:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: Nm8qC_gmFMrh4rTD_lNAhSxJTgzwuD5k X-Proofpoint-GUID: Nm8qC_gmFMrh4rTD_lNAhSxJTgzwuD5k X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzMwMDA3MiBTYWx0ZWRfXxuT/0RYG1Lxn sDREFiS8Je8HHGVt8seHI2HoSVSthm896hI0Ib7bD8SkakppH31vEhUYwSVJsHMxaIXVa3G/ZTo 8LKfSzLeyCphlkFOH6XVwchc/DAqae4OgR97g/p16ok8UigWR4E/QhJcD+qG3akttjBpsNxGeDM HX8momTcnXaYHcQQ2REagP1yqaM13B30y4dUMwar7uRGmHN29QqpcTZKPRTwPVBsDVpGn3e8qns GdAy2MF98/9gZkzoBHGV3dH330F4esSq9iDIuhCQSb4SPCNGH2HJFyJ8adqxZfuMs1eEg6He7R7 hfnb7fTEOBYSOZCcadK7ciGgezVxpOxEJ4fA0eYBU2CunUnPW6o5bpxBUHYCSszn2LHhZ/G9xtt OfTK51O8jCi0gu0WovGbmd1vh2bfXkXPRTAGpgIBz1Qomu1cKYK3Wjnswji+0oyWiEwnh3DB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-30_04,2025-07-30_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 priorityscore=1501 bulkscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507300072 On 7/30/25 11:42 AM, Yongxing Mou wrote: > The QCS8300 adopts UBWC 4.0, consistent with SA8775P, add 4 channels LP5 > configuration data according to the specification. > > Signed-off-by: Yongxing Mou > --- > drivers/soc/qcom/ubwc_config.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c > index bd0a98aad9f3b222abcf0a7af85a318caffa9841..389fb871018b65987295db60571c063b4d984d70 100644 > --- a/drivers/soc/qcom/ubwc_config.c > +++ b/drivers/soc/qcom/ubwc_config.c > @@ -35,6 +35,16 @@ static const struct qcom_ubwc_cfg_data qcm2290_data = { > .highest_bank_bit = 15, > }; > > +static const struct qcom_ubwc_cfg_data qcs8300_data = { > + .ubwc_enc_version = UBWC_4_0, > + .ubwc_dec_version = UBWC_4_0, > + .ubwc_swizzle = UBWC_SWIZZLE_ENABLE_LVL2 | > + UBWC_SWIZZLE_ENABLE_LVL3, > + .ubwc_bank_spread = true, > + .highest_bank_bit = 16, > + .macrotile_mode = true, > +}; > + > static const struct qcom_ubwc_cfg_data sa8775p_data = { > .ubwc_enc_version = UBWC_4_0, > .ubwc_dec_version = UBWC_4_0, > @@ -225,6 +235,7 @@ static const struct of_device_id qcom_ubwc_configs[] __maybe_unused = { > { .compatible = "qcom,msm8998", .data = &msm8998_data }, > { .compatible = "qcom,qcm2290", .data = &qcm2290_data, }, > { .compatible = "qcom,qcm6490", .data = &sc7280_data, }, > + { .compatible = "qcom,qcs8300", .data = &qcs8300_data, }, You can just pass &sc8280xp_data instead, they're equivalent Konrad