mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Shiju Jose <shiju.jose@huawei.com>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Ani Sinha <anisinha@redhat.com>,
	Dongjiu Geng <gengdongjiu1@gmail.com>,
	linux-kernel@vger.kernel.org, qemu-arm@nongnu.org,
	qemu-devel@nongnu.org
Subject: [PATCH v5 11/16] acpi/ghes: don't crash QEMU if ghes GED is not found
Date: Wed,  4 Dec 2024 08:41:19 +0100	[thread overview]
Message-ID: <070b31b912eae803a47ab070f1ca747bd1e69e95.1733297707.git.mchehab+huawei@kernel.org> (raw)
In-Reply-To: <cover.1733297707.git.mchehab+huawei@kernel.org>

Make error handling within ghes_record_cper_errors() consistent,
i.e. instead abort just print a error in case ghes GED is not found.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
---
 hw/acpi/ghes.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c
index 414a4a1ee00e..2df5ddf68a13 100644
--- a/hw/acpi/ghes.c
+++ b/hw/acpi/ghes.c
@@ -371,7 +371,10 @@ void ghes_record_cper_errors(const void *cper, size_t len,
 
     acpi_ged_state = ACPI_GED(object_resolve_path_type("", TYPE_ACPI_GED,
                                                        NULL));
-    g_assert(acpi_ged_state);
+    if (!acpi_ged_state) {
+        error_setg(errp, "Can't find ACPI_GED object");
+        return;
+    }
     ags = &acpi_ged_state->ghes_state;
 
     start_addr = le64_to_cpu(ags->ghes_addr_le);
-- 
2.47.1


  parent reply	other threads:[~2024-12-04  7:42 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-04  7:41 [PATCH v5 00/16] Prepare GHES driver to support error injection Mauro Carvalho Chehab
2024-12-04  7:41 ` [PATCH v5 01/16] acpi/ghes: get rid of ACPI_HEST_SRC_ID_RESERVED Mauro Carvalho Chehab
2024-12-04  7:41 ` [PATCH v5 02/16] acpi/ghes: simplify acpi_ghes_record_errors() code Mauro Carvalho Chehab
2024-12-04  7:41 ` [PATCH v5 03/16] acpi/ghes: simplify the per-arch caller to build HEST table Mauro Carvalho Chehab
2024-12-04  7:41 ` [PATCH v5 04/16] acpi/ghes: better handle source_id and notification Mauro Carvalho Chehab
2024-12-04  7:41 ` [PATCH v5 05/16] acpi/ghes: Fix acpi_ghes_record_errors() argument Mauro Carvalho Chehab
2024-12-04  7:41 ` [PATCH v5 06/16] acpi/ghes: Remove a duplicated out of bounds check Mauro Carvalho Chehab
2024-12-04  7:41 ` [PATCH v5 07/16] acpi/ghes: Change the type for source_id Mauro Carvalho Chehab
2024-12-04  7:41 ` [PATCH v5 08/16] acpi/ghes: don't check if physical_address is not zero Mauro Carvalho Chehab
2024-12-04 13:12   ` Igor Mammedov
2024-12-09 10:15     ` Jonathan Cameron
2024-12-04  7:41 ` [PATCH v5 09/16] acpi/ghes: make the GHES record generation more generic Mauro Carvalho Chehab
2024-12-04 16:38   ` Igor Mammedov
2024-12-04  7:41 ` [PATCH v5 10/16] acpi/ghes: better name GHES memory error function Mauro Carvalho Chehab
2024-12-04 16:40   ` Igor Mammedov
2024-12-05  8:19     ` Mauro Carvalho Chehab
2024-12-04  7:41 ` Mauro Carvalho Chehab [this message]
2024-12-04  7:41 ` [PATCH v5 12/16] acpi/ghes: rename etc/hardware_error file macros Mauro Carvalho Chehab
2024-12-04  7:41 ` [PATCH v5 13/16] acpi/ghes: better name the offset of the hardware error firmware Mauro Carvalho Chehab
2024-12-04 16:37   ` Igor Mammedov
2024-12-05  7:59     ` Mauro Carvalho Chehab
2024-12-05  9:22       ` Igor Mammedov
2024-12-05 14:33         ` Mauro Carvalho Chehab
2024-12-04  7:41 ` [PATCH v5 14/16] acpi/ghes: move offset calculus to a separate function Mauro Carvalho Chehab
2024-12-04 16:42   ` Igor Mammedov
2024-12-04  7:41 ` [PATCH v5 15/16] acpi/ghes: Change ghes fill logic to work with only one source Mauro Carvalho Chehab
2024-12-04  7:41 ` [PATCH v5 16/16] docs: acpi_hest_ghes: fix documentation for CPER size Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=070b31b912eae803a47ab070f1ca747bd1e69e95.1733297707.git.mchehab+huawei@kernel.org \
    --to=mchehab+huawei@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=anisinha@redhat.com \
    --cc=gengdongjiu1@gmail.com \
    --cc=imammedo@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shiju.jose@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®