From: George Stark <gnstark@salutedevices.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Waiman Long <longman@redhat.com>
Cc: <peterz@infradead.org>, <mingo@redhat.com>, <will@kernel.org>,
<boqun.feng@gmail.com>, <jic23@kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel@salutedevices.com>
Subject: Re: [RFC PATCH 1/1] locking: introduce devm_mutex_init and devm_mutex_destroy
Date: Fri, 1 Dec 2023 16:43:35 +0300 [thread overview]
Message-ID: <070c174c-057a-46de-ae8e-836e9e20eceb@salutedevices.com> (raw)
In-Reply-To: <ZWYW4nDZNAO7NADj@smile.fi.intel.com>
Andy, Waiman
Thanks for the review.
I'll move the patch to the devm-helpers.h then.
On 11/28/23 19:35, Andy Shevchenko wrote:
> On Mon, Nov 27, 2023 at 08:55:18PM -0500, Waiman Long wrote:
>> On 11/27/23 19:09, George Stark wrote:
>
> ...
>
>> These APIs are specific to devres. I don't believe it is suitable to put
>> them into the generic mutex.h header file. All devres_* functions are
>> defined in include/linux/device.h which is probabably not included in
>> mutex.h. You may consider putting these APIs into device.h instead.
>
> +1. We have include/linux/devm-helpers.h.
>
--
Best regards
George
next prev parent reply other threads:[~2023-12-01 13:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 0:09 George Stark
2023-11-28 1:55 ` Waiman Long
2023-11-28 16:35 ` Andy Shevchenko
2023-12-01 13:43 ` George Stark [this message]
2023-11-28 16:45 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=070c174c-057a-46de-ae8e-836e9e20eceb@salutedevices.com \
--to=gnstark@salutedevices.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=boqun.feng@gmail.com \
--cc=jic23@kernel.org \
--cc=kernel@salutedevices.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®