From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B447031F985 for ; Tue, 18 Aug 2026 10:08:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787047724; cv=none; b=C86i4+6OMyRKBhvKBp8QHhaQkkD+xLslPI4VNKuNDuS7Pw9HZ6MCNmgPLec2kibDfLx7oAVXJ85pGQFtoHSBFBf1OUgfCTmADxCGcfyvPZZgKD5UCk/Minu1aQC9kJonjc6EEq8Agb0HhCUim0L+IkIlaw9i1beuZtqxwM3GRzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787047724; c=relaxed/simple; bh=QfiBAIQo84wvhlp4PSzKS5oAyVZnF+vu+rXcqOtSjsg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XiNAtiVrI79ujIzgebiboHW2YiqJd4yWV7V8ZQp3/LyEGoHWXYIL/SjGbFlry7t2vcj15s4/++vfZOeTAQp/z6GasJKiyg8jGQ2KKL7lSSmdv+urSzDpEaIUEZ7s9kIzCUwN2A7lGQuXfKoWNeJukQCuuBvK930GWUeN5TBQIeE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Wo14ffHr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=er+k9kmq; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Wo14ffHr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="er+k9kmq" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67I8BKYe547275 for ; Tue, 18 Aug 2026 10:08:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4zX7BztKtXi11cLzAfcZ9hIjR8IT6XfTvfH3alw4a2I=; b=Wo14ffHrSEJu6/9W Zt5LCGEjhuvvj+5polNFsavEnvRSWdMip7Qgfu7oPhRJVNEgx92eXusAEVpv2Vm7 aXe0MADRBEQ4SpibpuvomQ8WlbTiiAsfcVcniw5oSH2XmsZyG9C8KaIZyjlfiY2y mbzrsyKT3RJbnuFm0JAnIUWLApZ2oUUA1jxt5nAmgzAsBZUi4IIP9H66QDvbboGo fagV7YwE0kc5/spJO4FDYgC2ce610cLxJUAddqM6lbiG9/h9G3r1cUbKCnlZKXAM UVG2uO/DnQYF6FdxHCyqhumd7INOT9Jks5LX5+ROyZIZzp0jVCD1e7RLmSdmCQQM Ut9bNg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4g2p1evy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Aug 2026 10:08:40 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-93495488976so117646385a.3 for ; Tue, 18 Aug 2026 03:08:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787047720; x=1787652520; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4zX7BztKtXi11cLzAfcZ9hIjR8IT6XfTvfH3alw4a2I=; b=er+k9kmqG8jp24X4Px4Xt1BpteUOkm2nJyryCb8DePbRr7Hjpbx52pqco4DF4+jHbH dngNr9RMUl7sq6RyNGDJQ1HSPShH2Xy1b5Z4gMZ91lYNujiEdt/h79kxe9ucfxXLl7yh jMLt93fUgD2YmbIYFMJggd0XFWLw+VqGBKuCLkiwCUNqgMsuB4LPu/yLtlGiNXle16ON 1N+74I/q8ZeKFNCMbFuUxyM7FHXAps7Evu78QUYYRIbs9m8f0y/VCNxEXFDYJC5lM3nI /RGeIpb2x3XCW8Pfx4CtfPGB/nO/1PR0r/JUusUiGFtFnZANsGL4+viIYoLuXT9YemfI YLKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787047720; x=1787652520; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4zX7BztKtXi11cLzAfcZ9hIjR8IT6XfTvfH3alw4a2I=; b=rsAsWDnNpkCviXQLW+qzeW3g6kmgFtgFC6wSFYCmPa3OGXdKElkYZN2zxJvXZpxsKa K/2dSBWXJBNs+C6BRThFjN9ISfeUALI50hC9FKQYpCb8ukM6zVi3408fy1Ksf6rkQbtL kg23NiOjDcf7zbjeCCp1TxMlCteODxvZgA11X2IxLHo5kOKvX0AdivHag1YUuMq3nk6e PzrnYl7rJhPihLhyRWU9aLijXMQRoWezqz3vGig7WV2a5Gcn44njB5ZAGuZXQSG2HTUI 0xz5TYKFN/KhrqqdQJs/MtmhMlXx33VonCEhwq2Fg7yBdMnOu9i3JVBwlHm8Rbpo5gl2 LjJw== X-Forwarded-Encrypted: i=1; AHgh+RrskzZhpo5+gwSXXz7wPYBDT2R69jQHvgsQzDRQgPL+yN/9dWXLt4qGkvn1jAKxY9xVcUtjscnF1uLONSQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzH+W2MzTUD8e6bPb7IwvVvgcDm9DwywyD29AH/GCjFSXj24Kzc 5vLO9ZEIm+ZcCi3cpZMtbYa16A3QiBsZ9mmmUBNpzu1RqMlzhqkazYQQPQaAwwPXltJV8cVMLwQ Vj0WC6TJjXfOo0h3fQxMcyYAirVeIYfvZ2mjhMNe4lz0z67bUkX9v7svkI8+kVc8+tq8= X-Gm-Gg: AR+sD12MiqqA72plyNYmP1in81S/+2JN96iWnqa7f9dk06z1Rbt/JEA7iiUr7WFTGRQ tE4HQKHuT+2GCWWsYk20Mw//Kxibj/6LsuBY5JK2kPEBIMWDeHMrNbr5CllsPMS5t/zVKLzqg+Y 4pjjGXMm2TpDmjUtB6KjikXMqPw8MN7s+CXBI78pV0oCepOwtM4jYwuEt2wUfQBCYdIbiSaDIYV iXX93XrpKxWW1YBQrGH3TiK667kLzbG7qnqSUl0I5+Y2iVZYJVOkFiTT+d6gHuyY6R6Tx0QziU0 3g3M5sfF4gh49O++AmBMWh2xyKoDpyr4igAsi5j2h3KrcCE6ercr6knhZOEnHtFJAFvSx4arcTE X1NPsG/XqMlU+Okdl5YuO/fYr X-Received: by 2002:a05:620a:6846:b0:92e:5272:4e3e with SMTP id af79cd13be357-936d1f0a69cmr2252169485a.0.1787047719989; Tue, 18 Aug 2026 03:08:39 -0700 (PDT) X-Received: by 2002:a05:620a:6846:b0:92e:5272:4e3e with SMTP id af79cd13be357-936d1f0a69cmr2252164385a.0.1787047719529; Tue, 18 Aug 2026 03:08:39 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2185bc60a2sm126710566b.56.2026.08.18.03.08.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Aug 2026 03:08:38 -0700 (PDT) Message-ID: <070e30fb-a9c5-4685-8185-a5f19ed13693@oss.qualcomm.com> Date: Tue, 18 Aug 2026 12:08:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/10] usb: chipidea: msm: do not force the TX FIFO idle on HSIC instances To: Dmitry Baryshkov , Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Xu Yang , Peng Fan , Vinod Koul , Neil Armstrong , Peter Chen , Pavankumar Kondeti , Stephen Boyd , Konrad Dybcio Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, Greg Kroah-Hartman , Peter Chen References: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> <20260810-msm8974-usb-hsic-v1-7-e5f93ea76ffa@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260810-msm8974-usb-hsic-v1-7-e5f93ea76ffa@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: n_afmeeT7Ve0b8_z_fsftYbDO-8hzgZ8 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE4MDA3MyBTYWx0ZWRfX+g5aclBkO4Ww kyezv0js4QZXO61A1Wu9wIip6y/wadXanEnZmlm+cvLtuRNJoUVujqfcpHKKOSfkpxA/+wCVfiI hjlW9oaunD1dq1rmnJTY2/jOCa7dRqs= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE4MDA3MyBTYWx0ZWRfX0n+6lwlmbgH7 5s6uJOofbS6kjmmoKz7WXYmFFiN0EZJZBSGTxT1TRFZEWol/M8hS8mMW17WSNefMsS0GhusAO6R rhGVK6hMNT3HX4zx+Rvn81aDicwcbHNmuyDGjmLf31dC4eAuU6bhn3uvtU39moCt08bjsCuEDLW u9WdsbNC8Vz+ZZ7XZvjU2bXKxpsQU9Xc2dGifog+au7Bf8VciKjSlhYtsEBpFVO/MzeRsY6P26u APG+22vpa14/jBaS4PyXAPtECWut3yGHwXgeESiY6J/DwqaFVrtiVI8idVrPYuzR4zk4cae1c5o y40gu/YwA7BSEhTo3VALjOnhAqINLWfkNk4QwfgYtN2/cWpzICh4Ffmq7oMpRooxL0VHU/dwVlc vn0Yh7PXH5ssbH2biq7Se+hHMIqpkqUhkOsc61qWmaUpk2kIVl4c+rvZ42UPuxooRUeVAWj01wM fZRYfyMTq1uppdct/7g== X-Proofpoint-ORIG-GUID: n_afmeeT7Ve0b8_z_fsftYbDO-8hzgZ8 X-Authority-Analysis: v=2.4 cv=bfRbluPB c=1 sm=1 tr=0 ts=6a842f28 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=rJk912bZzWDh8y19x2MA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-17_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 malwarescore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 bulkscore=0 spamscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608180073 On 8/10/26 5:42 PM, Dmitry Baryshkov wrote: > The controller reset handler unconditionally clears > GENCONFIG[TXFIFO_IDLE_FORCE_DIS] as a workaround for an RX buffer > collision issue. The vendor HSIC host driver never applies this > workaround on the HSIC instances and leaves the bit at its power-on > default (set), so clearing it makes the HSIC instance diverge from the > known-working configuration. > > Skip the workaround for HSIC instances, like the neighbouring > GENCONFIG_2 write already does. > > Fixes: 47654a162081 ("usb: chipidea: msm: Restore wrapper settings after reset") > Assisted-by: Claude:claude-fable-5 > Signed-off-by: Dmitry Baryshkov > --- > drivers/usb/chipidea/ci_hdrc_msm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c > index 9a9410a814e5..69be194f8e27 100644 > --- a/drivers/usb/chipidea/ci_hdrc_msm.c > +++ b/drivers/usb/chipidea/ci_hdrc_msm.c > @@ -108,8 +108,9 @@ static int ci_hdrc_msm_notify_event(struct ci_hdrc *ci, unsigned event) > hw_write_id_reg(ci, HS_PHY_AHB_MODE, 0xffffffff, 0x8); > > /* workaround for rx buffer collision issue */ > - hw_write_id_reg(ci, HS_PHY_GENCONFIG, > - HS_PHY_TXFIFO_IDLE_FORCE_DIS, 0); > + if (!msm_ci->hsic) > + hw_write_id_reg(ci, HS_PHY_GENCONFIG, > + HS_PHY_TXFIFO_IDLE_FORCE_DIS, 0); This patch seems not to match downstream, msm-3.10 sets it in both hsic and non-hsic drivers Konrad