From: Shijie Huang <shijie@amperemail.onmicrosoft.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Huang Shijie <shijie@os.amperecomputing.com>,
patches@amperecomputing.com, cl@linux.com,
yang@os.amperecomputing.com, peterz@infradead.org,
jpoimboe@kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH resend ] tracepoint: Print the function symbol when tracepoint_debug is set
Date: Thu, 6 Mar 2025 10:26:35 +0800 [thread overview]
Message-ID: <070e4579-bbe3-48ef-9e60-1daf51df4b78@amperemail.onmicrosoft.com> (raw)
In-Reply-To: <20250305104749.15e57b19@gandalf.local.home>
On 2025/3/5 23:47, Steven Rostedt wrote:
> On Wed, 5 Mar 2025 08:53:43 -0500
> Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
>
>> On 2025-03-04 20:55, Huang Shijie wrote:
>>> When tracepoint_debug is set, we may get the output in kernel log:
>>> [ 380.013843] Probe 0 : 00000000f0d68cda
>>>
>>> It is not readable, so change to print the function symbol.
>>> After this patch, the output may becomes:
>>> [ 54.930567] Probe 0 : perf_trace_sched_wakeup_template
>> What would it print if the address is corrupted ?
>>
>> Perhaps we could do like the backtrace code and print e.g.
>>
>> [<00000000f0d68cda>] perf_trace_sched_wakeup_template+0xNN/0xMM
>>
>> ?
>>
>> I don't care about the actual layout, but removing the address
>> from the formatted output appears to be removing useful data
>> in debug situations.
>>
> Perhaps this can use "%pS" which shows both the function entry and the
okay, I can change it to use "%pS" in next version if we think it is
good enough:
[ 55.225555] Probe 0 : perf_trace_sched_wakeup_template+0x0/0x20
Thanks
Huang Shijie
next prev parent reply other threads:[~2025-03-06 2:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 1:55 Huang Shijie
2025-03-05 13:53 ` Mathieu Desnoyers
2025-03-05 15:47 ` Steven Rostedt
2025-03-06 2:26 ` Shijie Huang [this message]
2025-03-06 3:37 ` Shijie Huang
2025-03-06 15:13 ` Steven Rostedt
2025-03-06 16:37 ` Mathieu Desnoyers
2025-03-07 3:03 ` Shijie Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=070e4579-bbe3-48ef-9e60-1daf51df4b78@amperemail.onmicrosoft.com \
--to=shijie@amperemail.onmicrosoft.com \
--cc=cl@linux.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=patches@amperecomputing.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shijie@os.amperecomputing.com \
--cc=yang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®