From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C27E53A4520 for ; Fri, 24 Apr 2026 11:09:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777028953; cv=none; b=BT5EYYT+AxtWGdRFVrJgkSs5l8PxZii9+kJvezfuZp3hLeP01kuCFQL4LiNsZZGRJrEgCZetsb38eTcVieDdTW9gIkJ7hkfG/xuyNEoluFcsvjOTDNjUNzVufWGZ2XHE50SyozQG4tpEa1tSkgmLxvm9769EhYMDM5ei0JZ/8/s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777028953; c=relaxed/simple; bh=LaFSKdn3fcuxshjr7YM6z36LvDcB10Ec1GAh1mim+e8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NZbLgngHTOK/3SZCfCy3Zx46cu7p+teviXojmkV+u/aLj/e2PADttr5RkHiK+AI5Ja+RADz0lMIRUxZCTXexqUnCeuYA1+1k5mfXLcR407iF42HWzvXLiWEZDG9aCB+yvb7QM86//iKU60udjRB96PZN9ifDrboJHrVIlpiV3Z4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hv44QqOF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WSNNMIx0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hv44QqOF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WSNNMIx0" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63O9W2QP756614 for ; Fri, 24 Apr 2026 11:09:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OsNC8a3XtqDbUnvN0mfJ7jfUPjgjexIOw63gLaAHn08=; b=hv44QqOFlq7cPa2c tbY/CLH3gu6N1Gbt91XSS9NzKJ9+9Ifwf/adkDnelUlzqJ8uQuHMgK3oV3uZX9nV kKpVznRLjqjkUmPsuIk68RJflsmY1fGl3PQnS0WdLrtGZQlgjwO6SzH4ap7LmDtq OqEcV7h7Ji8ATHtzuUYLOOCOxy7V9J+YdAahaBVmMWchUY5nU0qdGmss2ZKf/xGK CSh1oR/G7lyS048kTp2FMEujrg3Awcf1aaRnEYIAyGRMwwzB4AFGhhwtQttAje5P 5IFIsALazp9kDtpsen46kG7JLoj1nKrkINVJPzw6cjxa7E3SUAT4/VaJpUa4T+c8 qkSu4w== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dqr4bkq99-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Apr 2026 11:09:09 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50e429ba4dfso12120891cf.3 for ; Fri, 24 Apr 2026 04:09:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777028948; x=1777633748; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OsNC8a3XtqDbUnvN0mfJ7jfUPjgjexIOw63gLaAHn08=; b=WSNNMIx097wX0kzNdzpQx9sgLk+yr/4SIhcG9mr3R5n/BKg5n2cM8o59IgtXvjtatp Z/9cOEINQqMutmVZR8ko9dht7KoOS3AJkccBWX92OH2KJfqjc1TB+StlRYgGb71IdoK6 vnzsRwET7/jHrMucxsSG844IghTOOEYf987xUkc5qqBErIr7JlefWClWa+vP7WXKsmaq oVl35MRQkJiv0l4miFgJmObj7fkqoJcfExucgSa1AdKMPMV/epSenzk1pHdJzA/2pdcs ZXQOqOBWFkCvKJnC6j1Ij481qjcaVxyNDhlKRKpctMYpwg6bIkI/SZ6ph0yAr1FJc4yV VIdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777028948; x=1777633748; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OsNC8a3XtqDbUnvN0mfJ7jfUPjgjexIOw63gLaAHn08=; b=ZuqhPchol5SaZ6aHTCfDBLLJyD31BZjjWBHpYR2AEaL0ZGJ7zr0KQwQ2ibaxbbx9sk 8j7Hz6FYzGb3tdF/Bf7DrMefUcfpDoelbN9CHvOfH0qlIUEWY1m1l88Iw7vwJ/okooVJ lhKYmHLx8mmUIpdmmejZ/GH5LYFmeUuq5ad7OgVe5qF5mSDWsrvxu7YbOyeQRk/qm0jz zJw+nKbnNNuJzElIoN/l30GOMzpQzaqPH11PennUYeC4tVXwHtacjEky4w35JgWxAOVL DtUMRp4vQh36VEJdLU1RKIdEVdpMlbRJMJQxCh7H7ABuwbWRqbErGYiSIfyXJhcBykDn EMGw== X-Forwarded-Encrypted: i=1; AFNElJ9qfEWbjigvg6NKkgy0RM3AIjRbSCca4TdbvWnvj+GG/YiaHG15bbLXeoBG01w34D3dbTNTj+h+tuOYDvE=@vger.kernel.org X-Gm-Message-State: AOJu0YwWXZmU/h6I18bMAVtDZagj9rt6m7tB4cGOJ3nxaPU0W3YKW7XJ unU1GXI5igo3o8gDbhegvNjCeYCj5mNI4sN2QTRCZVm5XRm/GR3xXVhgcbjYsyo96rSRJC6SNpA k4G0SQ8aJPuEumSEpEq1PtJVwzvVXfHeTPfe4OfW0vlFyMjO0Hjyj+QyWZSWVbUPtxUU= X-Gm-Gg: AeBDieu3TV0RvqVhZj1/gJEM45UBT40oGZuMV+ojkA3PzMSmBmio2xwy+YSMIp9w3ML psfonRJUUK52z4NQupjuBH/QCqSydlCWuJVbUH34Xcy9acvoou1j7KAI/ELnAIR1HU+/xwgw1oq ny2nEioY8euKSGJPVKFgNMvY/Mf6WqbEaQBHiuQ94Ya9GVG2LmI6tZeQJQWpYk600qOoYh/wEh4 4heUAkVAUI4NCqldJbI8zwvfjGzau/7pmaPJld3m1NyLWswNFHXBLrE9zYXrS3gOkcfzifseab3 tE1S/gZ4EHQcgkVUUtgvHDV6SXUI4lBPuKDWcxvRpoRA4tNq3pXB3+izGxSlY21CJIVl8IeLg+n /vyJo8EZq8+cUBq/FdY07trq+zf0ByMsWu/hCRVmfkqR9zkBqnQhR/ySdCfPl/WRriaQLKTqt1B yDsCZLP7OTGxOYrw== X-Received: by 2002:a05:622a:4cce:b0:509:2b5a:808 with SMTP id d75a77b69052e-50e3683910cmr290921911cf.2.1777028948454; Fri, 24 Apr 2026 04:09:08 -0700 (PDT) X-Received: by 2002:a05:622a:4cce:b0:509:2b5a:808 with SMTP id d75a77b69052e-50e3683910cmr290921581cf.2.1777028948047; Fri, 24 Apr 2026 04:09:08 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba4517ef3d4sm760703966b.17.2026.04.24.04.09.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Apr 2026 04:09:07 -0700 (PDT) Message-ID: <0710caaf-ec73-4c4c-b6cb-7fe716724f4b@oss.qualcomm.com> Date: Fri, 24 Apr 2026 13:09:04 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: glymur: Drop fake PCIe phy 3B To: Krzysztof Kozlowski , Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260420133616.88740-2-krzysztof.kozlowski@oss.qualcomm.com> <5c1f7955-883f-4fa8-a0e5-513a987bd3a9@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <5c1f7955-883f-4fa8-a0e5-513a987bd3a9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI0MDEwNSBTYWx0ZWRfX8apkhNnS6x62 xLwJ9UoMAlXSFTKsu8WFlbcR3VBjQEVngDOufjp53n0AZ2TymLQfO74GF64Q4jLgsWcef8Nq3QS 7JDEdAU4FSQpB10irEXjUrIfpm44Rm7yNL+ED7ABgJfe8nyM4YqCVEyzYI/l9yTKcuFHnMCu6qa 7dZY09T3Iz2tqWkePGmke9cdawWL0nyuEnajUxzJGYMhcB62dnM6u2bw2pf21o2eSfgGWFmf3Y/ EaccDt74LExeI9DPgIatrcOCRr/Gzp0qZqRQDhiG09P92l/IRtyRW7YDWy/RXJ7MCgX7KlD63R+ b9v86ba29uQJj2GAybZGbfVmLQAd+pcHVyH1hH3GemR4HsiqqU26vU6/sWUOBHoufnJsDOdP+w6 INfAuen6c562peA/AKwmYw4CbexHtFt05IrO7hCSq7NRRdHzPKbESsAagp3GsnypSFbDn8uuM20 JZXkAUN5VOEhzlVyEOg== X-Authority-Analysis: v=2.4 cv=TtnWQjXh c=1 sm=1 tr=0 ts=69eb4f55 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=sAdhiuySH5Di72lTHokA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: uNBvo0yvZoReH2CIYgYWCRpLzyxwfo7L X-Proofpoint-GUID: uNBvo0yvZoReH2CIYgYWCRpLzyxwfo7L X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 malwarescore=0 clxscore=1015 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604240105 On 4/23/26 9:16 AM, Krzysztof Kozlowski wrote: > On 22/04/2026 22:08, Dmitry Baryshkov wrote: >> On Tue, Apr 21, 2026 at 08:41:14AM +0200, Krzysztof Kozlowski wrote: >>> On 20/04/2026 20:02, Dmitry Baryshkov wrote: >>>> On Mon, Apr 20, 2026 at 03:36:17PM +0200, Krzysztof Kozlowski wrote: >>>>> According to user manual / programming guide there is no separate PCIe >>>>> phy 3A and 3B, but one 8-lane QMP PCIe Gen5 PHY which consists of two >>>>> 4-lane blocks. This is also visible in memory map, where the 0xf00000 >>>>> is marked as the main block with additional sub blocks for each 4-lane >>>>> phys. >>>>> >>>>> Describing the sub phys without the rest is not correct from hardware >>>>> description, even if it works. >>>> >>>> Is this the case for the other bifurcated PHYs? >>>> >>> >>> There's more? Oh damn... >> >> In the previous generations. I think Hamoa had one. Any PHY with a name ending in -A or -B. That means: $ rg 'PCIE_.[AB]_' drivers/clk/qcom/ -l drivers/clk/qcom/gcc-x1e80100.c drivers/clk/qcom/gcc-glymur.c drivers/clk/qcom/gcc-sc8280xp.c And, quite predictably, some PHYs may not only bifurcate, but also tri- or quadfurcate (on Nord). > Ah, I did not check the others and there is little we can do there - > it's released DTS. This cannot be easily changed while keeping DTS > compatible with users, because probably two PHY nodes will be replaced > by one with different compatible. I think no one utilized the non-reference configuration of those PHYs in practice. Should a device like that come around though, we'll think about what to do then.. Konrad