From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94EE4C2D0A3 for ; Mon, 9 Nov 2020 07:52:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2819020853 for ; Mon, 9 Nov 2020 07:52:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="C5Ly9d20" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729690AbgKIHw3 (ORCPT ); Mon, 9 Nov 2020 02:52:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728038AbgKIHw2 (ORCPT ); Mon, 9 Nov 2020 02:52:28 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91F93C0613CF for ; Sun, 8 Nov 2020 23:52:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=DQp7Z8atBHTyupqZQXsiHfDtdq00mAq/dg+gPrxsabM=; b=C5Ly9d20rUqQLMssiKEQpyR9IJ fXb8BUn6LRAxyvNBhc9DyVlZ6MsgkNhp6GAshCYRt8EvKY0wIdtu1Y3q1+X3xaobvizCcmlc935Pq TvMCrhqPi9dIR1/p2A5fU/dDn/iCqGD1YVyV3ZFKoR1Co0QNIKrjrVCA13IsIZva4KJPmPPrr51x0 nMECXM46ForuD6xUcH5eZmWadnureyK9AQ6kwzfe3JlJqUoZ7hakKBWympNYpLm1tN4fC7WsIqRvW 66WWkv3SwHVh0/wgbCLHWM2LSbLfp2luvqb/FiUkQ61G7iPys0bDDlBXm9UZQ+/uk046rmg2BK7dH o6LcYBJw==; Received: from [2601:1c0:6280:3f0::a1cb] by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc1yL-00015P-BO; Mon, 09 Nov 2020 07:52:17 +0000 Subject: Re: [PATCH v2] mm/gup_test: GUP_TEST depends on DEBUG_FS To: John Hubbard , Barry Song , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: linuxarm@huawei.com, Ralph Campbell , John Garry References: <20201108083732.15336-1-song.bao.hua@hisilicon.com> From: Randy Dunlap Message-ID: <071150d8-9159-91c4-118d-b19c2bd785ea@infradead.org> Date: Sun, 8 Nov 2020 23:52:14 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/8/20 11:45 PM, John Hubbard wrote: > On 11/8/20 12:37 AM, Barry Song wrote: >> Without DEBUG_FS, all the code in gup_test becomes meaningless. For sure >> kernel provides debugfs stub while DEBUG_FS is disabled, but the point >> here is that GUP_TEST can do nothing without DEBUG_FS. >> >> Cc: John Hubbard >> Cc: Ralph Campbell >> Cc: Randy Dunlap >> Suggested-by: John Garry >> Signed-off-by: Barry Song >> --- >>   -v2: >>   add comment as a prompt to users as commented by John and Randy, thanks! >> >>   mm/Kconfig | 4 ++++ >>   1 file changed, 4 insertions(+) > > Thanks for suffering through a lot of discussion about this! > > Reviewed-by: John Hubbard > > > thanks, Acked-by: Randy Dunlap thanks. -- ~Randy