From: David Rientjes <rientjes@google.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Christoph Lameter <cl@linux.com>,
Peter Zijlstra <peterz@infradead.org>,
Pekka Enberg <penberg@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH] mm/slab: make __free(kfree) accept error pointers
Date: Sun, 28 Apr 2024 13:20:12 -0700 (PDT) [thread overview]
Message-ID: <07209fd5-f6c3-293a-4968-63a11c273ed6@google.com> (raw)
In-Reply-To: <285fee25-b447-47a1-9e00-3deb8f9af53e@moroto.mountain>
On Sun, 28 Apr 2024, Dan Carpenter wrote:
> Currently, if an automatically freed allocation is an error pointer that
> will lead to a crash. An example of this is in wm831x_gpio_dbg_show().
>
> 171 char *label __free(kfree) = gpiochip_dup_line_label(chip, i);
> 172 if (IS_ERR(label)) {
> 173 dev_err(wm831x->dev, "Failed to duplicate label\n");
> 174 continue;
> 175 }
>
> The auto clean up function should check for error pointers as well,
> otherwise we're going to keep hitting issues like this.
>
> Fixes: 54da6a092431 ("locking: Introduce __cleanup() based infrastructure")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: David Rientjes <rientjes@google.com>
next prev parent reply other threads:[~2024-04-28 20:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 14:26 Dan Carpenter
2024-04-28 20:20 ` David Rientjes [this message]
2024-04-29 3:03 ` Matthew Wilcox
2024-04-29 6:08 ` Dan Carpenter
2024-04-29 16:29 ` Christoph Lameter (Ampere)
2024-04-29 18:34 ` Matthew Wilcox
2024-04-30 12:09 ` Vlastimil Babka
2024-04-30 12:50 ` Dan Carpenter
2024-04-30 13:12 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07209fd5-f6c3-293a-4968-63a11c273ed6@google.com \
--to=rientjes@google.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=cl@linux.com \
--cc=dan.carpenter@linaro.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®