From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BF31A31 for ; Wed, 21 Aug 2024 19:44:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724269447; cv=none; b=KNPvDHnZ4zqpge+2vMjmhOEdEDXSBwMqmSPXSXy7hvqIVaw6JD7+CoD4eXhp4QSRa5CKmcdCtoXRDm1YtVdlvJPbMelnEtEWECtWsXK9hkdm0iuxAxg3IhmqoHk9I+/rjQhTkRZbSKoK7QG8t8vF6Dc+OZfIRbAUwaBJ3g6o0z4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724269447; c=relaxed/simple; bh=ArvKsggnJGPhOp+q0h9Mjxp3iUObKcvKOE2fcEWyoBI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QO3fnf3H1M2NlhZcfFbFvCACxwJAWqTgA2Kr6j3vrLv/l1mkEuAkRWhlEw/aF1/jmaxrg271fYFQhWONWpb278K5CI7LeymBWdYF5eKLmfCe6biX2FektVt+ielzMSEFaqgU34P5g7rsNtbs2kuaB6jpHchgYPcn1ZPvvZ+zgHg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jrCOumP9; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jrCOumP9" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a866d3ae692so2564966b.0 for ; Wed, 21 Aug 2024 12:44:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724269444; x=1724874244; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=X9ZixJ4L2M9QC9AJ9kc6Ub9a6W9rSCr1rc3nn+e6qsY=; b=jrCOumP9ErqryJveHvYXqoA40wchzQzwMaL9krXeFissAL/LAIcBqu5Vp+Cby93FNE 3GNl3wjWzoNa3kq8rAKiBdh3F7mFao+9Ue/iZQm+2Vbp5niUdSw3lCaLLaoza8I6oqDo nGn6jMWPV3qqu6hrPUyfMd/voWCiOQaJv5NEimpFhnbbcuk4ArwzWCFSONceTEgCX+wC XsgUAic5CGF8UhgxfB7cTOxB36azdfzp8GDnV7gGmFb33y7HyzTxjHg4xuPHGPBOg05r nCRYOPlI5POrfFfO8ufKLEDeEbdMtoMtOo9KDi91amAHlkozHu/Wxj+BMqA4Y7+oLD/s TYKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724269444; x=1724874244; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X9ZixJ4L2M9QC9AJ9kc6Ub9a6W9rSCr1rc3nn+e6qsY=; b=iQJurGEOtyEmY1dQzulQpxkPAXEZHYlIt0BhKSqRK+cEJ+rhfl/56dRw/nYGWAPkJD A6OTzSKbul5A6LrQ7pUHNI47N5SJX5Slc2l0rWCb0I4jA3I7j2rrmhus/gNQse3j7W3Q R0uSMj2/c792TWuxIfuWoaIOlzm/57AWUS1d8YU2gToq3kx49XT4LG0782ERgzB/lCY+ Ndxro90cTvFUxzV6CgpLz6g0GQvkp677iI0BP4xJevNew7rg7Jl1qH1LJIcLd95ev1uZ yFu/d3yjuqQE/Np+owOGOcBejyluzb+4FFP72k6XinKHyP24cBUujQMU8AG2RkX5aDap vQdg== X-Forwarded-Encrypted: i=1; AJvYcCVrmFqRGaPo4yIiC4ykfJMn0p/XJ1iuADUzW6FVU1M6xekjcKShACkvx0EfUPD77EPV/NrcXOpClyTOfnA=@vger.kernel.org X-Gm-Message-State: AOJu0YxCxAaf+4wenwcheoaKferdFXQUqlXXF9+f1y1ewErP7Dh1riLb QkR6hPdVub2uNJsurBm5X1VnMvoZ7n4smngzthAJ4AgSPuJF7UVn X-Google-Smtp-Source: AGHT+IFOxSJhs1ice/CJPbgFCF94dLFI9ejDF3YEagA8yT7YH2ObM/obuHhjkcaCKC7p5IlP6W/YfA== X-Received: by 2002:a05:6402:4302:b0:5be:f0dd:d501 with SMTP id 4fb4d7f45d1cf-5bf1f272d3fmr3444803a12.27.1724269443660; Wed, 21 Aug 2024 12:44:03 -0700 (PDT) Received: from ?IPV6:2003:c7:8f2a:8501:ea5e:6daf:6c3:197a? (p200300c78f2a8501ea5e6daf06c3197a.dip0.t-ipconnect.de. [2003:c7:8f2a:8501:ea5e:6daf:6c3:197a]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5bebbe7f3f6sm8424267a12.66.2024.08.21.12.44.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Aug 2024 12:44:03 -0700 (PDT) Message-ID: <072156e5-575c-491c-b323-d4de682ea84a@gmail.com> Date: Wed, 21 Aug 2024 21:44:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] staging: rtl8723bs: add spaces arround operators To: =?UTF-8?Q?Guillaume_Lef=C3=A8vre-Crim=C3=A9?= , gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20240816183756.59250-1-guillaume.lefevre.crime@netc.fr> Content-Language: en-US From: Philipp Hortmann In-Reply-To: <20240816183756.59250-1-guillaume.lefevre.crime@netc.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 8/16/24 20:37, Guillaume Lefèvre-Crimé wrote: > Adhere to Linux kernel coding style. > Reported by checkpath : > CHECK: spaces preferred around that '&' (ctx:VxV) > > Signed-off-by: Guillaume Lefèvre-Crimé > --- > drivers/staging/rtl8723bs/core/rtw_efuse.c | 54 +++++++++++----------- > 1 file changed, 27 insertions(+), 27 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c > index eb848f9bbf2c..89acb6f290cc 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c > +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c > @@ -38,7 +38,7 @@ Efuse_Read1ByteFromFakeContent(u16 Offset, u8 *Value) > if (fakeEfuseBank == 0) > *Value = fakeEfuseContent[Offset]; > else > - *Value = fakeBTEfuseContent[fakeEfuseBank-1][Offset]; > + *Value = fakeBTEfuseContent[fakeEfuseBank - 1][Offset]; > return true; > } > > @@ -50,7 +50,7 @@ Efuse_Write1ByteToFakeContent(u16 Offset, u8 Value) > if (fakeEfuseBank == 0) > fakeEfuseContent[Offset] = Value; > else > - fakeBTEfuseContent[fakeEfuseBank-1][Offset] = Value; > + fakeBTEfuseContent[fakeEfuseBank - 1][Offset] = Value; > return true; > } > > @@ -206,21 +206,21 @@ u16 Address) > if (Address < contentLen) {/* E-fuse 512Byte */ > /* Write E-fuse Register address bit0~7 */ > temp = Address & 0xFF; > - rtw_write8(Adapter, EFUSE_CTRL+1, temp); > - Bytetemp = rtw_read8(Adapter, EFUSE_CTRL+2); > + rtw_write8(Adapter, EFUSE_CTRL + 1, temp); > + Bytetemp = rtw_read8(Adapter, EFUSE_CTRL + 2); > /* Write E-fuse Register address bit8~9 */ > temp = ((Address >> 8) & 0x03) | (Bytetemp & 0xFC); > - rtw_write8(Adapter, EFUSE_CTRL+2, temp); > + rtw_write8(Adapter, EFUSE_CTRL + 2, temp); > > /* Write 0x30[31]= 0 */ > - Bytetemp = rtw_read8(Adapter, EFUSE_CTRL+3); > + Bytetemp = rtw_read8(Adapter, EFUSE_CTRL + 3); > temp = Bytetemp & 0x7F; > - rtw_write8(Adapter, EFUSE_CTRL+3, temp); > + rtw_write8(Adapter, EFUSE_CTRL + 3, temp); > > /* Wait Write-ready (0x30[31]= 1) */ > - Bytetemp = rtw_read8(Adapter, EFUSE_CTRL+3); > + Bytetemp = rtw_read8(Adapter, EFUSE_CTRL + 3); > while (!(Bytetemp & 0x80)) { > - Bytetemp = rtw_read8(Adapter, EFUSE_CTRL+3); > + Bytetemp = rtw_read8(Adapter, EFUSE_CTRL + 3); > k++; > if (k == 1000) > break; > @@ -253,16 +253,16 @@ bool bPseudoTest) > > /* -----------------e-fuse reg ctrl --------------------------------- */ > /* address */ > - rtw_write8(padapter, EFUSE_CTRL+1, (u8)(addr&0xff)); > - rtw_write8(padapter, EFUSE_CTRL+2, ((u8)((addr>>8) & 0x03)) | > - (rtw_read8(padapter, EFUSE_CTRL+2)&0xFC)); > + rtw_write8(padapter, EFUSE_CTRL + 1, (u8)(addr & 0xff)); > + rtw_write8(padapter, EFUSE_CTRL + 2, ((u8)((addr >> 8) & 0x03)) | > + (rtw_read8(padapter, EFUSE_CTRL + 2) & 0xFC)); > > /* rtw_write8(padapter, EFUSE_CTRL+3, 0x72); read cmd */ > /* Write bit 32 0 */ > - readbyte = rtw_read8(padapter, EFUSE_CTRL+3); > - rtw_write8(padapter, EFUSE_CTRL+3, (readbyte & 0x7f)); > + readbyte = rtw_read8(padapter, EFUSE_CTRL + 3); > + rtw_write8(padapter, EFUSE_CTRL + 3, (readbyte & 0x7f)); > > - while (!(0x80 & rtw_read8(padapter, EFUSE_CTRL+3)) && (tmpidx < 1000)) { > + while (!(0x80 & rtw_read8(padapter, EFUSE_CTRL + 3)) && (tmpidx < 1000)) { > mdelay(1); > tmpidx++; > } > @@ -293,9 +293,9 @@ u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data, bool bPseudoT > > > efuseValue = rtw_read32(padapter, EFUSE_CTRL); > - efuseValue |= (BIT21|BIT31); > + efuseValue |= (BIT21 | BIT31); > efuseValue &= ~(0x3FFFF); > - efuseValue |= ((addr<<8 | data) & 0x3FFFF); > + efuseValue |= ((addr << 8 | data) & 0x3FFFF); > > > /* <20130227, Kordan> 8192E MP chip A-cut had better not set 0x34[11] until B-Cut. */ > @@ -304,9 +304,9 @@ u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data, bool bPseudoT > /* 0x34[11]: SW force PGMEN input of efuse to high. (for the bank selected by 0x34[9:8]) */ > /* PHY_SetMacReg(padapter, 0x34, BIT11, 1); */ > rtw_write16(padapter, 0x34, rtw_read16(padapter, 0x34) | (BIT11)); > - rtw_write32(padapter, EFUSE_CTRL, 0x90600000|((addr<<8 | data))); > + rtw_write32(padapter, EFUSE_CTRL, 0x90600000 | ((addr << 8 | data))); > > - while ((0x80 & rtw_read8(padapter, EFUSE_CTRL+3)) && (tmpidx < 100)) { > + while ((0x80 & rtw_read8(padapter, EFUSE_CTRL + 3)) && (tmpidx < 100)) { > mdelay(1); > tmpidx++; > } > @@ -365,19 +365,19 @@ efuse_WordEnableDataRead(u8 word_en, > u8 *sourdata, > u8 *targetdata) > { > - if (!(word_en&BIT(0))) { > + if (!(word_en & BIT(0))) { > targetdata[0] = sourdata[0]; > targetdata[1] = sourdata[1]; > } > - if (!(word_en&BIT(1))) { > + if (!(word_en & BIT(1))) { > targetdata[2] = sourdata[2]; > targetdata[3] = sourdata[3]; > } > - if (!(word_en&BIT(2))) { > + if (!(word_en & BIT(2))) { > targetdata[4] = sourdata[4]; > targetdata[5] = sourdata[5]; > } > - if (!(word_en&BIT(3))) { > + if (!(word_en & BIT(3))) { > targetdata[6] = sourdata[6]; > targetdata[7] = sourdata[7]; > } > @@ -463,7 +463,7 @@ static void efuse_ShadowRead2Byte(struct adapter *padapter, u16 Offset, u16 *Val > struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter); > > *Value = pEEPROM->efuse_eeprom_data[Offset]; > - *Value |= pEEPROM->efuse_eeprom_data[Offset+1]<<8; > + *Value |= pEEPROM->efuse_eeprom_data[Offset + 1] << 8; > > } /* EFUSE_ShadowRead2Byte */ > > @@ -473,9 +473,9 @@ static void efuse_ShadowRead4Byte(struct adapter *padapter, u16 Offset, u32 *Val > struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter); > > *Value = pEEPROM->efuse_eeprom_data[Offset]; > - *Value |= pEEPROM->efuse_eeprom_data[Offset+1]<<8; > - *Value |= pEEPROM->efuse_eeprom_data[Offset+2]<<16; > - *Value |= pEEPROM->efuse_eeprom_data[Offset+3]<<24; > + *Value |= pEEPROM->efuse_eeprom_data[Offset + 1] << 8; > + *Value |= pEEPROM->efuse_eeprom_data[Offset + 2] << 16; > + *Value |= pEEPROM->efuse_eeprom_data[Offset + 3] << 24; > > } /* efuse_ShadowRead4Byte */ > Tested-by: Philipp Hortmann