From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DD911C3C1D for ; Sat, 1 Feb 2025 16:17:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738426681; cv=none; b=BO7GbVzavLNjYcxxFXh4MhCker7tbmwT+I8q/uZtfmvqW7iHr0+V+Ubyv7UdY1wh/xkz1bZzDZu6G+UXWlu1YxaxCREiBfXatZAUpXPb1t2A8SY/hAouUAq84MJehiHVHp2HEPuCZTCGT8mIQfXLZqCwLvb2ZDWj5zRbagOWf+0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738426681; c=relaxed/simple; bh=xvd2NFP5FB+CZsHk6V20vbHOvYWsNy5uLFVc9vcIMRQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cNCO3mrU8LYIKAMz2fpmW/Jq+8qCR3UCR8OXN+ZunExvh5mcBlH3PHe5IhIe1hWlq9ZUTdOadrPIRm/Oio93GzenNBNirDO5Cb64aaSBvNYYwaoeS2hAgvqRUhikNEpLD/AawvIJu2AdU7bf0fUzJrnTgXdgOY6GcXuqOm1OLis= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=KirQZXW9; arc=none smtp.client-ip=209.85.210.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="KirQZXW9" Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-71e1e051e50so827740a34.0 for ; Sat, 01 Feb 2025 08:17:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738426679; x=1739031479; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xa6g2oNfuacwFq4nVjdCRSL/cRrTFR4jPo2z/+uIvHw=; b=KirQZXW9fhrVxIBkbls4JrCj4qPKGc4b7sPnylfDShm6gQAjfdZm0ICV4RxNMOIFQX YI9k+wKeslFceFY2M3CpcV6DYrzg/UN/19czNbKbiBVWCdjl3MFKvuIi6SVs9c9PNtgm N3sCJxs6r7hc83TdC6K5GiBfEGOeYoGw4++nHh+fvCgiezRFuDF6G3WLMnFEPM0ix+1S BF4ZLGrRvM7vXcORDTWdhElEVIoi67I6+mIMFSdFFe6ZuTa0rD2xR8TjlzxnYeQNX0Vv KBZejBh12HHi91L6j5xvJhnkfXsp4owYc3rXS1CfOdFQmHw6s7mdmpF41xpEFLn9NbNl ttmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738426679; x=1739031479; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xa6g2oNfuacwFq4nVjdCRSL/cRrTFR4jPo2z/+uIvHw=; b=bG696PzVUtHk1zn2hUWsB4Vvvvtq2KZkf5CAlIu/oaX6/Mui4eDDxcjRLngdO+ilMu mhliBQDR5vBiu8cWWQPHaAPKiDZUTCLzFyn4yx3+uDoMlQJtQMg4JVLGb9//DwDDSwwY zdpY4Pd+decPcc/Wdlpam7ElU+6erfrINvMD2a43jHlgXlnYatmM60KhcIqSKUHTH81z 1aMfPDm5ax6++zEaskORXXvyYMM9i/93xlWL8T+3gW2zYHNQTUm02UOKX+ziWpI3U8gD Gs0UAcKZZO2OMtoyliu42E1lkd8mBkbMKBvhnGa7TyGSWBa744k8/c8R6m0AYI3B64oj BhIg== X-Forwarded-Encrypted: i=1; AJvYcCWeet18f79Uvw3xGgcLly8+CrOlpAlE9uqMg/9jnIfHsTtuSpiGEp+sZeMwjverYx1tRi81i/wBv6uRSSY=@vger.kernel.org X-Gm-Message-State: AOJu0YwW4TrWNTcE842g5mO/rppohMofJfZEjcc0oKGbYLxiH1a/z7hK PWGErZcxR5DRjJE7XLeihjHUpIFEghAVl/pobEhOKd4YgQ+WkXQBbz/gnyr4aK0= X-Gm-Gg: ASbGncvggodp4Xt0kzsC/Sis/TxygzImNnynf3U389d7Wi2F+rZFzUN+JX1hJJSyeV9 Cdjuy1hY2ECCStUS3CoVrWzNidq3f7c4C5vecT0d7Bu8Ssp9YlkbUVbf8yn57xuqIGxeEUxC5f+ O4V5fSJ/XTXQ4nt9Tri2ygkNddYhSexh7pNvaMr6KY92Mxr219Qvqfai7B7dQK0UonbrUoG3Oka OOqNO6ZQgk2Gok2iaGfu9lS/R4WrQmz6TUsvnBspaO9Z9zFc29rftAN37bzhEJbMaB/QU29hzLe M3xhHwth1OnEtMQEjkTOWdo7daLHJo3eBuhCTxn8BB9+/hlbkW5l X-Google-Smtp-Source: AGHT+IFzTntDqApDTAnL1g6GyTMtXHnjjv0+Ekcn43kwaqkrr7pFq/ZL82JAD9ToxQaZIxfyiLBkBw== X-Received: by 2002:a05:6830:651b:b0:71d:f343:5f5b with SMTP id 46e09a7af769-7265676f070mr10847417a34.12.1738426679061; Sat, 01 Feb 2025 08:17:59 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5fc104e27cdsm1476222eaf.16.2025.02.01.08.17.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Feb 2025 08:17:57 -0800 (PST) Message-ID: <072be5a9-e0fb-4073-85b3-4a8efcafae09@baylibre.com> Date: Sat, 1 Feb 2025 10:17:56 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/13] gpiolib: add gpiods_set_array_value_cansleep To: Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, Linus Walleij , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?UTF-8?Q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> <9931433b-5cde-4819-ac96-eea4f1f0f1f2@baylibre.com> From: David Lechner Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 2/1/25 10:14 AM, Bartosz Golaszewski wrote: > On Sat, Feb 1, 2025 at 5:09 PM David Lechner wrote: >> >> On 2/1/25 4:36 AM, Bartosz Golaszewski wrote: >>> >>> This looks good to me except for one thing: the function prefix. I would >>> really appreciate it if we could stay within the existing gpiod_ namespace and >>> not add a new one in the form of gpiods_. >>> >>> Maybe: gpiod_multiple_set_ or gpiod_collected_set...? >>> >>> Bartosz >> >> I was waiting for someone to complain about the naming. ;-) >> >> I was going for as short as possible, but OK, the most obvious prefix to me >> would be `gpio_descs_...` (to match the first parameter). Any objections to >> that? >> > > Yes, objection! As far as any exported interfaces go: in my book > "gpio_" is the prefix for legacy symbols we want to go away and > "gpiod_" is the prefix for current, descriptor-based API. Anything > else is a no-go. I prefer a longer name that starts with gpiod_ over > anything that's shorter but doesn't. > > Bartosz Oops, that was a typo. I meant to write gpiod_descs_.