From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932780AbdEKMlK (ORCPT ); Thu, 11 May 2017 08:41:10 -0400 Received: from mail-dm3nam03on0077.outbound.protection.outlook.com ([104.47.41.77]:45120 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754975AbdEKMlH (ORCPT ); Thu, 11 May 2017 08:41:07 -0400 Authentication-Results: cavium.com; dkim=none (message not signed) header.d=none;cavium.com; dmarc=none action=none header.from=caviumnetworks.com; Subject: Re: [PATCH v1 3/3] crypto: cavium - Register the CNN55XX supported crypto algorithms. To: =?UTF-8?Q?Stephan_M=c3=bcller?= References: <20170510130640.5838-1-Jampala.Srikanth@cavium.com> <3575749.J6klBtBYWh@tauon.chronox.de> <685383f7-6ae2-31fe-f081-2ac739343137@caviumnetworks.com> <2489871.hhvjNBQWWt@tauon.chronox.de> Cc: Srikanth Jampala , herbert@gondor.apana.org.au, davem@davemloft.net, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, George.Cherian@cavium.com, Nidadavolu.Murthy@cavium.com, Sreerama.Gadam@cavium.com, Ram.Kumar@cavium.com From: srikanth jampala Message-ID: <07399c55-d75b-096f-a5f7-16cdf92e92a1@caviumnetworks.com> Date: Thu, 11 May 2017 18:10:09 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <2489871.hhvjNBQWWt@tauon.chronox.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: MA1PR01CA0104.INDPRD01.PROD.OUTLOOK.COM (10.174.56.148) To BN6PR07MB3588.namprd07.prod.outlook.com (10.161.153.154) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 583098bf-8275-44f5-cc54-08d4986af67a X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:BN6PR07MB3588; X-Microsoft-Exchange-Diagnostics: 1;BN6PR07MB3588;3:vVNZaffkKr7LgizYlz0UJAKVQtnvUM+5DQ4vcj1rKpyZENLbpX7mxHRciO4tDtIhh8Pgqw6SLAJmwtmRpfuJ1+LFVTHtEvSoUcyblSWDiBr/FJrXFKl1L6km/gDa8LTVSng3eeI4ZOusQIBp/W9FYwNp+jqpIbWmurJq5mQ2EY/KCuaJk0Fj0vc1Yf9ALfwOSqPv8/BaMtMRBMSqhQ+0rWHvY7Ci+xvLPkLhyiRm1lhzmai2zBDecaZDGT5Pm+/u6fjySdxLJUl07niKTOXFfke25isCV8Ie1xxewoX1R8LaXkn5xJSBcv8qFi7rUmiMfl71oksqvUuLBJ6k2eDuAw==;25:jU6JvaPTjba+hLWizvsuNXrfN4La4WlH9zbMtdUkyaic2jGkUtBGdk9FKk33RqOnBEHsW0p8sN0p05oUDWDytZyC82Z71G8pUJ8tca+y3xucmwyoW/0n2FUSPiUUIi2GrJcp5BbVL3U/MMd1kLC7nMJhWE6UGxQpulecD4hCoqR+JO5ButSsrffZtk2wRj8u0CExRZLOVLphJtPoaS47eIBZv4JjQPN/zoRBKwwPCA2/xxzV0kX4P+R0gpQPyZuqZGNi/ArBN2qhJGs+Reg/SIPU/v42FcieedqV2P0Ak5iYA10JKUUxTfM7n+3uEWlgNklAexkjhcFvjbp4mKj2Nvmtk3Qx0Hx1dZW4wLt+7wKZyM/1868ba+7/gtGM1wSK5aOB5Mg7+PR3UiVSnfqgagOqeSnvxT+1ApzLetF3BWuifXcqxLGxGsTE/zb+74EgdJYUJrA8bSsoxEqUkV3UfQ== X-Microsoft-Exchange-Diagnostics: 1;BN6PR07MB3588;31:orM8cKFFKBgaQ2yShfJTw9baodZhJQwyET9ZgAVSEb6S/NW2OsWC4j9O/k6cTB5bsNimXckMo5xdnMX0+WmnftG/3jR8fCBrHB9Pi/GMnQfgk4LI5winANZcfLedN5YqM0C077qw70Sew54hPY4eaO3CLlD03QzDAJFhPLXQ7ijmzvKgFx0/eEWav69ASsOT0MT+m/gnwpGhIFR37TlRUHiuvkZHrQo2BfBJesTZ8PU=;20:MtkIOdPLtWdaQpVu+boF9e7qX0Zd/JCdFfv/YA1dZD0w4Dt4bhEyT/jonIY00+X0n8WKOUizhKzRvf1tD6RZUPCZvo62B1HDFCAegdylNPBn13vFM48EFJmTB8FIpjPI1FwY4e7+EYSPFEIheDAxYxg75n1IBJ1AaBTEO3GfoVfoas4VMrIaoIjocFps9CW7cGipTXcq+81la6LawDSlSbjw0hc00VYARCbBx3qjbjZv/PWwWcm3cc0W+q3VizCTNjFzL/Fr22NR9sY8QZx1BehtCjFJITVETo9O1AbtgX3LLRBlIgh6VkOzwOKHurCLYLHlRcVTOPLCzYLU/+paxJ7NsDdWcBAkrsZwoHDh/NsSJTlcK3WBprAL5l9my96epkX9E5yC8EEoejiA4reVdRYLdue5r4Uf5d7OE3QQva5LtwWWOG42Q6drr3HA44G1z1ZgVEMrFhtxUObzmzvJSbUXQf7nh8MkBrqb0JaNE+kPUj7l1ODHlL9I6uz75pI5ZhIrTIhtIfvFoWxHRt7g+t50SJezLRGLl66bcrA5aW6N46xcsB0hNDnFRupx87QESFcGHuIELVrmJQ0b3KmaADURSiq0VH7vWZB/DIp6UQM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(3002001)(10201501046)(6041248)(20161123555025)(20161123564025)(20161123560025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148);SRVR:BN6PR07MB3588;BCL:0;PCL:0;RULEID:;SRVR:BN6PR07MB3588; X-Microsoft-Exchange-Diagnostics: 1;BN6PR07MB3588;4:PmPtm+3xgBJ0Wbt7rY2V0x9G9ZJcadmzcG9p2SOGzicl10+2IsmlMRC6d6id75q5YHDQ70ivweYgxgZfKSOboL18U3yaaPLAaNCoK+tUpQHpNlL+BN6NSeu8crmAC9z6WuL9lBFqt4pKRMY3LCo95p2PthWvL7+tkc6JuFm0ZjbYIANSLTrAheydHc+ig7zRPyNJdtv+xLuoZe1XcX9cPdrFfbtvB9YKQ5pclvLNQvYV8E2fszGHQd8ado+IZT2QmX30ubmjzo10umBSs+XWg/xU2sZFfxFin3Jn+xgdQXYfUXGLV+efKNFYFFmE2JntPRRfEE8kOKWo5P4H+pwola4cNGkeB18mF5dosRr5Kuofx/yR0xiPc7ctX/z1BFbGV281jgVzQhDagaaLs8AKWHXJs3t2uQzkO6f4tItJHYe53AR4s/0GUGQpu4We1AQBXHA1WHushHtF/uc+mAbXvs8I1NPf8ad4X899SNfcPnHOPWw9e+Fy4UzET13VTEcNF2aQ/E8SShPM5pSuhXvvBr0FcsGmhgADvSeypFn4kXRYpc0a3gckH/f79/Ufm2FtKW8ptGjhFgbkoy1Y6tTg3XuBgDja/qSXD0UnWqms8wgmF2HaWGtyDadnV8vNBqhbaNGA6Ka3nW/oTw/7rW7WVqhqZghclU4TIH3Sf9nFYsLcEV0HEMoQ4ElQ9ZwKoZKf3Zu5D8FpFnqmudbMJlA2JETDYrDkl2OfnK2re3sp1ntF8fHKy9SVatiJDLa64YLagSrYA5yGTD4Bnqk1OspyiXNVsTGnxszvA/0l67LN4ZRwzNnSbzJlDBPYuvfvBUez X-Forefront-PRVS: 0304E36CA3 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(39400400002)(39850400002)(39410400002)(39450400003)(39840400002)(377454003)(24454002)(2870700001)(478600001)(50466002)(81166006)(31686004)(76176999)(53936002)(305945005)(47776003)(42882006)(42186005)(189998001)(77096006)(64126003)(6116002)(5009440100003)(66066001)(65806001)(65956001)(8676002)(93886004)(6486002)(83506001)(4001350100001)(3846002)(38730400002)(2950100002)(25786009)(4326008)(6666003)(50986999)(229853002)(54356999)(90366009)(2906002)(6916009)(5660300001)(33646002)(36756003)(31696002)(86152003)(65826007)(110136004)(107886003)(7736002)(6246003)(72206003)(23746002)(110426004);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR07MB3588;H:[10.90.205.39];FPR:;SPF:None;MLV:nov;PTR:InfoNoRecords;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR07MB3588;23:zt5/oWoPq1mom2hgu1BQBoDD5OFp8CdBGduVa?= =?Windows-1252?Q?/jJD3wGCUE52OkFXVSuuS7lYI1w+14wxOhLP8cIbb35j5DnvG5h+cR04?= =?Windows-1252?Q?HfSHND6y8rzxVfYgdT42d09a3fFiHW0FiHcQ/RQWLl2Mzs/WQQd2jh9u?= =?Windows-1252?Q?Bv6UEHIeprFFC7FdyS+HebpeJPW07VivtRAi/9o2TDqr5GE6K+sR5LR8?= =?Windows-1252?Q?7OY3HrLIZLy+2unyiRTmvXdzdbb86VsPILfWAgh4ZQXhQ76sSbJesM8h?= =?Windows-1252?Q?NXS9Yj87GTADutwDLCr7nZpJFx3d8hImmxn3e+SEJIIrj1XoI8qW2k+J?= =?Windows-1252?Q?i09GDYioHKxHKKyLUeXyBofoPmEMdhlFUz6O7j8c8fZnJTfLB+MUYFSx?= =?Windows-1252?Q?SFtxqyEeSuapYWap6oEfFRGzeMUA7/q0ZOYAtlGd3scHpVQoqNLfzjTZ?= =?Windows-1252?Q?K7qG1ZVmG/rpDusOu2knGqDlCgloSWwP3rh49344VTvr+l67a4CJrJo0?= =?Windows-1252?Q?2hciXWML+AomDxFPr6Q5MdfiIS0Tn15LJ5njj1AHMQI4ZOBiD1tgWxDF?= =?Windows-1252?Q?3YJEZtR36oDmGQAU0hMK6IXDjWvC/9i9xLJF/e/pvoCsQVQMQ6wPcUkH?= =?Windows-1252?Q?PkznUjJYrgUE+imzRGolCZI6HL2Stdf6XYNQetUPV+jmSwFmmV3lU1Uw?= =?Windows-1252?Q?c4spYAqXOP0ZOvcV1TiIAs5Ln7+nyz6Sd2+jKfvJHxMwOykT68O5wVd3?= =?Windows-1252?Q?Xjwe9leRf9flhaFrbcy78qqxZMPQP7VABt7a5Ia/FTzPzktKCfTHLrUE?= =?Windows-1252?Q?2Lzwz/NAUW0eLKI1EZ2xggPyMQDa2/8DXP4MOKbqHnB6MxaA97FbYJg8?= =?Windows-1252?Q?D+pnixqJJzVzlfhD3eH0S+iGvZdh+ZeI0zt4GmswvSCWz6k6lGEaaQqw?= =?Windows-1252?Q?MmCUUo2oFWyBJ55RDlJ7+WCCWKWCZ43cAlacYdIQDUFo7rNmbdSrBnst?= =?Windows-1252?Q?znTvShXjYpPBMOJbUZlc0IF9LHpRiLtxjgtisasymi19D/DDqH84werQ?= =?Windows-1252?Q?N5m8EB7W3m2t5AmPxmdmCyki15am5QAj0xtR7uW245WcKrrB70MxHCZp?= =?Windows-1252?Q?yOjkwnPi+alYnPlGKVZcdLce3SSBegyFcOXXnKcQEapElaz3TTM+oC0a?= =?Windows-1252?Q?MBVzXg+r05XKHgSjq6cL5CUa7kEGSbBsIDPZxrewbWLhz1M2FjIocgW8?= =?Windows-1252?Q?9QdxVcAvYFeVnxL7HqJfAH3GaaXoGYO6qCcsEwlbCp66inPy1FAdQt7W?= =?Windows-1252?Q?XIXgP7Vdgd6F8IvKpQt+YV5BVGLgNdEpzd+Xw7PCoMSilNPmtslI6/0Q?= =?Windows-1252?Q?ZQkYGoZuzII4LVjMpEWXrDHhI4HgK6wbpK0FQaHGVqw1yckDD4E7B30l?= =?Windows-1252?Q?DC46bu6IbmY1SbC8QVIDQzCpKr+87W4tlGyZB9w89n2FIfzPKDv/QfQr?= =?Windows-1252?Q?ukCyWFfDaNqeRWcCHJB7CAyekVhqGwDWj0qE/s4UI15KC1Gz1SIzY86I?= =?Windows-1252?Q?Qqo1Ull3r1QrPF+lxT67pMruG0peNpPdBSG?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR07MB3588;6:HsPH9tRl7BcDWsMX3KRmdz9oFlbKOOrAAkPlE4h4qRzIUbXPMXLkQxcivUaoTJjot4PvqyW1o2lon1dvqNLvAiG1ovIYUFF6a3Xk+FwB4oUF4yoUxVo2BbsbUrnOiCxdr9nkysw1qLUuD/efsMBP4dr1BO18qQoruKdLA/BSrdbMJ58Rea1BAhy59nZm2WRkb0DtGPb+rhqXZLa33FRwKliQMFpqkBZ+hk+9HvQz87/vMTCY/2yPS1VRsV7v3wPrjMxgIK+dcnci1dMoIy4RUDcXj6iaG2hGqdQtGIQxejbxE0n0AknyTOcrsaxqhtxXZ5ezF8AnEc9n970mXLj14+Z/izJiyAx0nkDcr0hc0ZRTUknAehvDLP+NAy7Qu7eDqcLgSHXgsfcGnc3uBMwC2G6PjUNPxxAMKCbsqZDWleUh4UOSW+gkwd4Kiy1KO7fMUZ3oBqsDFSUwm34pmt0tw61PofqMjBTIS2OhIjLcUqbHu4Gaa/nD/45WMe6XZXMw0/a1YjIlpAb46ctd7gDiHg==;5:whjp9LyJuKViY+L9P7lTDFu6Yxc9rQsCMd2GzEcyfHmB+PMRerE45vj4/d0TqnH75FNH6vkSRzfmXc0BY+iqDBq/0XKtvvKE/aCcb5DyGaZ8Eb1zzDq2ZJY0UzOzcQfP8yPYiPhWHsb1bwJKU7Jabw==;24:faHwne68kWuLBXpZC9dfBFFRL1pU+Ka7gtNaamZ2s4Z/ETOsCrc7gDnYZHCf3/+hhDfgy/Gur1WG2pUN0pWKezATuxhJ16WKq2IkEAGSCng= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR07MB3588;7:irjJc7icsBf732a12HRoF0W7LKsvP9q3AjhnKnraBIBgL/QSc46bGhzhyzvABXJugkIJiocqSuuNXqnORbJ9O3SsN0EZRDV+5nkalH/4SZbr3XhAxLkLHvP1KzHUm3BopDbctf7VmGqP4hOuWaaZXoSmZUs32nL1dOd2+36ykqbEH+HBOVrfoK+Q0qOZVMVH1BB6L+vk0badhmwXJE9lqti8AcSw7lyskNxwWid4oPi2AHQtqzT6NQbLozn8T1WVh8t/dpLgLMbiuIVJDXD2P49kUSCMEPu/ZppNcp+harNdbnjcf9Q44N/zAO7NAcqgJBRGfH3RcQ+r8H5B5PR2dg== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2017 12:40:49.9235 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3588 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephan, On Thursday 11 May 2017 05:52 PM, Stephan Müller wrote: > Am Donnerstag, 11. Mai 2017, 14:18:34 CEST schrieb srikanth jampala: > > Hi srikanth, > >> Hi Stephan, >> >> On Wednesday 10 May 2017 07:26 PM, Stephan Müller wrote: >>> Am Mittwoch, 10. Mai 2017, 15:06:40 CEST schrieb Srikanth Jampala: >>> >>> Hi Srikanth, >>> >>> In general: you are using the ablkcipher API. I think it is on its way out >>> and being replaced with skcipher. >>> >>> Maybe it makes sense to replace it here too. It could be as simple as s/ >>> ablkcipher/skcipher/g >> >> Sure, I will do the changes accordingly. >> As per my understanding, I see the following changes, >> 1. CRYPTO_ALG_TYPE_ABLKCIPHER changed to CRYPTO_ALG_TYPE_SKCIPHER >> 2. nitrox_ablkcipher_foo() changed to nitrox_skcipher_foo() >> >> Please let me know, any other changes I have to consider? > > What about all crypto_ablkcipher* function calls / structs? Also all > ablkcipher_request function calls/structs? I will work on the changes suggested. >> >>>> +static inline int nitrox_ablkcipher_setkey(struct crypto_ablkcipher >>>> *cipher, >>>> + int aes_keylen, const u8 *key, >>>> + unsigned int keylen) >>>> +{ >>>> + struct crypto_tfm *tfm = crypto_ablkcipher_tfm(cipher); >>>> + struct nitrox_crypto_instance *inst = crypto_tfm_ctx(tfm); >>>> + struct flexi_crypto_context *fctx; >>>> + enum flexi_cipher cipher_type; >>>> + const char *name; >>>> + >>>> + name = crypto_tfm_alg_name(tfm); >>>> + cipher_type = flexi_cipher_type(name); >>>> + if (cipher_type == CIPHER_INVALID) { >>>> + pr_err("unsupported cipher: %s\n", name); >>>> + return -EINVAL; >>>> + } >>>> + >>>> + /* fill crypto context */ >>>> + fctx = inst->u.fctx; >>>> + fctx->flags = 0; >>>> + fctx->w0.cipher_type = cipher_type; >>>> + fctx->w0.aes_keylen = aes_keylen; >>>> + fctx->w0.iv_source = IV_FROM_DPTR; >>>> + fctx->flags = cpu_to_be64(*(u64 *)&fctx->w0); >>>> + /* copy the key to context */ >>>> + memcpy(fctx->crypto.u.key, key, keylen); >>> >>> Could you help me finding the location where this memory is zeroized upon >>> release? >> >> Currently, we are not zeroized the context in release. >> We are doing it at the time of allocation. > > You store a key in a piece of heap memory. I guess you want to zeroize that > key memory before releasing? > I will do the changes. > > Ciao > Stephan >