From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCC995C613 for ; Sat, 10 Aug 2024 02:40:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723257618; cv=none; b=fpBphC20xvEi3+LAIoBQ8P+u0hfTzcXavVh7dRiqDmbPU4J6cVv8mBfCwBZxT+AQPqe+UR2jPoQrDzZoUW5oVP/IbyjCT7PtZs0aUakaOx8hfP5lUZR1m/zYw/84ZVXeaQ3o7eFEi+CPX0mZh2SoW5RG8mN0gJ5CqXp/tQzrtZk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723257618; c=relaxed/simple; bh=/t4N2EpRej9Nw8dBm5BekuDxs4KN8eEZDhvk9yRRrCg=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=fLKgh6Wj/3gmjoXVXqj5KVDvwxsVXa5TijlLvuqLHOgnthZ/RmffpB7Nw11UgLpCT3zRq5EoCmsSYLOPIajQwT23A+rdRVKAvOaRNNHyFYlg/q+QhYuq0MHKjlPyCgSzimEJ20/+SKBMgw4imYitZ5Zo1LAufyUWaW9wVXxSsAw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=g5uHBYuw; arc=none smtp.client-ip=95.215.58.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="g5uHBYuw" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1723257612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/t4N2EpRej9Nw8dBm5BekuDxs4KN8eEZDhvk9yRRrCg=; b=g5uHBYuw68UX4C7Nli5TccRTBS5K0bOHFp11jm7Cq2fGikdF8n3+EMxSwqgv0fBVpXxPMg A0P4h1fs86Ier/tFI6v08e0r8bgzh8JAqG4ZyxtRJcJC13SW0ZrJZ0UahCtuVITCW/ZRYp Zub2TPPjvRXT8DqJY9YjTVs1L/PWMtc= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Subject: Re: [PATCH v5 1/3] mm: don't account memmap on failure X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20240809191020.1142142-2-pasha.tatashin@soleen.com> Date: Sat, 10 Aug 2024 10:39:35 +0800 Cc: Andrew Morton , Linux Kernel Mailing List , Linux Memory Management List , linux-cxl@vger.kernel.org, cerasuolodomenico@gmail.com, Johannes Weiner , Joel Granados , lizhijian@fujitsu.com, Nhat Pham , David Rientjes , Mike Rapoport , Sourav Panda , Vlastimil Babka , Matthew Wilcox , Dan Williams , yi.zhang@redhat.com, alison.schofield@intel.com, David Hildenbrand , Yosry Ahmed Content-Transfer-Encoding: quoted-printable Message-Id: <073C55C4-927C-4942-AFF1-E2D9D039F138@linux.dev> References: <20240809191020.1142142-1-pasha.tatashin@soleen.com> <20240809191020.1142142-2-pasha.tatashin@soleen.com> To: Pasha Tatashin X-Migadu-Flow: FLOW_OUT > On Aug 10, 2024, at 03:10, Pasha Tatashin = wrote: >=20 > When we fail to allocate the mmemmap in alloc_vmemmap_page_list(), do > not account any already-allocated pages: we're going to free all them > before we return from the function. >=20 > Fixes: 15995a352474 ("mm: report per-page metadata information") > Signed-off-by: Pasha Tatashin > Reviewed-by: Fan Ni > Reviewed-by: Yosry Ahmed > Acked-by: David Hildenbrand Reviewed-by: Muchun Song