From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752208AbcBPB5Z (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Feb 2016 20:57:25 -0500
Received: from linuxhacker.ru ([217.76.32.60]:53936 "EHLO fiona.linuxhacker.ru"
	rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1751892AbcBPB5Y convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Feb 2016 20:57:24 -0500
Subject: Re: checkpatch falsepositives in Lustre code
Mime-Version: 1.0 (Apple Message framework v1283)
Content-Type: text/plain; charset=windows-1252
From: Oleg Drokin <green@linuxhacker.ru>
In-Reply-To: <1455584189.4046.28.camel@perches.com>
Date: Mon, 15 Feb 2016 20:57:13 -0500
Cc: Andy Whitcroft <apw@canonical.com>, LKML <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: 8BIT
Message-Id: <073E66B1-D39F-4D03-BDC7-68B18172BA5D@linuxhacker.ru>
References: <1E5E2198-2E5C-4B6F-AAA5-C28E0A776714@linuxhacker.ru> <1455584189.4046.28.camel@perches.com>
To: Joe Perches <joe@perches.com>
X-Mailer: Apple Mail (2.1283)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Feb 15, 2016, at 7:56 PM, Joe Perches wrote:
> [etc...]
> 
> Yeah, that's a defect of some type.

Also while I have your attention, here's another one:

struct cfs_percpt_lock *
cfs_percpt_lock_alloc(struct cfs_cpt_table *cptab)
{
        struct cfs_percpt_lock  *pcl;
        spinlock_t              *lock;
        int                     i;
…
        cfs_percpt_for_each(lock, i, pcl->pcl_locks)
                spin_lock_init(lock);

The declaration of the spinlock pointer produces:
CHECK: spinlock_t definition without comment

Should spinlock pointers really be included in the check, it's obvious that
they themselves are not really protecting anything, esp. considering it's a
local function variable here.