From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B745241CAF for ; Thu, 19 Jun 2025 08:04:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750320298; cv=none; b=lcwzvNL+N6Jquxxk138TqxAcaVPoNJvaeOov8WWcoj/RVYK95Ft0s90l+DA9A/ZgZWBqpwY5x8s/m+MtHSAvb/Eoe0i/OUnAsjn/EPug5UvF/T6tIojUMoU5gpN4LVI1uaafLCdaW8K1L41IktJuMIfXbaQs1F/TVtZcWV3/7BQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750320298; c=relaxed/simple; bh=PbpTuz4WTa28cFpAxtpOHQNwNhJ0jkygBok3OeWvnoA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iSlI1SuWksrwbsJRuIJkDlEZ9Ot9yX5h/pt4BaLOZoOVSdBg+cajqFcnG/IDX3bbSWRADmFuQ/uJ0dsW8x01mZhJUUw8u1AASXr8FJaqX3UiBtRzF3v40wR4a4u12cnWdEmAx0QTTZ56eYMCkclevADv2UCSfSDk8Koo+IdXIzc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=i+1PGMhf; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="i+1PGMhf" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55J5vB2i003266 for ; Thu, 19 Jun 2025 08:04:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= l5CbaYk82IflDePG5vYT+cBebOeLvhXszPekPl5GZ2g=; b=i+1PGMhfpRspR4H3 WDFJVrXsmTNkhW7gw6r4LfxvGRv3y/HmOeHN4FnQb/l7BgzaeMOZgGjLPhLPucZm hrEb02cLBHd9AG/uC5DUVjDjuttrWpTjLVCU5XpiJvei9oTDyhLbz/Bxy1M0VtMH sUNhfyVEJsuAJBUED3fYFI8wvqD4Onim1BhQd6bwuUIvBIQOfiswDqC1OGysjqCg /mFqedjpI12RLGlw8GSnD/KkRiSg893FKk199dG9bu/YwM4ankAVhHVnSLAQrYA7 w5ytGDkBWHS9CT3SNAAqmVbogPy3udWxvPt9E1y2niP7hcPtLkYtSwQq7uPyeRgH +qfi0g== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 479qp5wsak-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 19 Jun 2025 08:04:56 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2358ddcb1e3so8528955ad.3 for ; Thu, 19 Jun 2025 01:04:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750320295; x=1750925095; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l5CbaYk82IflDePG5vYT+cBebOeLvhXszPekPl5GZ2g=; b=wsQLT8Z9o/jS5Pq/LkcZWSooEJZz/2n6Ux16SUyrOh9CEiJ/faAn/rfmtbe3Xn4gIv rx4T+DESmMcbPYKc7HnsNNxkKmBwO52tiir3Oj2sZ3DGvaKM0ddbrXQhS8QUxc7qeyt6 TZl3XmsOufQcpOJGHSM2r8grGdrlBDTOyNaX10N4xwNjBdtJv1dcaRtbMiwlJ7jb2wCT GR1xSwNFgh8M5fd/Q9wkyrtMVcGUKFWSIyREbK3IrfcuglqrASXpJ0JVwENsYIKXvRey kvZscblyuPNusggzHaKaDmYlH/klqK3LaexWnR/MQVMW7u+5tAMyPVyT3TZVA2xuWa8O sNMw== X-Forwarded-Encrypted: i=1; AJvYcCUqD4+2KTOOuDnqHODbgsq4tQpybab3VFFLnkk2iIyhwKC+t+PK73OtprU8bOemAeKUi9gubOjwzaefPOc=@vger.kernel.org X-Gm-Message-State: AOJu0YzJvTf7wdxCRVMtLZGbQS+sfJdYdIoxuP7mhg1QI9jXwwvOxttx wloE1hCGb5KZTu+lOORFxGR4LAZ39G9iTT6Kv6jCy2kYPMWSUKt054E0MvNKkAeop2QLyUUMKc8 SV1P8x67jXSpLdIRJEmcRy0hKMYcYV3cqT4mHQgklKLYk19guRYrGFMCrCMrLcQfXib0NqrRUmk A= X-Gm-Gg: ASbGncviOiDpAPwqgpPuDUCV+xHFOL/VsDj5ZlkLE76YLe3JhYdYp0Mittq1r09mRPL e1D8ul39PsGkKcS0ane7KQcSqZJSGHa34cBorEIC1tMnLynb017qQJgdjZDeUi4lq3KCTme36sr wri46Kt/8q/7601STsvuvI8gADY9fRSTBrdRH6mEZY1xEJRLLbktH29HTjW0nDWBDESHy3pwwSs qfrJ4rBDZT7f5QdgWrRC2DRtcF/D9iKonoRLcYOrSsQndAJyr5mIpd2OX5upp/SNJ7sZiBseDuc dmuLstTd9wY5aSeiPZ/ntjt6NgOEOQujl0hdP8wfKS71rEF5L5Td28F7q05e X-Received: by 2002:a17:902:e94c:b0:234:df51:d16c with SMTP id d9443c01a7336-2366b149ff4mr331118495ad.45.1750320295205; Thu, 19 Jun 2025 01:04:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGY1beQgQr3/xXUKU2HPw/CdQ0Sirtdrq7sSeNKyvBRqo0slYfZrHuVzsUs/ENA+cfekMDTEQ== X-Received: by 2002:a17:902:e94c:b0:234:df51:d16c with SMTP id d9443c01a7336-2366b149ff4mr331118135ad.45.1750320294704; Thu, 19 Jun 2025 01:04:54 -0700 (PDT) Received: from [10.218.21.68] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365deb2ce2sm114714615ad.161.2025.06.19.01.04.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Jun 2025 01:04:54 -0700 (PDT) Message-ID: <073c293c-325c-484e-b843-80e254716d7c@oss.qualcomm.com> Date: Thu, 19 Jun 2025 13:34:48 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: qcs9075-evk: Add sound card To: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_pkumpatl@quicinc.com, kernel@oss.qualcomm.com References: <20250616070405.4113564-1-mohammad.rafi.shaik@oss.qualcomm.com> <20250616070405.4113564-3-mohammad.rafi.shaik@oss.qualcomm.com> <6463f18d-b258-4773-aa12-d3ae3af60715@oss.qualcomm.com> Content-Language: en-US From: Mohammad Rafi Shaik In-Reply-To: <6463f18d-b258-4773-aa12-d3ae3af60715@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: QHwDuW7L2EjvRqEoWgvFSMO3zZvuzFGC X-Proofpoint-ORIG-GUID: QHwDuW7L2EjvRqEoWgvFSMO3zZvuzFGC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjE5MDA2NyBTYWx0ZWRfX44f5HVY2/BmJ EjLbj28t+EXKARIismqP8DfgxncM0o06wGW6UCqEr/LRhLYftZd9aqaneP8O62ZYpHA9lleEglz fhnaVUUjTYS6jMsPnspUymVFFqMII9TaQJXdDkUxymSN+9jYEehi4l9Rnu25vwtO5fTgMiQo5dx 7Hw/173ZOIyjFHcIbwX0lItxNs0NgrCuRrHYlwezdUxpzCPKxbkWmGd81NwEwQg5EsoTiPwbnWs h+gKD1Ck7qJ9G5IZVf3ya9wf7o4A8bIqZ3T2Zyz2maAsYYziDAyn4b7ueZgWNKrM1oDGbeb/ykO QjHjTifEEucOb+St0zXJAwoSmQZ0sd60bItGWsj+JmP8EhyH5XUZGOIQw30FDa/Rm+qXME61IO+ xBvNAhvEEkt78CanszD/xdCgt87TC5Zvdktb7Li2sFsNasFgtPqswO+QlILr4pSVD3tGYIWJ X-Authority-Analysis: v=2.4 cv=fMc53Yae c=1 sm=1 tr=0 ts=6853c4a8 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=EUspDBNiAAAA:8 a=yNxIl_n-nE1iyR5tU-sA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-19_03,2025-06-18_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 bulkscore=0 clxscore=1015 malwarescore=0 mlxlogscore=996 spamscore=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 priorityscore=1501 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506190067 On 6/16/2025 4:54 PM, Dmitry Baryshkov wrote: > On 16/06/2025 10:04, Mohammad Rafi Shaik wrote: >> Add the sound card node with tested playback over max98357a >> I2S speakers amplifier and I2S mic. >> >> Introduce HS (High-Speed) MI2S pin control support. >> The I2S max98357a speaker amplifier is connected via HS0 and I2S >> microphones utilize the HS2 interface. >> >> Signed-off-by: Mohammad Rafi Shaik >> --- >>   .../boot/dts/qcom/qcs9075-iq-9075-evk.dts     | 52 +++++++++++++++++++ >>   arch/arm64/boot/dts/qcom/sa8775p.dtsi         | 14 +++++ >>   2 files changed, 66 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts b/arch/ >> arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts >> index ab161180d1d5..d073c6f95d4c 100644 >> --- a/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts >> +++ b/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts >> @@ -5,6 +5,7 @@ >>   /dts-v1/; >>   #include >> +#include >>   #include >>   #include "qcs9075.dtsi" >> @@ -21,6 +22,57 @@ aliases { >>       chosen { >>           stdout-path = "serial0:115200n8"; >>       }; >> + >> +    max98357a: audio-codec-0 { > > This wasn't sorted out properly. > Ack, will take care in next version. >> +        compatible = "maxim,max98357a"; > > No SD_MODE pin? > Yes, SD_MODE pin is always on in this specific qcs9075-iq-evk board hw. No need to handle. >> +        #sound-dai-cells = <0>; >> +    }; >> + >> +    dmic: audio-codec-1 { >> +        compatible = "dmic-codec"; >> +        #sound-dai-cells = <0>; >> +        num-channels = <1>; > > no enable GPIO, no vref-supply? On qcs9075-iq-evk boards the enable gpios and vref-spply is always on. Not configurable from DT. Thanks & best regards, Rafi. > >> +    }; >> + >> +    sound { >> +        compatible = "qcom,qcs9075-sndcard"; >> +        model = "qcs9075-iq-evk-snd-card"; >> + >> +        pinctrl-0 = <&hs0_mi2s_active>, <&hs2_mi2s_active>; >> +        pinctrl-names = "default"; >> + >> +        hs0-mi2s-playback-dai-link { >> +            link-name = "HS0 mi2s playback"; >> + >> +            codec { >> +                sound-dai = <&max98357a>; >> +            }; >> + >> +            cpu { >> +                sound-dai = <&q6apmbedai PRIMARY_MI2S_RX>; >> +            }; >> + >> +            platform { >> +                sound-dai = <&q6apm>; >> +            }; >> +        }; >> + >> +        hs2-mi2s-capture-dai-link { >> +            link-name = "HS2 mi2s capture"; >> + >> +            codec { >> +                sound-dai = <&dmic>; >> +            }; >> + >> +            cpu { >> +                sound-dai = <&q6apmbedai TERTIARY_MI2S_TX>; >> +            }; >> + >> +            platform { >> +                sound-dai = <&q6apm>; >> +            }; >> +        }; >> +    }; >>   }; >>   &apps_rsc { >> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/ >> dts/qcom/sa8775p.dtsi >> index 07ca6dd4f759..968730da180d 100644 >> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >> @@ -4711,6 +4711,20 @@ tlmm: pinctrl@f000000 { >>               gpio-ranges = <&tlmm 0 0 149>; >>               wakeup-parent = <&pdc>; >> +            hs0_mi2s_active: hs0-mi2s-active-state { >> +                pins = "gpio114", "gpio115", "gpio116", "gpio117"; >> +                function = "hs0_mi2s"; >> +                drive-strength = <8>; >> +                bias-disable; >> +            }; >> + >> +            hs2_mi2s_active: hs2-mi2s-active-state { >> +                pins = "gpio122", "gpio123", "gpio124", "gpio125"; >> +                function = "hs2_mi2s"; >> +                drive-strength = <8>; >> +                bias-disable; >> +            }; >> + >>               qup_i2c0_default: qup-i2c0-state { >>                   pins = "gpio20", "gpio21"; >>                   function = "qup0_se0"; > >