From: Markus Elfring <Markus.Elfring@web.de>
To: make24@iscas.ac.cn, linux-rdma@vger.kernel.org
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Danil Kipnis <danil.kipnis@cloud.ionos.com>,
Haris Iqbal <haris.iqbal@ionos.com>,
Jack Wang <jinpu.wang@ionos.com>, Jason Gunthorpe <jgg@ziepe.ca>,
Leon Romanovsky <leon@kernel.org>
Subject: Re: [PATCH] RDMA/rtrs: server: Fix error handling in get_or_create_srv
Date: Tue, 4 Nov 2025 15:55:37 +0100 [thread overview]
Message-ID: <073e1aed-11d4-4410-b40c-1d4684f3c192@web.de> (raw)
In-Reply-To: <20251104021900.11896-1-make24@iscas.ac.cn>
> get_or_create_srv() fails to call put_device() after
> device_initialize() when memory allocation fails. …
Why do you propose then to replace a kfree(srv) call by put_device(&srv->dev)?
Would an other word wrapping be a bit nicer for such a change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc4#n658
Regards,
Markus
next prev parent reply other threads:[~2025-11-04 14:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 2:19 Ma Ke
2025-11-04 6:34 ` Jinpu Wang
2025-11-04 14:55 ` Markus Elfring [this message]
2025-11-05 12:57 ` Leon Romanovsky
2025-11-05 13:46 ` Jason Gunthorpe
2025-11-05 14:51 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=073e1aed-11d4-4410-b40c-1d4684f3c192@web.de \
--to=markus.elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=danil.kipnis@cloud.ionos.com \
--cc=haris.iqbal@ionos.com \
--cc=jgg@ziepe.ca \
--cc=jinpu.wang@ionos.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®