From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FA033B3896 for ; Tue, 7 Apr 2026 13:15:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775567704; cv=none; b=ckWSWISkEHzBg+p6qbugcczePuq7mdnv+yHmrW68PkWtk6wQWDESMtmqxABrOUE5dUY+rrd6KkeBFJKqJv8L6DbZWiqNPejP0dnwsx/A56WPjwkYNlLXNP76m20DyOP4xh6F0xH9Cyh+2pMBJ9ktCjWN6F5v7yqRuRqN0CIA3G4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775567704; c=relaxed/simple; bh=DF92KS7lR8TG5SktVvEPsLa9rP8Xq/XSF2frVXwEcDQ=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=TGkLqUivUk38LA3reKRIu17ME3f/R7nuXKd+ooi0FcfhOapwDduFRZ6JOynUJBN91CuUTxpKpzIOn19xzyg5lMb0Gmza8+bitdtAJORPNAixu0iCymsh1sEAlCgTMAqgj4YkRHI7gjngxgEqOBnVVGiQNsaA86bDn0Hxzw6h8kk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MTdbOMJf; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MTdbOMJf" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-43cf5f6d2eeso190023f8f.0 for ; Tue, 07 Apr 2026 06:15:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775567702; x=1776172502; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=uJvui/baQIu/txwJ5Ha20q2FY1f9Fze38J+v8nYikoA=; b=MTdbOMJfQ535jCQ+aiD+tMAPmx/VsEXx+6Y0bcx0sIxiTol37cEMuxS6culODqZQca ishbncW9tdovM9HTjasVIE6hCKx17mnpVx6CBUttgtJJESn9EXe2Wf3ruwAmgq3dGn8E DUKLk89UtUZrcq8O9kgqKq51u7HnamzEgce9iIdh3NKsogWIEEVdpVw0oZL52uqdPsOh QJoEwGwXgK6Gjcg8gJ7OnfVV3i1yZNqtc/845lVodh0KqMhRNjYlOcsj2Ti70YYcgYxF vygk2WzLzi9ZmMi4bDgHRAh7NFwB60PCfIae4nuE78VYSMY+u8P9KPCNEChZi+6JYLDE VXDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775567702; x=1776172502; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uJvui/baQIu/txwJ5Ha20q2FY1f9Fze38J+v8nYikoA=; b=EasNpK3hrNmDNzLbQZb4BHh+Mf9qWpKRLK/WD3RO+WkwYVHzj0s6MU8NdfCSwn/oKf QCpbJRczsGpdI3pWISc9mK646iZam9b5seRc9CmTKwIz4Ga6Ufzs+A8ZdnDbsiqz474S wQ8+GpLcedOb+DdizlD4ESaC5A8CCxvp5PT+XutQ+cGgzFf+L34kDdYTBq27wgZA6C4a +GnyP+pC3MqFCluVu24GdnSRlQwERHKH0lXZvAtIfoDAgD5vNrPmqlunDekjwMXt8uJ/ baAoJwj+HLMLSox1kDhR4EQ/PnshP7iYzJbK/K0BxQcZ0dQc619l1nez6c3XEX3IirQZ N4dw== X-Forwarded-Encrypted: i=1; AJvYcCW/rZjqqZaa+jCxPqgYmMQBbif6QkNZ9QbQcnKYpuH+GVy25heFGS/ptXjYFRV+aa/BAOCKqIK++X09tww=@vger.kernel.org X-Gm-Message-State: AOJu0YwHQyRag1C4cO0/NnZu8PRaQmbvse935UgGI2sZDLRsp9R2q1P3 kLR1Q2sSxp61jGm6DsgkossRkUpc1soqUDVe62MFsSZemefSvXY6i6p8 X-Gm-Gg: AeBDietp9Kb6YJcJZpGLvSRfDIW0iQiP+TrbZ5VAm09YgGhDtKfq1jvaftQz02shZPv jvKVt90WZvwskLj1UCTbecAo/LRbyJO3ry+54ykmiRXeoL+XTeN7ZyTNYWPa/srrMqNM04wKoE3 vUxczEvzdF7n8BUNmGdf0nYlRr3vRbPZiOdX+bMbuDCl5QV/hJQy09hjIWjbt/dn4pC+6Uq5Aa6 n6YmX5J/PWuaMuIu2+BtKgTwf7wo/fUt4VZRpxP7HkyY5ks4jq5dqCIUN5c5jpxvh9RBuOQ7Jxi B33CBy1ELcKibP7q9x3cfaRw5NsrHbU/DB+RGce04g6f9ShErs0SfB5Nn+KxTVL6c8WhNHiEem4 +m+FgSGx3bITh90G+6XPqRTrWjWLdym0rrmsgz3O9ZTOyKFl7UBvwI+CqTRHAdEZY9xFr6MUYxt FVEyaBcz+JZS6gyEtM+Aw3dfKV1qf28AGkPQFQQQIWsR7BCFuKFXFLYaB26DN02UjkjQ== X-Received: by 2002:a05:6000:26c3:b0:43c:ff6f:d5c with SMTP id ffacd0b85a97d-43d29262a74mr12097140f8f.2.1775567701402; Tue, 07 Apr 2026 06:15:01 -0700 (PDT) Received: from [128.93.82.131] (wifi-pro-82-131.paris.inria.fr. [128.93.82.131]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e2a6f1esm47942710f8f.2.2026.04.07.06.15.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2026 06:15:01 -0700 (PDT) Message-ID: <0746a585-710c-4bf0-b54a-41573d56a2e5@gmail.com> Date: Tue, 7 Apr 2026 15:15:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Thomas Fourier Subject: Re: [PATCH net] can: sja1000: Fix pci_iounmap() buffer To: Marc Kleine-Budde Cc: stable@vger.kernel.org, Vincent Mailhol , Wolfgang Grandegger , "David S. Miller" , linux-can@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260330154236.98665-2-fourier.thomas@gmail.com> <20260401-effective-piculet-of-will-704d4d-mkl@pengutronix.de> Content-Language: en-US, fr In-Reply-To: <20260401-effective-piculet-of-will-704d4d-mkl@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/04/2026 12:59, Marc Kleine-Budde wrote: > The cleanup functions in this driver are a mess. kvaser_pci_del_chan() > should only delete one channel, but it deletes all. It also unmaps the > iomem, which belongs into kvaser_pci_remove_one(). I'm not quite sure because kvaser_pci_init_one() allocs and registers all channels, so kvaser_pci_remove_one() should too? > What about switching the driver to pcim_enable_device(), > pcim_request_region(), pcim_iomap() functions instead? I can write a second patch to do so, this would for sure solve the problem. Should I? I have no way to test it. > When called from kvaser_pci_remove_one(), "dev" points to the master > dev, which uses priv->reg_base without an offset, as it's board->channel > is "0", right? I think you are right, the normal path is fine, but not in the error paths for devices with channel other than 0. Regards, Thomas > When called from the error path of kvaser_pci_add_chan(), things go > wrong, and in the error path of kvaser_pci_init_one(), the pci mem is > unmapped again. > > regards, > Marc >